Review 14.3 Merged

97549[BUGFIX] Evaluate only the workspace version for page preview flag

Benni Mack CR +2 V +2 Normal +50 −4 updated 11/11/26, 15:57

Commit message

When a page is hidden in live but visible in a workspace,
PageRepository::checkIfPageIsHidden() reported it as hidden. The
PreviewSimulator then enabled "includeHiddenPages" for the whole
workspace preview, so other hidden pages showed up in menus and
rootlines as well.

In a workspace, only the workspace version of a page - or the live
page if there is no workspace version - decides whether the page is
hidden. getWorkspaceVersionOfRecord() already checks exactly that
record with the RecordAccessVoter, so its -1 and -2 results are
sufficient.

A page uid that does not exist no longer causes a TypeError in a
workspace context.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack commented on patch set 1 11/11/26, 15:36

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Domain/Repository/PageRepository.php
  2. core-ci voted on patch set 1 V -1 11/11/26, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114110

  3. Benni Mack uploaded patch set 2 V -1 11/11/26, 15:46

  4. core-ci voted on patch set 2 V +1 11/11/26, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114112

  5. Benni Mack marked it ready for review 11/11/26, 15:56

  6. Benni Mack voted on patch set 2 CR +2 V +2 11/11/26, 15:57

  7. Benni Mack merged patch set 3 11/11/26, 15:57