Review main Ready for review Breaking

97754[!!!][TASK] Bind parameter keys in file dump token

Oli Bartsch CR 0 V 0 Hard +417 −17 updated 11/18/26, 16:12

Commit message

The token of a file dump request (eID "dumpFile") signed only the
parameter values, concatenated with implode('|', ...), not the
parameter keys. Equal values under different keys produced the same
token, so a token issued with a size or crop variant could be reused
with the value moved into another key, which dropped the processing
and delivered the original file.

Token creation is now centralized in FileDumpService::createToken(),
which binds keys and values, and is used by all URL generators. The
previous value-only format is still accepted for a bare object
selector without any processing or delivery option.

EXT:indexed_search no longer indexes the original file of a file dump
URL that carries a size or crop variant.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/54/97754/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/54/97754/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 5

Issues 1

Files 9

Review log 23

  1. Oli Bartsch uploaded patch set 1 11/17/26, 15:40

  2. core-ci voted on patch set 1 V +1 11/17/26, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114755

  3. Benjamin Franzke commented on patch set 1 11/18/26, 16:12

    FileDumpService.php:35 Unresolved

    I think we could simply sort by name. Or maybe even better: we could use a named JsonSerializable DTO with implied sorting (initialized via `new FileDumpParams(...$params)`)

    FileDumpService.php:65 Unresolved

    I don't think we need this backwards compatibility. We left it out for the backports in the sec release, yes, but since this patch is breaking, we can rely on the new format IMO.