97754[!!!][TASK] Bind parameter keys in file dump token
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/54/97754/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/54/97754/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 5
- main 94214[TASK] Remove TYPO3_REQUEST from ext:form
- main 95105[TASK] Apply PHP code simplifications
- main 96201[FEATURE] Introduce upload constraints for file uploads
- main 96116[WIP][BUGFIX] Preserve filename when replacing files
- main 90107[FEATURE] Introduce database-only storage for OnlineMedia files
Issues 1
Files 9
- typo3/sysext/core/Classes/Resource/Service/FileDumpService.php2+47 −6
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+3 −3
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-111472-FileDumpTokenBindsParameterKeys.rstnew+109 −0
- typo3/sysext/core/Tests/Functional/Controller/FileDumpControllerTest.php+78 −0
- typo3/sysext/core/Tests/Unit/Resource/Service/FileDumpServiceTest.phpnew+137 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Link/FileViewHelper.php+3 −4
- typo3/sysext/form/Classes/Slot/ResourcePublicationSlot.php+3 −4
- typo3/sysext/indexed_search/Classes/Indexer.php+5 −0
- typo3/sysext/indexed_search/Tests/Functional/NonPublicStorageIndexingTest.php+32 −0
Review log 23
-
Oli Bartsch uploaded patch set 1 11/17/26, 15:40
-
core-ci voted on patch set 1 V +1 11/17/26, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114755
-
Benjamin Franzke commented on patch set 1 11/18/26, 16:12
FileDumpService.php:65UnresolvedI don't think we need this backwards compatibility. We left it out for the backports in the sec release, yes, but since this patch is breaking, we can rely on the new format IMO.
FileDumpService.php:35Unresolved