Review main Ready for review

97838[BUGFIX] Respect doktype of page translations

Oli Bartsch CR 0 V 0 Normal +165 −22 updated 11/19/26, 11:04

Commit message

A page translation has its own doktype, and the overlaid record is
what the frontend renders. Doktype dependent decisions were still
based on the default language page though, while the translation was
handed on. A link page with a translation of another doktype thus
threw an exception in the frontend and in the Layout module.

The frontend now evaluates the doktype of the requested language for
the viewability check and for resolving links, shortcuts and mount
points, as routing, menus and link generation already do. A standard
page translation of a sysfolder or spacer is therefore rendered, and
a sysfolder translation of a standard page is no longer accessible.

The info boxes of the Layout module are now also based on the record
of the selected language.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/38/97838/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/38/97838/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 12

Issues 1

Files 5

Review log 46

  1. Oli Bartsch uploaded patch set 1 11/19/26, 10:00

  2. Benni Mack commented on patch set 1 11/19/26, 10:07

    PageInformationFactory.php:331

    can we leave this if() out, because then we have getPageOverlay() consistent with other places, thus, also allowing to deal with PSR-14 events etc.
  3. core-ci voted on patch set 1 V +1 11/19/26, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114994

  4. Oli Bartsch uploaded patch set 2 V +1 11/19/26, 10:57

  5. Oli Bartsch commented on patch set 2 11/19/26, 10:58

    PageInformationFactory.php:331 Reply

    Done. getPagesOverlay() returns the record untouched for the default language anyway, so the early return was redundant.
  6. core-ci voted on patch set 2 V +1 11/19/26, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115000