Review 14.3 Merged

97839[TASK] Make the install tool null-safe

Benjamin Kott CR +2 V +2 Normal +99 −93 updated 11/19/26, 11:02

Commit message

Fifth step towards strictNullChecks. Only backend and form are left
after this one.

The install tool renders its own markup and then reads it straight
back, so the bulk of its errors were lookups declared as if they always
succeed. Where the module owns the template the call now says so, and
where it does not the value is guarded. The same holds for the data
attributes it writes and reads, which yield undefined for a missing
one.

A few declarations were simply untrue and are corrected rather than
asserted. The action queue of the core updater declared a finish
message and a follow-up action on every entry although the first
entries deliberately have neither, so both are optional now. The
progress bar helper took a target it then reassigned, which read as if
the parameter mattered; it uses a local instead. The extension
compatibility tester appended an uninstall button that is undefined for
a protected extension, which rendered the literal text "undefined"
below its message.

`AbstractInteractableModule` states the assumption once for all
modules: the modal body, content and footer exist for as long as the
module is interactable, so the three getters keep their non-null return
type instead of pushing the question to every caller.

The non-null assertions this step relies on are added with
strictNullChecks itself, as no-unnecessary-type-assertion reports every
such assertion until the option is enabled.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 2

Files 39

Show 19 more files

Review log 57

  1. Benjamin Kott commented on patch set 1 11/19/26, 10:11

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/extension-compat-tester.js * typo3/sysext/install/Resources/Public/JavaScript/router.js
  2. Benjamin Kott uploaded patch set 2 11/19/26, 10:16

  3. Benjamin Kott commented on patch set 2 11/19/26, 10:21

    This change is ready for review.
  4. core-ci voted on patch set 2 V +1 11/19/26, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114998

  5. core-ci voted on patch set 1 V -1 11/19/26, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114995

  6. Benjamin Kott voted on patch set 2 CR +2 V +2 11/19/26, 11:02

  7. Benjamin Kott merged patch set 3 11/19/26, 11:02