97852[TASK] Show the form editor inspector as sheet on small screens
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/97852/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/97852/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Garvin Hicking +1
-
Verified V +1 Needs a vote
- Garvin Hicking +1
- core-ci +1 CI
Merge conflicts 10
- main 97611[BUGFIX] Reopen form editor inspector on selected element click
- main 97658[BUGFIX] Make form editor stage elements accessible
- main 93838[FEATURE] Translate forms in the backend
- main 96357[FEATURE] Attach static files to form emails
- main 95435[WIP][TASK] Enable strictNullChecks for the TypeScript build
- main 97615[TASK] Show page context in form editor inspector
- main 95093[FEATURE] Allow form elements on summary page
- main 94670[WIP][TASK] Untangle the backend Sass entrypoint and mark legacy styles
- main 93206[WIP][TASK] Use strict typing for EXT:form helper methods
- main 68199[WIP][TASK] Add <typo3-backend-module> element
Issues 1
Files 12
- Build/Sources/Sass/form.scss+127 −60
- Build/Sources/TypeScript/form/backend/form-editor/component/page-stage-item.ts+9 −3
- Build/Sources/TypeScript/form/backend/form-editor/mediator.ts+4 −2
- Build/Sources/TypeScript/form/backend/form-editor/stage-component.ts+3 −0
- Build/Sources/TypeScript/form/backend/form-editor/view-model.ts+192 −6
- typo3/sysext/form/Resources/Private/Language/locallang_form_editor_javascript.xlf+3 −0
- typo3/sysext/form/Resources/Private/Templates/Backend/FormEditor/Index.fluid.html+12 −14
- typo3/sysext/form/Resources/Public/Css/form.css+26 −16
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/component/page-stage-item.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/mediator.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/stage-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+1 −1
Review log 813
-
Josua Vogel uploaded patch set 1 11/19/26, 19:03
-
core-ci voted on patch set 1 V +1 11/19/26, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115035
-
Josua Vogel updated the commit message in patch set 2
V +111/20/26, 07:11 -
Josua Vogel commented on patch set 2 11/20/26, 07:11
This change is ready for review. -
Josua Vogel updated the commit message in patch set 3 11/20/26, 07:11
-
Josua Vogel updated the commit message in patch set 4 11/20/26, 07:14
-
core-ci voted on patch set 2 V +1 11/20/26, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115059
-
core-ci voted on patch set 4 V +1 11/20/26, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115061
-
core-ci voted on patch set 3 V +1 11/20/26, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115060
-
Garvin Hicking commented on patch set 4 V +1 11/20/26, 13:17
This generally works for me, one major resizing oddity that I've reported to Josua in a 1:1 -
Josua Vogel uploaded patch set 5
V +111/20/26, 13:21 -
core-ci voted on patch set 5 V +1 11/20/26, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115078
-
Garvin Hicking voted on patch set 5 CR +1 V +1 11/20/26, 13:40