Review main Ready for review

97852[TASK] Show the form editor inspector as sheet on small screens

Josua Vogel CR +1 V +1 Hard +380 −105 updated 11/20/26, 13:40

Commit message

On narrow screens the inspector was an absolutely positioned overlay
at the top of the module. Selecting an element further down lost the
scroll position, Escape did nothing, the collapsed panel stayed in
the tab order and a docked navigation squeezed the stage.

The inspector is now a dialog. Where the content frame is wide
enough it stays docked beside the stage. Otherwise it opens modal
with the sheet positioned modal of the backend, as contextual record
editing does: from the inline end, as bottom sheet in narrow windows.
It brings a header with the element title and a close button, closes
on Escape and backdrop click and returns the focus to the stage.

Selecting an element focuses the close button of the sheet instead
of a text field, tapping the selected element again reopens the
sheet, and steps get an "Edit step" button that replaces the
separate "Show inspector" button.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 5
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/97852/5 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/97852/5 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Garvin Hicking +1
  • Verified V +1 Needs a vote
    • Garvin Hicking +1
    • core-ci +1 CI

Merge conflicts 10

Issues 1

Files 12

Review log 813

  1. Josua Vogel uploaded patch set 1 11/19/26, 19:03

  2. core-ci voted on patch set 1 V +1 11/19/26, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115035

  3. Josua Vogel updated the commit message in patch set 2 V +1 11/20/26, 07:11

  4. Josua Vogel commented on patch set 2 11/20/26, 07:11

    This change is ready for review.
  5. Josua Vogel updated the commit message in patch set 3 11/20/26, 07:11

  6. Josua Vogel updated the commit message in patch set 4 11/20/26, 07:14

  7. core-ci voted on patch set 2 V +1 11/20/26, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115059

  8. core-ci voted on patch set 4 V +1 11/20/26, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115061

  9. core-ci voted on patch set 3 V +1 11/20/26, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115060

  10. Garvin Hicking commented on patch set 4 V +1 11/20/26, 13:17

    This generally works for me, one major resizing oddity that I've reported to Josua in a 1:1
  11. Josua Vogel uploaded patch set 5 V +1 11/20/26, 13:21

  12. core-ci voted on patch set 5 V +1 11/20/26, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115078

  13. Garvin Hicking voted on patch set 5 CR +1 V +1 11/20/26, 13:40