96357[FEATURE] Attach static files to form emails
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 7
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/57/96357/7 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/57/96357/7 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 25
- main 97852[TASK] Show the form editor inspector as sheet on small screens
- main 93838[FEATURE] Translate forms in the backend
- main 95436[WIP][TASK] Initialise class properties across the JavaScript stack
- main 95435[WIP][TASK] Enable strictNullChecks for the TypeScript build
- main 96626[FEATURE] Use foreign_table in form editor selects
- main 95027[!!!][FEATURE] Allow a mail profile per site
- main 97615[TASK] Show page context in form editor inspector
- main 94214[TASK] Remove TYPO3_REQUEST from ext:form
- main 97596[FEATURE] Add webhook finisher to the form framework
- main 91602[FEATURE] Modernize extbase plugin registration
- main 95093[FEATURE] Allow form elements on summary page
- main 94093[FEATURE] Use translation domains for form backend labels
- main 79445[BUGFIX] Fix file selector not adding the file if opened from an iframe
- main 96364[FEATURE] Allow disabling duplication of forms
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 93791[WIP][BUGFIX] Handle dot inside key of ext:form config
- main 93431[WIP][TASK] Use events in element browser IRRE handling
- main 94503[WIP][TASK] Save finishers in dedicated table
- main 94215[PoC] remove yamlSettingsOverrides / ExtbaseConfigurationManager in ext:form
- main 93558[POC][FEATURE] form <3 tca
- main 93398[WIP][!!!][FEATURE] Synchronise extension YAML form definitions into database
- main 93046[FEATURE] Introduce InspectorEditorRegistry for ext:form
- main 93206[WIP][TASK] Use strict typing for EXT:form helper methods
- main 90968[WIP][TASK] Replace lazy services with \Closure or ServiceLocators
- main 68199[WIP][TASK] Add <typo3-backend-module> element
Issues 2
Files 55
- Build/Sources/TypeScript/backend/element-browser.ts+3 −0
- Build/Sources/TypeScript/form/backend/form-editor/component/file-browser-editor.tsnew+212 −0
- Build/Sources/TypeScript/form/backend/form-editor/core.ts+2 −0
- Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts+83 −0
- Build/Sources/TypeScript/form/backend/form-editor/view-model.ts+4 −1
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-93914-AttachFilesSelectedInTheFileBrowserToEmails.rstnew+68 −0
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+3 −1
- typo3/sysext/form/Classes/Domain/Configuration/FlexformConfiguration/Processors/FinisherOptionGenerator.php+19 −1
- typo3/sysext/form/Classes/Domain/Configuration/FlexformConfiguration/Processors/ProcessorDto.php+7 −1
- typo3/sysext/form/Classes/Domain/Configuration/FlexformConfiguration/FileReferenceFieldName.phpnew+34 −0
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/FinisherOptionsFlexFormOverridesConverter.php+36 −0
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/FlexFormFinisherOverridesConverterDto.php+13 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/AbstractValidator.php+63 −0
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/CreatableFormElementPropertiesValidator.php+9 −0
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/CreatablePropertyCollectionElementPropertiesValidator.php+9 −0
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/FormElement/FilePropertiesExtractor.phpnew+55 −0
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/PropertyCollectionElement/FilePropertiesExtractor.phpnew+57 −0
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+60 −0
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/Prototype/FileBrowserEditorConfiguration.phpnew+97 −0
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+44 −0
Show 35 more files
- typo3/sysext/form/Classes/EventListener/DataStructureIdentifierListener.php+1 −0
- typo3/sysext/form/Classes/Service/FileResolver.phpnew+55 −0
- typo3/sysext/form/Classes/Service/FormEditorEnrichmentService.php+17 −19
- typo3/sysext/form/Configuration/Form/Base/Finishers/EmailToReceiver.yaml+5 −0
- typo3/sysext/form/Configuration/Form/Base/Finishers/EmailToSender.yaml+5 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Form.yaml+12 −0
- typo3/sysext/form/Configuration/Form/Base/config.yaml+1 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/EmailFinisher/Index.rst+34 −0
- typo3/sysext/form/Documentation/I/Config/proto/formEditor/Index.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formEditor/inspectorEditors/FileBrowserEditor.rstnew+171 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formEditor/Index.rst+1 −0
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FileBrowserEditor.fluid.htmlnew+14 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf+18 −0
- typo3/sysext/form/Resources/Private/Language/locallang_form_editor_javascript.xlf+21 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/component/file-browser-editor.jsnew+13 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/inspector-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+1 −1
- typo3/sysext/form/Tests/Functional/Controller/Fixtures/FlexFormFileOverride/Files/attachment.txtnew+1 −0
- typo3/sysext/form/Tests/Functional/Controller/Fixtures/FlexFormFileOverride/be_users.csvnew+4 −0
- typo3/sysext/form/Tests/Functional/Controller/Fixtures/FlexFormFileOverride/sys_file.csvnew+8 −0
- typo3/sysext/form/Tests/Functional/Controller/FormFrontendControllerFileOverrideTest.phpnew+166 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinition/Validators/Fixtures/FileAccess/Files/allowed.txtnew+1 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinition/Validators/Fixtures/FileAccess/Files/outside.txtnew+1 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinition/Validators/Fixtures/FileAccess/Files/secret.txtnew+1 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinition/Validators/Fixtures/FileAccess/be_groups.csvnew+3 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinition/Validators/Fixtures/FileAccess/be_users.csvnew+4 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinition/Validators/Fixtures/FileAccess/sys_file.csvnew+5 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinition/Validators/Fixtures/FileAccess/sys_filemounts.csvnew+3 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinition/Validators/FileBrowserEditorPropertyValidationTest.phpnew+262 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/ConfigurationServiceTest.php+71 −0
- typo3/sysext/form/Tests/Functional/Domain/Finishers/Fixtures/Attachments/Files/attachment.txtnew+1 −0
- typo3/sysext/form/Tests/Functional/Domain/Finishers/Fixtures/Attachments/Files/outside.txtnew+1 −0
- typo3/sysext/form/Tests/Functional/Domain/Finishers/Fixtures/Attachments/sys_file.csvnew+5 −0
- typo3/sysext/form/Tests/Functional/Domain/Finishers/EmailFinisherAttachmentsTest.phpnew+198 −0
- typo3/sysext/form/Tests/Unit/Service/FormEditorEnrichmentServiceTest.php+42 −0
Review log 1118
-
Josua Vogel uploaded patch set 1 10/05/26, 10:08
-
Josua Vogel marked it work in progress 10/05/26, 10:09
-
core-ci voted on patch set 1 V +1 10/05/26, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110097
-
Josua Vogel updated the commit message in patch set 2
V +110/05/26, 10:26 -
core-ci voted on patch set 2 V +1 10/05/26, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110101
-
Josua Vogel marked it ready for review 10/05/26, 12:54
-
Lina Wolf commented on patch set 2 10/15/26, 11:04
The form manual on main was re-indented in https://review.typo3.org/c/Packages/TYPO3.CMS/+/96702 (two spaces after "..", 4-space levels, headline levels). This change will probably conflict in typo3/sysext/form/Documentation when rebased. The script used for the conversion can help to bring new text into the same format; ask me if you need it. -
Josua Vogel uploaded patch set 3
V +110/15/26, 22:26 -
core-ci voted on patch set 3 V -1 10/15/26, 22:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111291
-
Josua Vogel uploaded patch set 4
V -111/06/26, 08:25 -
Josua Vogel commented on patch set 4 11/06/26, 08:28
Rebased onto main. Adapted to changes merged since PS3: removed the isFallbackStorage() check in FileResolver (fallback storage removed in #110361), dropped the sys_file_storage.csv fixtures (storages are configured in a file since #110762, the implicit default storage 1 is used), stubbed getPrototypeConfigurationDto() in FormFrontendControllerFileOverrideTest, and re-indented FileBrowserEditor.rst to the manual's new format. -
core-ci voted on patch set 4 V -1 11/06/26, 08:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113463
-
Josua Vogel rebased onto patch set 5
V -111/06/26, 08:51 -
core-ci voted on patch set 5 V +1 11/06/26, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113468
-
Josua Vogel uploaded patch set 6
V +111/15/26, 17:07 -
core-ci voted on patch set 6 V +1 11/15/26, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114553
-
Josua Vogel uploaded patch set 7
V +111/19/26, 16:29 -
core-ci voted on patch set 7 V +1 11/19/26, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115026