Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
67256[WIP][TASK] Enable TypeScript `strictNullChecks` option
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/56/67256/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/56/67256/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Relation chain 6
-
67256 [WIP][TASK] Enable TypeScript `strictNullChecks` option This change
-
main
88218[WIP][TASK] Enable TypeScript `strictBuiltinIteratorReturn` option
The chain has patch set 1 of 2, the changes above it need a rebase.
-
main
88217[WIP][TASK] Enable TypeScript `useUnknownInCatchVariables` option
The chain has patch set 1 of 2, the changes above it need a rebase.
-
main
88216[TASK] Enable most TypeScript strict-mode options
The chain has patch set 1 of 5, the changes above it need a rebase.
-
main
88215[TASK] Enable TypeScript `noUnusedLocals` option
The chain has patch set 1 of 5, the changes above it need a rebase.
-
main
88205[TASK] Enable TypeScript `noImplicitOverride` option
The chain has patch set 1 of 2, the changes above it need a rebase.
Issues 3
Files 24
- Build/Sources/TypeScript/adminpanel/modules/cache.ts+2 −2
- Build/Sources/TypeScript/adminpanel/modules/preview.ts+4 −4
- Build/Sources/TypeScript/adminpanel/admin-panel.ts+23 −16
- Build/Sources/TypeScript/backend/action-button/deferred-action.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/element/category-element.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/element/color-element.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/element/datetime-element.ts+6 −8
- Build/Sources/TypeScript/backend/form-engine/element/json-element.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/element/password-element.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/element/select-tree-element.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/element/slug-element.ts+3 −3
- Build/Sources/TypeScript/backend/form-engine/element/table-permission-element.ts+2 −2
- Build/Sources/TypeScript/backend/form-engine/field-control/password-generator.ts+2 −2
- Build/Sources/TypeScript/backend/form-engine/field-wizard/value-slider.ts+1 −1
- Build/Sources/TypeScript/backend/toolbar/clear-cache-menu.ts+3 −4
- Build/Sources/TypeScript/backend/multi-record-selection.ts+1 −1
- Build/Sources/TypeScript/core/document-service.ts+1 −1
- Build/Sources/TypeScript/dashboard/dashboard-delete.ts+11 −4
- Build/Sources/TypeScript/dashboard/grid.ts+1 −1
- Build/Sources/TypeScript/dashboard/widget-content-collector.ts+3 −3
Review log 1116
-
Benjamin Franzke uploaded patch set 1 12/28/20, 22:49
-
TYPO3com voted on patch set 1 V -1 12/28/20, 22:59 Completed build in 10m 10s on Mon, 28 Dec, 10:59 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8484
-
Benni Mack wrote 11/29/21, 10:03
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 2 11/29/21, 13:13
-
Benjamin Franzke uploaded patch set 3 11/30/23, 08:28
-
core-ci voted on patch set 3 V -1 11/30/23, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50151
-
Benjamin Franzke marked it ready for review 11/30/23, 08:47
-
Benjamin Franzke marked it work in progress 05/30/24, 07:15
-
Benjamin Franzke uploaded patch set 4
V -107/15/24, 13:15 -
core-ci voted on patch set 4 V -1 07/15/24, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61586
-
Benni Mack updated the commit message in patch set 5
V -110/18/24, 13:38 -
core-ci voted on patch set 5 V -1 10/18/24, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68010
-
Ayke Halder commented on patch set 5 10/24/24, 09:44
Maybe combine the fixing of TypeScript `strictNullChecks` with ESLint `@typescript-eslint/no-unnecessary-condition` rule. This will show code with implemented null-checks on objects declared as a type excluding `null`. -
Ayke Halder commented on patch set 5 10/24/24, 09:54
Reply
E.g. code like this in `Build/Sources/TypeScript/backend/form-engine.ts`: ``` const currentState = (el.querySelector('input[type="radio"]:checked') as HTMLInputElement)?.value; ``` Which should be one of these: ``` const currentState = (el.querySelector('input[type="radio"]:checked') as HTMLInputElement|null)?.value; Or this (identical with code above): const currentState = el.querySelector<HTMLInputElement>('input[type="radio"]:checked')?.value; ``` -
Benjamin Franzke uploaded patch set 6
V -102/14/25, 06:31 -
core-ci voted on patch set 6 V -1 02/14/25, 06:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74138