Review main Ready for review Quiet

95679[BUGFIX] Respect page visibility in rootline relations

Matthias Vogel CR -1 V +1 Normal +85 −14 updated 10/29/26, 09:25

Commit message

Rootline relation resolution currently uses includeHiddenContent for
both pages and content records. Hidden related pages are therefore
included in content-only previews and excluded in pages-only previews.

Respect includeHiddenPages and includeHiddenContent independently in
the local, foreign and combined reference index queries. Share the
hidden constraint and extend the lookup index with the related table.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/95679/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/95679/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Garvin Hicking +1
    • Stefan Bürk -1
  • Verified V +1 Needs a vote
    • Garvin Hicking +1
    • core-ci +1 CI

Relation chain 2

  1. main 94993[FEATURE] Add table-specific hidden record visibility Based on this change Abandoned Matthias Vogel CR 0 V -1 Hard +292 −80
  2. 95679 [BUGFIX] Respect page visibility in rootline relations This change

Merge conflicts 5

Issues 1

Files 4

Review log 911

  1. Matthias Vogel uploaded patch set 1 09/07/26, 10:02

  2. core-ci voted on patch set 1 V +1 09/07/26, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107998

  3. Matthias Vogel marked it ready for review 09/07/26, 10:11

  4. Matthias Vogel commented on patch set 1 CR -1 09/07/26, 10:21

    Important-110645-RespectPageVisibilityInRootlineRelations.rst:1

    todo: remove
  5. Matthias Vogel uploaded patch set 2 CR -1 V +1 09/07/26, 11:24

  6. Matthias Vogel commented on patch set 2 09/07/26, 11:24

    Important-110645-RespectPageVisibilityInRootlineRelations.rst:1 Reply

    Done
  7. core-ci voted on patch set 2 V +1 09/07/26, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108002

  8. Stefan Bürk commented on patch set 2 CR -1 09/07/26, 13:09

    -1 need to review this in detail ...
  9. Matthias Vogel commented on patch set 2 09/07/26, 14:09

    should we backport to 14 or 13?
  10. Garvin Hicking commented on patch set 2 CR +1 V +1 10/19/26, 12:54

    Reply Unresolved

    I've looked this through with Matthias today and we did some intensive benchmarking. The "or" combination of course does have some performance penality, when the "bug"-case (true/false, false/true) comes into place. The numbers are in the forge issue, but I'd argue they are neglectible in the scope of miliseconds used even in larger setups given that we fix a bug with it. We also inspected whether modifying the index is necessary (we'd argue, yes) or if an additional index would help (little, and the extra costs in writing negates that by far). So I think we should merge this. I would go for main only and no backport, because: 1.) The scenario IMO feels edge-casey to me and I am unsure when this bug hits in production environments, also given we don't have a specific bugreport for it yet. 2.) It will force a sys_refindex DB table updated when running DB compare, which can take some time and in patchlevel releases people may not expect this 3.) Due to the possible impact on performance I'd rather try it out in a release-cycle rather than a patch-cycle. I'd like to wait for Stefans feedback before merging.

    Reply

    (for me: no backport)
  11. Matthias Vogel commented on patch set 2 10/29/26, 09:25

    Reply

    Acknowledged