96298[FEATURE] Allow expanding and collapsing all selectCheckBox groups
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/98/96298/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/98/96298/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- Oli Bartsch -1
- core-ci +1 CI
Merge conflicts 13
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 84995[FEATURE] Allow assigning users to groups in group editor
- main 94753[FEATURE] New TCA type "coordinate"
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 87873[WIP][BUGFIX] Make Dropdown Toggle Buttons more accessible
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 91423[WIP][TASK] Move config values to both section columns and config
- main 92851[WIP][FEATURE] Allow simplified TCA configuration (Test II)
- main 92180[!!!][TASK] Decouple registration of FormEngine nodes from NodeFactory
- main 91404[!!!][TASK] Remove re-login password popup functionality
- main 83208[WIP][FEATURE] Introduce Creation Wizards
- main 76792[WIP][TASK] Move view switch in page module
- main 78198[WIP][TASK] Introduce resource move in filelist
Issues 1
Files 7
- Build/Sources/TypeScript/backend/form-engine/element/select-check-box-element.tsnew+40 −0
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php1+20 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-check-box-element.jsnew+13 −0
- typo3/sysext/core/Configuration/TCA/be_groups.php+3 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-106823-ExpandAndCollapseAllGroupsOfSelectCheckBox.rstnew+49 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_select.php+2 −1
Review log 45
-
Georg Ringer uploaded patch set 1 10/02/26, 07:30
-
Georg Ringer commented on patch set 1 10/02/26, 07:30
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/02/26, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109882
-
Simon Schaufelberger commented on patch set 1 10/12/26, 19:29
SelectCheckBoxElement.php:306Unresolvedbenni is trying to use `trans()` throughout the core now. -
Oli Bartsch commented on patch set 1 V -1 10/20/26, 11:33
Unresolved
I did not check code yet but just did a quick visual test. I don't think the placement is appropriated as it leads to a nearly empty line between the label (or description) and the selects. This looks kind of broken. Additionally, The button bahviour is IMO "inappropriate". In case all groups are already collapsed or expanded the corresponding buttons are still clickable but do not have any effect (obviously). Maybe we also need a more general concept of placing such functionality in this area.