Review main Ready for review Quiet

96298[FEATURE] Allow expanding and collapsing all selectCheckBox groups

Georg Ringer CR 0 V -1 Normal +130 −1 updated 10/20/26, 11:33

Commit message

Fields of renderType "selectCheckBox" show their items in
collapsible groups. With many groups, like the "Allowed
excludefields" of backend user groups, opening or closing each
group by hand is tedious.

The new TCA option "appearance.showExpandCollapseAll" renders
buttons to expand or collapse all groups of the field at once.
It is enabled for the excludefields of backend user groups.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/98/96298/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/98/96298/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • Oli Bartsch -1
    • core-ci +1 CI

Merge conflicts 13

Issues 1

Files 7

Review log 45

  1. Georg Ringer uploaded patch set 1 10/02/26, 07:30

  2. Georg Ringer commented on patch set 1 10/02/26, 07:30

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/02/26, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109882

  4. Simon Schaufelberger commented on patch set 1 10/12/26, 19:29

    SelectCheckBoxElement.php:306 Unresolved

    benni is trying to use `trans()` throughout the core now.
  5. Oli Bartsch commented on patch set 1 V -1 10/20/26, 11:33

    Unresolved

    I did not check code yet but just did a quick visual test. I don't think the placement is appropriated as it leads to a nearly empty line between the label (or description) and the selects. This looks kind of broken. Additionally, The button bahviour is IMO "inappropriate". In case all groups are already collapsed or expanded the corresponding buttons are still clickable but do not have any effect (obviously). Maybe we also need a more general concept of placing such functionality in this area.