Review main Work in progress Quiet

96741[FEATURE] Add preview images for videos

Benni Mack CR 0 V -1 Expert +1000 −15 updated 10/23/26, 12:44

Commit message

The metadata of video files gets the field "preview_image", a file
reference to an image, which applies to all languages. It is
rendered as poster of the video tag of local videos, and it is used
for the previews of online media instead of fetching the image from
the platform of the video while rendering.

When an online media video is added in the backend, its image is
fetched once, stored next to the video and set as preview image.
"Update" in the file list fetches it again, without changing an
image chosen by an editor. The new PreviewImageRepository reads and
sets the preview image, incl. the reference index entries.

An upgrade wizard sets the preview image of existing online media
from the images fetched to typo3temp/assets/online_media/ before,
without fetching any image. Online media without preview image keep
fetching it as before.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/41/96741/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/41/96741/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 14

Issues 1

Files 23

Show 3 more files

Review log 45

  1. Benni Mack uploaded patch set 1 10/15/26, 21:36

  2. core-ci voted on patch set 1 V -1 10/15/26, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111283

  3. Markus Klein commented on patch set 1 10/17/26, 06:13

    PreviewImageRepository.php:68

    This is not a helpful error message. It does not help with finding the root cause.
  4. Markus Klein commented on patch set 1 10/17/26, 06:15

    PreviewService.php:103 Unresolved

    What if a video is on a read-only remote storage? We can't store the preview there then.
  5. Markus Klein commented on patch set 1 10/17/26, 06:16

    PreviewImageRepository.php:68 Reply

    forget it, this is for online media only, we have the ref-file locally