Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
96869[TASK] Make file references sortable by keyboard
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/69/96869/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/69/96869/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Benni Mack -1
-
Verified V 0 Needs a vote
Relation chain 7
- main 96997[BUGFIX] Update new content link after element move
-
main
96992[BUGFIX] Keep selection after page tree filter reset
The chain has patch set 3 of 6, the changes above it need a rebase.
- main 96988[BUGFIX] Add color-scheme meta tag to backend head
- main 96945[BUGFIX] Respect timed pages in menu cache lifetime
-
main
96926[BUGFIX] Restore tree focus after page creation
The chain has patch set 2 of 4, the changes above it need a rebase.
-
main
96884[BUGFIX] Announce remaining characters for screen readers
The chain has patch set 4 of 5, the changes above it need a rebase.
-
96869 [TASK] Make file references sortable by keyboard This change
Issues 1
Files 7
- Build/Sources/Sass/typo3/_element_tceforms.scss+16 −0
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+64 −20
- Build/tests/playwright/e2e/form-engine/file.spec.ts+90 −0
- typo3/sysext/backend/Classes/Form/Container/FileReferenceContainer.php+1 −1
- typo3/sysext/backend/Resources/Private/Language/locallang_alt_doc.xlf+3 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
Review log 1419
-
Markus Timtner uploaded patch set 1 10/19/26, 15:23
-
core-ci voted on patch set 1 V -1 10/19/26, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111667
-
Markus Timtner uploaded patch set 2
V -110/19/26, 17:37 -
Georg Ringer commented on patch set 2 10/19/26, 17:40
if it is a task, then no feature rst needed. if it is a feature, then use [FEATURE] and no backport to 14.3 possible. both are fine for me -
core-ci voted on patch set 2 V +1 10/19/26, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111684
-
Christian Rath-Ulrich voted on patch set 2 V +1 10/19/26, 18:03
-
Matthias Vogel commented on patch set 2 10/19/26, 19:14
Keyboard sorting misbehaves after deleting a saved reference or reordering a containing inline record. Compiled-code probes with DOM stubs reproduced both issues; the focused Playwright run was blocked by Docker socket permissions. Full review comments: - [P2] Exclude deletion inputs from keyboard sorting positions — /home/user/www/project/typo3-main/Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts:353-355 After deleting an existing reference without saving, deleteRecord() leaves its hidden delete-command input inside recordsContainer. changeSortingByButton() counts every child, so the first remaining reference has position 1 rather than 0. Unlike the disabled up button, the new shortcut allows moving this reference upward, which instead appends it to the end and announces a total including the deleted reference. Calculate keyboard sorting positions from actual reference panels only. - [P2] Make keyboard sorting registration idempotent — /home/user/www/project/typo3-main/Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts:259-260 For a file field nested in a sortable inline record, moving the parent reconnects the nested custom element and runs registerEvents() again. Each call adds another keyboard listener through delegateTo(), without removing the previous listener or stopping immediate propagation. With three or more references, one Alt+ArrowDown then moves the reference two positions; subsequent parent moves multiply the effect. Live regions are duplicated too. Initialize the new listener and region only once, or clean them up on disconnect. -
Markus Timtner uploaded patch set 3
V +110/19/26, 19:16 -
core-ci voted on patch set 3 V +1 10/19/26, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111701
-
Markus Klein commented on patch set 3 10/20/26, 12:26
Improvements: 1.) do not show move-icon at all, if there is only 1 item 2.) if I have 2 items and delete 1 item, and then use the keyboard to move the item, the border of the item switches one corner from round to angled -
Markus Timtner commented on patch set 3 10/20/26, 13:03
Reply
Acknowledged, working on it -
Markus Timtner uploaded patch set 4
V +110/20/26, 14:55 -
core-ci voted on patch set 4 V +1 10/20/26, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111857
-
Markus Timtner rebased onto patch set 5
V +110/22/26, 10:28 -
core-ci voted on patch set 5 V +1 10/22/26, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112085
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 11/03/26, 21:16
-
Markus Klein voted on patch set 5 CR +1 V +1 11/04/26, 11:39
-
Georg Ringer uploaded patch set 6
CR +1V +111/13/26, 16:09 -
Benni Mack commented on patch set 6 CR -1 11/13/26, 17:21
Unresolved
1. Why only for type === 'file'? Plain inline records have the same .sortableHandle, and keyboard sorting would help there too, especially when the sort buttons are disabled. I'd drop the restriction. 2. registerSortByKeyboard(): recordContainer can be null in theory, so please guard it before calling .closest(). 3. Hiding the handle for a single reference is a separate visual change, and the :has()/nth-child(… of …) selector is quite heavy. Could that go into its own patch?