Review main Ready for review Quiet

96988[BUGFIX] Add color-scheme meta tag to backend head

Markus Timtner CR 0 V 0 Normal +62 −7 updated 10/26/26, 07:42

Commit message

Until now, the browser learns the backend color scheme only from the external
backend.css and paints the default white canvas until the stylesheet is
parsed, visible as a white flash in dark mode.

Now, we register a meta color-scheme tag for backend requests: the effective
scheme for logged in users, 'light dark' for scheme auto and the login
screen.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 5
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/88/96988/5 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/88/96988/5 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 6

  1. main 96997[BUGFIX] Update new content link after element move Based on this change Markus Timtner CR 0 V 0 → 14.3 Normal +69 −1
  2. main 96992[BUGFIX] Keep selection after page tree filter reset Based on this change Merged Markus Timtner CR +2 V +2 → 14.3 Hard +241 −21

    The chain has patch set 3 of 6, the changes above it need a rebase.

  3. 96988 [BUGFIX] Add color-scheme meta tag to backend head This change

  4. main 96945[BUGFIX] Respect timed pages in menu cache lifetime This change is based on it Merge conflict Markus Timtner CR 0 V 0 → 14.3 Hard +290 −0
  5. main 96926[BUGFIX] Restore tree focus after page creation This change is based on it Markus Timtner CR +1 V +1 → 14.3 Normal +131 −2

    The chain has patch set 2 of 4, the changes above it need a rebase.

  6. main 96869[TASK] Make file references sortable by keyboard This change is based on it Merge conflict Markus Timtner CR -1 V 0 → 14.3 Normal +178 −22

    The chain has patch set 5 of 6, the changes above it need a rebase.

Merge conflicts 6

Issues 1

Files 2

Review log 916

  1. Markus Timtner uploaded patch set 1 10/22/26, 07:23

  2. core-ci voted on patch set 1 V +1 10/22/26, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112068

  3. Markus Timtner updated the commit message in patch set 2 V +1 10/22/26, 07:51

  4. core-ci voted on patch set 2 V -1 10/22/26, 08:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112071

  5. core-ci commented on patch set 2 10/22/26, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112071

  6. core-ci voted on patch set 2 V +1 10/22/26, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112071

  7. Oli Bartsch uploaded patch set 3 V +1 10/22/26, 08:29

  8. Oli Bartsch voted on patch set 3 CR +1 V +1 10/22/26, 08:40

  9. Oli Bartsch rebased onto patch set 4 CR +1 V +1 10/22/26, 08:41

  10. Oli Bartsch voted on patch set 4 CR +1 V +1 10/22/26, 08:42

  11. core-ci voted on patch set 3 V +1 10/22/26, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112074

  12. core-ci voted on patch set 4 V +1 10/22/26, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112076

  13. Markus Timtner uploaded patch set 5 CR +1 V +1 10/22/26, 10:28

  14. core-ci voted on patch set 5 V +1 10/22/26, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112088

  15. Markus Klein commented on patch set 5 10/24/26, 18:09

    PageRenderer.php:1087

    I think it's not necessary to call this again. We get this information already from $attributes. If it has 'data-color-scheme' the $colorScheme was not "auto".
  16. Markus Timtner commented on patch set 5 10/26/26, 07:42

    PageRenderer.php:1087 Reply Unresolved

    Ah, I see, will test and streamline that if possible.