Review main Ready for review

96926[BUGFIX] Restore tree focus after page creation

Markus Timtner CR +1 V +1 Normal +131 −2 updated 11/15/26, 01:00

Commit message

Creating a page through the page wizard left the keyboard focus on the
document body and the page tree without a tab stop. One Tab press after
the wizard finished moved to the sidebar toggle, and the tree could not
be reached from the toolbar anymore.

The page tree now resolves its focused nodes again after the nodes have
been reloaded. The reload replaced the node objects, so no tree item
was left with tabindex="0".

The modal remembers the element that had the focus when it opened and
hands the focus back when it closes, in case the browser dropped it.

Dropping a new page icon on the tree focuses the drop target first, so
the modal has an element to return the focus to.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/96926/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/96926/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • Christian Rath-Ulrich +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Relation chain 5

  1. main 96997[BUGFIX] Update new content link after element move Based on this change Markus Timtner CR 0 V 0 → 14.3 Normal +69 −1
  2. main 96992[BUGFIX] Keep selection after page tree filter reset Based on this change Merged Markus Timtner CR +2 V +2 → 14.3 Hard +241 −21

    The chain has patch set 3 of 6, the changes above it need a rebase.

  3. main 96988[BUGFIX] Add color-scheme meta tag to backend head Based on this change Markus Timtner CR 0 V 0 → 14.3 Normal +62 −7
  4. main 96945[BUGFIX] Respect timed pages in menu cache lifetime Based on this change Merge conflict Markus Timtner CR 0 V 0 → 14.3 Hard +290 −0
  5. 96926 [BUGFIX] Restore tree focus after page creation This change

Merge conflicts 13

Issues 1

Files 5

Review log 914

  1. Markus Timtner uploaded patch set 1 10/20/26, 14:55

  2. core-ci voted on patch set 1 V -1 10/20/26, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111859

  3. Christian Rath-Ulrich voted on patch set 1 V +1 10/20/26, 16:28

  4. core-ci voted on patch set 1 V +1 10/20/26, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111859

  5. Markus Timtner rebased onto patch set 2 V +1 10/22/26, 10:28

  6. core-ci voted on patch set 2 V +1 10/22/26, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112086

  7. Christian Rath-Ulrich uploaded patch set 3 V +1 10/26/26, 08:19

  8. Christian Rath-Ulrich voted on patch set 3 V +1 10/26/26, 08:20

  9. core-ci voted on patch set 3 V +1 10/26/26, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112578

  10. Christian Rath-Ulrich uploaded patch set 4 V +1 11/12/26, 16:50

  11. Christian Rath-Ulrich voted on patch set 4 V +1 11/12/26, 16:52

  12. core-ci voted on patch set 4 V +1 11/12/26, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114203

  13. Josua Vogel voted on patch set 4 CR +1 V +1 11/12/26, 18:59

  14. Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/15/26, 01:00