86437[TASK] Throw custom exception database value decoding
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/86437/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/86437/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 10
- main 97323[TASK] Check page access along the cached page ancestry
- main 97603[TASK] Introduce RecordTypeResolver and deprecate getTCAtypeValue()
- main 96525[!!!][TASK] Unify record title resolution
- main 94753[FEATURE] New TCA type "coordinate"
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 74781[FEATURE] Introduce new slug builders for records and string
- main 92589[TASK] Replace unneeded instanceof on xxx|null. Use a null check instead
- main 91189[WIP] Module Menu
- main 91715[WIP] Add configurable accent/tint color
- main 81871[TASK] Cache results in BackendUtility::getRecordTitle
Issues 3
Files 3
Review log 1422
-
Stefan Bürk uploaded patch set 1 10/05/24, 21:55
-
Stefan Bürk rebased onto patch set 2 10/05/24, 22:05
-
core-ci voted on patch set 1 V -1 10/05/24, 22:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67165
-
core-ci voted on patch set 2 V +1 10/05/24, 22:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67166
-
Stefan Bürk updated the commit message in patch set 3
V +110/07/24, 07:58 -
core-ci voted on patch set 3 V +1 10/07/24, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67207
-
Benjamin Franzke commented on patch set 3 CR -1 10/07/24, 08:29
BackendUtility.php:3112Why do you convert the default value in line 3107 and then set it again here (without conversion)? Looks like a left-over -
Stefan Bürk voted on patch set 3 CR -2 10/07/24, 18:03
-
Stefan Bürk uploaded patch set 4
CR -1V +110/10/24, 17:18Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Stefan Bürk commented on patch set 3 CR 0 10/10/24, 17:18
Copied votes on follow-up patch sets have been updated: * Copied Code-Review vote has been removed from patch set 4 (was Code-Review-2) since the new Code-Review=0 vote is not copyable (copy condition: "changekind:NO_CHANGE OR is:MIN").BackendUtility.php:3102ReplyThan we could just leave the doctrine exception which has that information in the exception message - otherwise we could simply duplicate the same exception along to have a TYPO3 exception code in it. Will add a duplicate for now. -
Stefan Bürk updated the commit message in patch set 5 10/10/24, 17:19
-
core-ci voted on patch set 5 V +1 10/10/24, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67522
-
core-ci voted on patch set 4 V +1 10/10/24, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67521
-
Stefan Bürk commented on patch set 5 10/11/24, 13:14
BackendUtility.php:3102Reply UnresolvedRethrow now a TYPO3 exception to have a code integer at place for documention things. Not sure if that is really a good way. Logging it needs to return something, and could also be breaking than. Not sure if this is now the correct way, but feels to be the less worse option here for now. Change made as to-be discussed.BackendUtility.php:3112ReplyRemoved it. -
Oliver Hader updated the commit message in patch set 6
V +110/18/24, 13:58 -
Benni Mack updated the commit message in patch set 7 04/22/26, 06:24
-
core-ci voted on patch set 7 V -1 04/22/26, 06:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100687
-
Oliver Klee voted on patch set 7 CR +1 04/22/26, 07:42
-
Stefan Bürk uploaded patch set 8
CR +1V -108/15/26, 20:21 -
core-ci voted on patch set 8 V +1 08/15/26, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106766
-
Stefan Bürk uploaded patch set 9
V +108/15/26, 23:17 -
core-ci voted on patch set 9 V +1 08/15/26, 23:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106767
BackendUtility.php:3102