Review main Ready for review Quiet

90874[FEATURE] Offer suggestions for link fields in the link browser

Benjamin Kott CR 0 V 0 Expert +1863 −75 updated 10/23/26, 12:56

Commit message

The value picker of TCA type=link rendered a select box next to the
field. It was copied from type=input when the link element was split
off and never got an own design. The select box is not accessible,
duplicates what the link browser is for and only worked with the
documented item syntax since v14.

Link fields now configure "suggestions", which the link browser offers
in a tab of their own, with an icon for the link type. A suggestion is
a preset for the tab of its link type: selecting it opens that tab with
the link, its attributes and the label as title filled in, where it is
set as usual. A current link that is one of the suggestions opens the
suggestions tab and is marked there.

FormEngine forwards the suggestions of the processed field
configuration signed with an HMAC, so the link browser only shows what
the field really defines. It leaves out a suggestion it cannot open,
because the field does not allow its link type or it cannot be
resolved.

The new PSR-14 event ModifyLinkSuggestionsEvent lets extensions add,
replace or remove suggestions depending on the edited record. The
styleguide uses it to suggest the page a demo record lives on.

The "valuePicker" of type=link is migrated to "suggestions" and
deprecated. A field that disables the link browser still offers its
suggestions: its link browser shows them only, and selecting one sets
it directly. The value picker of the other types is not affected.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 16
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/90874/16 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/90874/16 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 2

  1. main 90694[FEATURE] Implement accessible combobox pattern Based on this change Merged Benjamin Kott CR +2 V +2 Expert +1390 −138

    The chain has patch set 18 of 38, the changes above it need a rebase.

  2. 90874 [FEATURE] Offer suggestions for link fields in the link browser This change

Merge conflicts 12

Issues 2

Files 24

Show 4 more files

Review log 3046

Show 1521 earlier messages
  1. Benjamin Kott uploaded patch set 1 10/02/25, 09:41

  2. core-ci voted on patch set 1 V -1 10/02/25, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85893

  3. Georg Ringer commented on patch set 1 CR -1 10/02/25, 10:09

    don't do that, really don't - I activly use those, at least in number/text and also used in core, e.g. in site > error handling > error status code
  4. Georg Ringer commented on patch set 1 10/02/25, 10:11

    if something new will come, please provide that first and once that is merged,let's discuss an upgrade. really no need to make something first bad and fix later
  5. Benjamin Kott uploaded patch set 2 CR -1 V -1 10/02/25, 10:13

  6. Benjamin Kott commented on patch set 2 10/02/25, 10:17

    Reply

    it will stay for normal input fields but needs to go for number and text, as it contradicts with a11y patterns necessary in that area. it´s textarea in this case here. combobox requires to be selectable via up and down arrows.

    Reply

    please see relation chain, the patch is already here, still needs some cleanup - currently extracting chunks into smaller parts to get the main replacement patch ready.
  7. Benjamin Kott commented on patch set 2 10/02/25, 10:20

    Reply

    i missed the status code, will see to find a solution for this. but it cannot stay as is.
  8. core-ci voted on patch set 2 V +1 10/02/25, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85897

  9. Georg Ringer commented on patch set 2 CR -1 10/02/25, 10:48

    also used for text, like in route example for robots.txt.please don't just remove really used stuff
  10. Benjamin Kott uploaded patch set 3 CR -1 V +1 10/02/25, 12:16

  11. Benjamin Kott commented on patch set 3 10/02/25, 12:20

    I talked to Benjamin Franzke about this. We decided to also move the number element to the new component and drop the up and down arrow functionality of the native element in favor of the ValuePicker if defined. For the TextArea we will provide a different solution.
  12. core-ci voted on patch set 3 V +1 10/02/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85916

  13. Chris Müller commented on patch set 3 10/02/25, 15:46

    Breaking-107591-DropValuePickerFromColorLinkNumberAndTextInputTypes.rst:20

    ```suggestion For the link the value picker does not provide any benefits as it´s ```
  14. Georg Ringer uploaded patch set 4 V +1 10/02/25, 19:16

  15. core-ci voted on patch set 4 V -1 10/02/25, 19:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85934

  16. Georg Ringer uploaded patch set 5 V -1 10/02/25, 20:18

  17. core-ci voted on patch set 5 V +1 10/02/25, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85935

  18. Georg Ringer voted on patch set 5 CR +1 V +1 10/03/25, 05:44

  19. Benjamin Kott updated the commit message in patch set 6 CR +1 V +1 10/06/25, 06:47

  20. Benjamin Kott commented on patch set 6 10/06/25, 06:47

    Breaking-107591-DropValuePickerFromColorLinkNumberAndTextInputTypes.rst:20 Reply

    Done
  21. core-ci voted on patch set 6 V -1 10/06/25, 06:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86056

  1. Benjamin Kott uploaded patch set 7 V -1 10/06/25, 06:57

  2. Benjamin Kott updated the commit message in patch set 8 10/06/25, 06:58

  3. Benjamin Kott uploaded patch set 9 10/06/25, 07:01

  4. core-ci voted on patch set 7 V +1 10/06/25, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86057

  5. Benjamin Franzke commented on patch set 9 CR -1 10/06/25, 07:19

    ColorElement.php:138

    benji and me agreed to migrate this to color palettes instead of dropping. That means we need to make it possible to define color palettes via TCA instead of only via PageTSconfig. ⇒`-1`
  6. core-ci voted on patch set 8 V +1 10/06/25, 07:26 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 9 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86060

  7. core-ci voted on patch set 9 V +1 10/06/25, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86061

  8. Benjamin Franzke commented on patch set 9 10/07/25, 09:32

    ColorElement.php:138 Reply

    WIP patch is here: > 90936: [WIP][TASK] Show labels in color picker and merge value picker | https://review.typo3.org/c/Packages/TYPO3.CMS/+/90936
  9. Simon Schaufelberger commented on patch set 9 11/07/25, 18:24

    ColorElement.php:138 Reply

    what about this patch? Is still still relevant?
  10. Benjamin Kott uploaded patch set 10 CR -1 V +1 10/08/26, 13:03

  11. Benjamin Kott commented on patch set 10 10/08/26, 13:05

    This change is ready for review.

    ColorElement.php:138 Reply

    reworked, dropped link value picker, moved to a suggestion inside the wizard
  12. core-ci voted on patch set 10 V -1 10/08/26, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110494

  13. Benjamin Kott uploaded patch set 11 V -1 10/08/26, 15:36

  14. core-ci voted on patch set 11 V +1 10/08/26, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110515

  15. Benjamin Kott uploaded patch set 12 V +1 10/15/26, 10:02

  16. core-ci voted on patch set 12 V +1 10/15/26, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111175

  17. Benjamin Kott uploaded patch set 13 V +1 10/15/26, 10:28

  18. core-ci voted on patch set 13 V +1 10/15/26, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111179

  19. Benjamin Kott uploaded patch set 14 V +1 10/15/26, 11:12

  20. core-ci voted on patch set 14 V +1 10/15/26, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111182

  21. Guido Schmechel commented on patch set 14 CR +1 V +1 10/16/26, 09:35

    It worked well under my test conditions. However, please double-check the keyboard navigation one last time after selecting a suggestion. After selecting an external link and pressing the Tab key, “Page” was back in focus even though “External URL” was highlighted in blue. Since I'm no a11y expert here, just take this as a friendly reminder :-)
  22. Benjamin Kott uploaded patch set 15 CR +1 V +1 10/23/26, 09:47

  23. core-ci voted on patch set 15 V -1 10/23/26, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112260

  24. Benjamin Kott rebased onto patch set 16 V -1 10/23/26, 12:44

  25. core-ci voted on patch set 16 V +1 10/23/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112300