90874[FEATURE] Offer suggestions for link fields in the link browser
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 16
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/90874/16 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/90874/16 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 2
-
main
90694[FEATURE] Implement accessible combobox pattern
The chain has patch set 18 of 38, the changes above it need a rebase.
-
90874 [FEATURE] Offer suggestions for link fields in the link browser This change
Merge conflicts 12
- main 96745[BUGFIX] DataHandler: Streamline `null` handling
- main 95431[TASK] Make most of the backend TypeScript null-safe
- main 95435[WIP][TASK] Enable strictNullChecks for the TypeScript build
- main 94753[FEATURE] New TCA type "coordinate"
- main 95105[TASK] Apply PHP code simplifications
- main 96765[WIP][TASK] Use HTML form element based selector in Typescript
- main 96127[BUGFIX] Use effective pid in link browser
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 95343[FEATURE] Add `adminOnly` for TCA columns
- main 91423[WIP][TASK] Move config values to both section columns and config
- main 92851[WIP][FEATURE] Allow simplified TCA configuration (Test II)
- main 92180[!!!][TASK] Decouple registration of FormEngine nodes from NodeFactory
Issues 2
Files 24
- Build/Sources/TypeScript/backend/form-engine-link-browser-adapter.ts+5 −4
- Build/Sources/TypeScript/backend/link-browser.ts+2 −1
- Build/Sources/TypeScript/backend/suggestions-link-handler.tsnew+31 −0
- Build/tests/playwright/e2e/form-engine/link-browser.spec.ts+150 −0
- typo3/sysext/backend/Classes/Controller/Event/ModifyLinkSuggestionsEvent.phpnew+80 −0
- typo3/sysext/backend/Classes/Controller/LinkBrowserController.php+165 −0
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php+11 −31
- typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php+32 −0
- typo3/sysext/backend/Classes/LinkHandler/SuggestionsLinkHandler.phpnew+184 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_browse_links.xlf+6 −0
- typo3/sysext/backend/Resources/Private/Layouts/LinkBrowser.fluid.html+20 −16
- typo3/sysext/backend/Resources/Private/Templates/LinkBrowser/Suggestions.fluid.htmlnew+58 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-link-browser-adapter.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/link-browser.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/suggestions-link-handler.jsnew+13 −0
- typo3/sysext/backend/Tests/Unit/Controller/LinkBrowserControllerTest.phpnew+352 −0
- typo3/sysext/backend/Tests/Unit/Form/FieldControl/LinkPopupTest.phpnew+134 −0
- typo3/sysext/backend/Tests/Unit/LinkHandler/SuggestionsLinkHandlerTest.phpnew+150 −0
- typo3/sysext/core/Classes/Configuration/Tca/TcaMigration.php+37 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Deprecation-111076-ValuePickerOfLinkTypeMovedToSuggestions.rstnew+76 −0
Show 4 more files
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-111076-SuggestionsForLinkFieldsInLinkBrowser.rstnew+104 −0
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaMigrationTest.php+170 −0
- typo3/sysext/styleguide/Classes/EventListener/AddPageLinkSuggestion.phpnew+42 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php+39 −21
Review log 3046
Show 1521 earlier messages
-
Benjamin Kott uploaded patch set 1 10/02/25, 09:41
-
core-ci voted on patch set 1 V -1 10/02/25, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85893
-
Georg Ringer commented on patch set 1 CR -1 10/02/25, 10:09
don't do that, really don't - I activly use those, at least in number/text and also used in core, e.g. in site > error handling > error status code -
Georg Ringer commented on patch set 1 10/02/25, 10:11
if something new will come, please provide that first and once that is merged,let's discuss an upgrade. really no need to make something first bad and fix later -
Benjamin Kott uploaded patch set 2
CR -1V -110/02/25, 10:13 -
Benjamin Kott commented on patch set 2 10/02/25, 10:17
Reply
it will stay for normal input fields but needs to go for number and text, as it contradicts with a11y patterns necessary in that area. it´s textarea in this case here. combobox requires to be selectable via up and down arrows.Reply
please see relation chain, the patch is already here, still needs some cleanup - currently extracting chunks into smaller parts to get the main replacement patch ready. -
Benjamin Kott commented on patch set 2 10/02/25, 10:20
Reply
i missed the status code, will see to find a solution for this. but it cannot stay as is. -
core-ci voted on patch set 2 V +1 10/02/25, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85897
-
Georg Ringer commented on patch set 2 CR -1 10/02/25, 10:48
also used for text, like in route example for robots.txt.please don't just remove really used stuff -
Benjamin Kott uploaded patch set 3
CR -1V +110/02/25, 12:16 -
Benjamin Kott commented on patch set 3 10/02/25, 12:20
I talked to Benjamin Franzke about this. We decided to also move the number element to the new component and drop the up and down arrow functionality of the native element in favor of the ValuePicker if defined. For the TextArea we will provide a different solution. -
core-ci voted on patch set 3 V +1 10/02/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85916
-
Chris Müller commented on patch set 3 10/02/25, 15:46
Breaking-107591-DropValuePickerFromColorLinkNumberAndTextInputTypes.rst:20```suggestion For the link the value picker does not provide any benefits as it´s ``` -
Georg Ringer uploaded patch set 4
V +110/02/25, 19:16 -
core-ci voted on patch set 4 V -1 10/02/25, 19:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85934
-
Georg Ringer uploaded patch set 5
V -110/02/25, 20:18 -
core-ci voted on patch set 5 V +1 10/02/25, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85935
-
Georg Ringer voted on patch set 5 CR +1 V +1 10/03/25, 05:44
-
Benjamin Kott updated the commit message in patch set 6
CR +1V +110/06/25, 06:47 -
Benjamin Kott commented on patch set 6 10/06/25, 06:47
Breaking-107591-DropValuePickerFromColorLinkNumberAndTextInputTypes.rst:20ReplyDone -
core-ci voted on patch set 6 V -1 10/06/25, 06:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86056
-
Benjamin Kott uploaded patch set 7
V -110/06/25, 06:57 -
Benjamin Kott updated the commit message in patch set 8 10/06/25, 06:58
-
Benjamin Kott uploaded patch set 9 10/06/25, 07:01
-
core-ci voted on patch set 7 V +1 10/06/25, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86057
-
Benjamin Franzke commented on patch set 9 CR -1 10/06/25, 07:19
ColorElement.php:138benji and me agreed to migrate this to color palettes instead of dropping. That means we need to make it possible to define color palettes via TCA instead of only via PageTSconfig. ⇒`-1` -
core-ci voted on patch set 8 V +1 10/06/25, 07:26 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 9 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86060
-
core-ci voted on patch set 9 V +1 10/06/25, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86061
-
Benjamin Franzke commented on patch set 9 10/07/25, 09:32
ColorElement.php:138ReplyWIP patch is here: > 90936: [WIP][TASK] Show labels in color picker and merge value picker | https://review.typo3.org/c/Packages/TYPO3.CMS/+/90936 -
Simon Schaufelberger commented on patch set 9 11/07/25, 18:24
ColorElement.php:138Replywhat about this patch? Is still still relevant? -
Benjamin Kott uploaded patch set 10
CR -1V +110/08/26, 13:03 -
Benjamin Kott commented on patch set 10 10/08/26, 13:05
This change is ready for review.ColorElement.php:138Replyreworked, dropped link value picker, moved to a suggestion inside the wizard -
core-ci voted on patch set 10 V -1 10/08/26, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110494
-
Benjamin Kott uploaded patch set 11
V -110/08/26, 15:36 -
core-ci voted on patch set 11 V +1 10/08/26, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110515
-
Benjamin Kott uploaded patch set 12
V +110/15/26, 10:02 -
core-ci voted on patch set 12 V +1 10/15/26, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111175
-
Benjamin Kott uploaded patch set 13
V +110/15/26, 10:28 -
core-ci voted on patch set 13 V +1 10/15/26, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111179
-
Benjamin Kott uploaded patch set 14
V +110/15/26, 11:12 -
core-ci voted on patch set 14 V +1 10/15/26, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111182
-
Guido Schmechel commented on patch set 14 CR +1 V +1 10/16/26, 09:35
It worked well under my test conditions. However, please double-check the keyboard navigation one last time after selecting a suggestion. After selecting an external link and pressing the Tab key, “Page” was back in focus even though “External URL” was highlighted in blue. Since I'm no a11y expert here, just take this as a friendly reminder :-) -
Benjamin Kott uploaded patch set 15
CR +1V +110/23/26, 09:47 -
core-ci voted on patch set 15 V -1 10/23/26, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112260
-
Benjamin Kott rebased onto patch set 16
V -110/23/26, 12:44 -
core-ci voted on patch set 16 V +1 10/23/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112300