92294[FEATURE] Add secret type import in editor settings
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 32
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/94/92294/32 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/94/92294/32 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Merge conflicts 8
- main 95824[BUGFIX] Highlight nested site setting categories
- main 95436[WIP][TASK] Initialise class properties across the JavaScript stack
- main 95435[WIP][TASK] Enable strictNullChecks for the TypeScript build
- main 95434[WIP][TASK] Clear the last strictNullChecks errors in the backend
- main 97458[TASK] Update htmlnano to v3 and litnano to v1.1
- main 94048[WIP][TASK] Hide site settings in editor
- main 83623[WIP][FEATURE] Introduce System Settings API & Editor
- main 90079[WIP][FEATURE] Provide json-schema based settings type "complex"
Issues 2
Files 10
- Build/Sources/TypeScript/backend/settings/type/secret.tsnew+231 −0
- Build/Sources/TypeScript/backend/settings/editor.ts+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/password.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/secret.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor.js+1 −1
- typo3/sysext/core/Classes/Settings/Type/SecretType.phpnew+204 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108621-PasswordTypeForSiteSettings.rst4new+166 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/Set1/settings.definitions.yaml+6 −0
- typo3/sysext/core/Tests/Functional/Settings/Type/PasswordTypeTest.phpnew+198 −0
- typo3/sysext/core/Tests/Unit/Settings/Type/SecretTypeTest.phpnew+320 −0
Review log 4981
Show 3356 earlier messages
-
Christian Rath-Ulrich uploaded patch set 1 01/13/26, 08:54
-
core-ci voted on patch set 1 V -1 01/13/26, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93322
-
Torben Hansen commented on patch set 1 CR -1 01/13/26, 09:23
With TYPO3 14.0, the `TYPO3\CMS\Core\Crypto\Cipher\CipherService` has been introduced. Please use this service for symmetric encryption/decryption of sensitive data. -
Christian Rath-Ulrich uploaded patch set 2
CR -1V -101/13/26, 09:32 -
Torben Hansen commented on patch set 2 CR -1 01/13/26, 09:33
see my previous comment -
Christian Rath-Ulrich uploaded patch set 3
CR -101/13/26, 09:35 -
Garvin Hicking marked it work in progress 01/13/26, 09:39
-
core-ci voted on patch set 2 V -1 01/13/26, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93323
-
Christian Rath-Ulrich uploaded patch set 4 01/13/26, 09:41
-
core-ci voted on patch set 3 V -1 01/13/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93324
-
core-ci voted on patch set 4 V -1 01/13/26, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93325
-
Christian Rath-Ulrich uploaded patch set 5
V -101/13/26, 09:51 -
Christian Rath-Ulrich uploaded patch set 6 01/13/26, 09:55
-
core-ci voted on patch set 5 V -1 01/13/26, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93326
-
core-ci voted on patch set 6 V -1 01/13/26, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93327
-
Christian Rath-Ulrich uploaded patch set 7
V -101/13/26, 10:49 -
core-ci voted on patch set 7 V -1 01/13/26, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93331
-
Christian Rath-Ulrich updated the commit message in patch set 8
V -101/13/26, 12:24 -
core-ci voted on patch set 8 V -1 01/13/26, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93358
-
Christian Rath-Ulrich uploaded patch set 9
V -101/13/26, 12:40 -
Christian Rath-Ulrich uploaded patch set 10 01/13/26, 12:44
-
Christian Rath-Ulrich commented on patch set 10 01/13/26, 12:46
This change is ready for review.Reply
DoneReply
Done -
core-ci voted on patch set 9 V -1 01/13/26, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93359
-
core-ci voted on patch set 10 V -1 01/13/26, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93360
-
Christian Rath-Ulrich rebased onto patch set 11
V -101/13/26, 13:44 -
Christian Rath-Ulrich uploaded patch set 12 01/13/26, 13:48
-
core-ci voted on patch set 12 V -1 01/13/26, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93366
-
core-ci voted on patch set 11 V -1 01/13/26, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93364
-
Christian Rath-Ulrich uploaded patch set 13
V -101/13/26, 14:24 -
core-ci voted on patch set 13 V -1 01/13/26, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93373
-
Christian Rath-Ulrich updated the commit message in patch set 14
V -101/13/26, 15:37 -
Christian Rath-Ulrich uploaded patch set 15 01/13/26, 15:39
-
core-ci voted on patch set 15 V -1 01/13/26, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93381
-
core-ci voted on patch set 14 V -1 01/13/26, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93380
-
Christian Rath-Ulrich uploaded patch set 16
V -101/13/26, 16:08 -
Christian Rath-Ulrich rebased onto patch set 17 01/13/26, 16:13
-
Christian Rath-Ulrich updated the commit message in patch set 18 01/13/26, 16:15
-
core-ci voted on patch set 16 V +1 01/13/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93387
-
core-ci voted on patch set 17 V +1 01/13/26, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93388
-
core-ci voted on patch set 18 V +1 01/13/26, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93389
-
Simon Schaufelberger commented on patch set 18 CR -1 01/13/26, 16:26
composer.lock:11you probably did a full composer update. This is a no-go. Please revert. -
Georg Ringer commented on patch set 18 01/13/26, 21:05
Feature-108621-PasswordTypeForSiteSettings.rst:23I would like to see a warning if the encryption key changes or different one used, the password ist lost -
Garvin Hicking commented on patch set 18 01/14/26, 08:24
Feature-108621-PasswordTypeForSiteSettings.rst:14this is "XChaCha20-Poly1305" in the latest patchset revision nowFeature-108621-PasswordTypeForSiteSettings.rst:24XChaCha20-Poly1305Feature-108621-PasswordTypeForSiteSettings.rst:47```suggestion In PHP code, passwords can be decrypted using the :php:`PasswordType->decrypt()` method: ```Feature-108621-PasswordTypeForSiteSettings.rst:83Wasn't it mentioned that a prefix `###ENCRYPTED###` would be used?Feature-108621-PasswordTypeForSiteSettings.rst:130I did not check this, but in case of using environment variables as storage, you could use plain text input to get a config item with value '%env(...)%'? -
Christian Rath-Ulrich uploaded patch set 19
CR -1V +101/14/26, 13:58 -
Christian Rath-Ulrich uploaded patch set 20 01/14/26, 14:06
-
core-ci voted on patch set 19 V -1 01/14/26, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93446
-
Christian Rath-Ulrich uploaded patch set 21 01/14/26, 14:10
-
Christian Rath-Ulrich commented on patch set 20 01/14/26, 14:12
composer.lock:11ReplyDone -
core-ci voted on patch set 20 V +1 01/14/26, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93449
-
core-ci voted on patch set 21 V +1 01/14/26, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93450
-
Christian Rath-Ulrich uploaded patch set 22
V +101/14/26, 14:25 -
core-ci voted on patch set 22 V +1 01/14/26, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93453
-
Christian Rath-Ulrich uploaded patch set 23
V +101/14/26, 14:34 -
Christian Rath-Ulrich commented on patch set 22 01/14/26, 14:38
Feature-108621-PasswordTypeForSiteSettings.rst:14ReplyDoneFeature-108621-PasswordTypeForSiteSettings.rst:23ReplyDoneFeature-108621-PasswordTypeForSiteSettings.rst:24ReplyDoneFeature-108621-PasswordTypeForSiteSettings.rst:47ReplyDoneFeature-108621-PasswordTypeForSiteSettings.rst:83ReplyDoneFeature-108621-PasswordTypeForSiteSettings.rst:130ReplyDone -
core-ci voted on patch set 23 V -1 01/14/26, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93454
-
Christian Rath-Ulrich uploaded patch set 24
V -101/15/26, 15:14
-
core-ci voted on patch set 24 V +1 01/15/26, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93524
-
Guido Schmechel uploaded patch set 25
V +101/25/26, 10:27 -
core-ci voted on patch set 25 V -1 01/25/26, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94299
-
Guido Schmechel rebased onto patch set 26
V -101/25/26, 10:59 -
core-ci voted on patch set 26 V -1 01/25/26, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94303
-
Christian Rath-Ulrich uploaded patch set 27
V -101/26/26, 16:56 -
core-ci voted on patch set 27 V +1 01/26/26, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94378
-
Josef Glatz commented on patch set 27 01/29/26, 05:14
Beside the missing uppercase "F" in for: I would only add this info to the forge issue itself. it feels not good to put a link into the commit message where the target can be deleted, whatever...i would switch both lines. Resolves first -
Christian Rath-Ulrich rebased onto patch set 28
V +101/29/26, 08:52 -
core-ci voted on patch set 28 V +1 01/29/26, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94557
-
Garvin Hicking commented on patch set 28 V +1 02/03/26, 22:17
I tested this finally today, thanks so much for the iterations. :) There's one thing I wonder - when inputting the password, there's no way for me to see what I entered there before saving. What do you think about also adding this "eye" icon like for the backend login to reveal the contents on click? As long as the cleartext has not been saved yet that would be helpful. The "eye" could then, after persisting, only reveal a static text like "Encrypted value, can only be retrieved with API-Code access" or something like it?PasswordType.php:42we should add a comment here linking to the TS counterpart, because this is not a single source of truth (I wonder if it could be? Maybe transport the prefix to the webcomponent as an argument?) -
Torben Hansen commented on patch set 28 02/04/26, 06:05
Reply
Please no "eye" icons for persisted password field or password fields in the backend. The frontend login is IMO the only place this icon makes sence, so the user can see the entered password after a possible failed login. But for backend controls, this functionality would IMO make password fields more complicated with no real value for the user. Additionally we would then have the situation as described, that persisted passwords can not be revealed and instead a explaining text would be shown. We changed the backend password field years ago from being type=text to be type=password to keep things simple. So I suggest to leave password fields as "simple password fields" and do not add additional JS functionality. -
Garvin Hicking commented on patch set 28 02/04/26, 07:56
Reply
Sure, fine by me! If it becomes a complaining factor by users we can still discuss it later then. Resolving this. -
Benjamin Franzke commented on patch set 28 02/23/26, 19:38
Hey, thanks for tackling this, I agree we need some password/secret type, e.g. also for the system settings API. One general question: Is the encryption a general requirement for you, or did you apply it as a solution in order to be able to "ship" it into the settings editor?password.ts:164Hm, this (and the next condition) brakes "Reset setting" and basically disallows a user to unset a password. I'd probably compose the interface based on multiple components, instead of automagically detecting what the user intent is.Feature-108621-PasswordTypeForSiteSettings.rst:43Should we call this type `secret` instead of `password` to make clear that the value is not stored as a hashed password? I mean, the intention here is not to be able to test against this password, which would allow to store the password based on `password_hash`, but to use this as a secret for APIs. Therefore I think the term `secret` would be a better fit. I'd reserve `password` for a type that really stores as `password_hash` and would therefore only be usable for comparing password. (a usecase could be the installtool password for the system settings API)Feature-108621-PasswordTypeForSiteSettings.rst:64I'm completely unsure if I like or dislike this approach. From a security perspective it is nice: * Secrets are stored encrypted – awesome! * We do not need to care about settings being injected into TypoScript, because you never automatically decrypt From a conveniece perspective it is not nice: * We always need to instantiate/inject a settings type which was not meant to be API for setting consumers. I'd love if: * Settings editor would expose no value at all, not even an encrypted one. Only the information that a secret/password has been set or not, and if it differs from the system default (requires extending settings api semantics) * Settings injected into places like TypeScript should not expose secrets at all (not even encrypted ones) * `Settings->get()` would decrypt the value right away, since it feels wrong to have an asymmetric API, that allows to set a value, but only delivers an encrypted value. I'd combine this with the limitation that all `type=password/secret` entries would not be exposed to insecure spots (like TypoScript) -
Christian Rath-Ulrich uploaded patch set 29
V +102/27/26, 16:55 -
core-ci voted on patch set 29 V -1 02/27/26, 17:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96982
-
Christian Rath-Ulrich commented on patch set 28 02/27/26, 17:28
Reply
I included the encryption to ensure the security of the system. In our configuration, the setting.yml file is available for download, but we have taken measures to conceal the credentials.password.ts:164Reply UnresolvedAfter reading this comment, I tried to get the reset to work, but I don't know much about TS. I was not able toPasswordType.php:42Replymy TS knowlage is not enoght to get the argument working but i added a commentFeature-108621-PasswordTypeForSiteSettings.rst:43ReplyYes secret is the better name. My process began with a password and letter. We utilised it for API private keys as well.Feature-108621-PasswordTypeForSiteSettings.rst:64Reply UnresolvedSettings editor would expose no value at all, not even an encrypted one. Only the information that a secret/password has been set or not, and if it differs from the system default (requires extending settings api semantics) <- I'm not sure if I've got this right. I never show the encrypted one in the user interface, only 4 *. Are you referring to the YML file? Settings injected into places like TypeScript should not expose secrets at all (not even encrypted ones) <- Yes, but how can we do that? Settings->get() would decrypt the value right away, since it feels wrong to have an asymmetric API, that allows to set a value, but only delivers an encrypted value. I'd combine this with the limitation that all type=password/secret entries would not be exposed to insecure spots (like TypoScript) <- I had it in my head that decrypting always has to be a conscious action, but I can understand what you mean. -
Christian Rath-Ulrich uploaded patch set 30
V -102/27/26, 17:32 -
Christian Rath-Ulrich uploaded patch set 31 02/27/26, 17:35
-
core-ci voted on patch set 30 V -1 02/27/26, 17:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96989
-
core-ci voted on patch set 31 V -1 02/27/26, 17:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96990
-
Josef Glatz wrote 06/09/26, 03:55
Removed cc Josef Glatz. -
Simon Schaufelberger uploaded patch set 32
V -106/16/26, 22:28 -
core-ci voted on patch set 32 V -1 06/16/26, 22:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103583