Review main Ready for review

95824[BUGFIX] Highlight nested site setting categories

Georg Ringer CR 0 V 0 Hard +397 −42 updated 11/19/26, 10:06

Commit message

The navigation of the site settings editor determined the active entry
by walking the category tree in pre-order and taking the first visible
key. Ancestors therefore always won over their children, and a category
below the second level could never be highlighted: its parent headline
is still on screen, especially when that parent holds no settings of
its own and its children follow right below it.

The active entry is now the last category whose headline passed the
offset line, which is the most specific one being read, as the document
order of the category elements equals the pre-order of the tree. When
the settings of a category fill the screen, its headline has left the
viewport long ago, so visibility is no criterion any more and the
intersection observer is gone. The active category is re-evaluated on
scrolling instead, once per frame, and whenever the rendered categories
change. The scroll listener is removed when the editor is disconnected.

Scroll target and offset line share one calculation, which takes the
sticky offset of the search bar into account, so the module doc header
is respected and a selected category is evaluated exactly where it was
scrolled to. An explicit selection is kept until its smooth scrolling
ended, so the positions passed on the way no longer overrule the click.

The styleguide set demonstrates the settings editor now: one setting of
each type, a five level category tree and a grouping category without
settings of its own, labelled through the labels.xlf of the set. An
end-to-end test uses it to cover selecting and scrolling to them.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/24/95824/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/24/95824/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 3

  1. main 95826[BUGFIX] Translate form flex form data structure without $LANG Based on this change Merged Georg Ringer CR +2 V +2 → 14.3 Normal +155 −12

    The chain has patch set 1 of 5, the changes above it need a rebase.

  2. main 95825[TASK] Skip mechanical commits in git blame Based on this change Merged Georg Ringer CR +2 V +2 Normal +100 −0

    The chain has patch set 1 of 3, the changes above it need a rebase.

  3. 95824 [BUGFIX] Highlight nested site setting categories This change

Merge conflicts 9

Issues 1

Files 5

Review log 813

  1. Georg Ringer uploaded patch set 1 09/14/26, 21:25

  2. Georg Ringer commented on patch set 1 09/14/26, 21:27

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 09/14/26, 21:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108556

  4. core-ci voted on patch set 1 V +1 09/15/26, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108556

  5. Benni Mack uploaded patch set 2 V +1 11/11/26, 13:31

  6. core-ci voted on patch set 2 V +1 11/11/26, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114084

  7. Georg Ringer voted on patch set 2 CR +1 V +1 11/12/26, 17:09

  8. Wouter Wolters voted on patch set 2 CR +1 V +1 11/12/26, 18:56

  9. Benni Mack uploaded patch set 3 CR +1 V +1 11/12/26, 21:01

  10. core-ci voted on patch set 3 V +1 11/12/26, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114237

  11. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/16/26, 12:58

  12. Benni Mack uploaded patch set 4 CR +1 V +1 11/19/26, 09:50

  13. core-ci voted on patch set 4 V +1 11/19/26, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114990