Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress

95434[WIP][TASK] Clear the last strictNullChecks errors in the backend

Benjamin Kott CR 0 V -1 Normal +66 −60 updated 11/18/26, 11:28

Commit message

Resolve the remaining null and undefined violations in the backend
that need more than a non-null assertion, which leaves the whole stack
ready for strictNullChecks. The changes stay behaviour preserving: a
nullish fallback appears only where the compiler forces an actual
decision. Values guaranteed by contract but not by the type system
get their non-null assertion with strictNullChecks itself, as
no-unnecessary-type-assertion reports every such assertion until the
option is enabled.

Two cases deserve mention. Icons.getIcon() passes a five element array
that IconController destructures positionally, so the optional overlay
identifier has to keep its slot and the parameter type is widened
instead of the array being filtered. A selector read from a data
attribute is passed on as it is rather than falling back to an empty
string, which is not a valid selector and would throw where the
previous code simply found nothing.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 8
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/34/95434/8 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/34/95434/8 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Relation chain 13

  1. main 95437[WIP][TASK] Enable strict mode for the TypeScript build Based on this change Work in progress Merge conflict Benjamin Kott CR 0 V 0 → 14.3 Easy +1 −9
  2. main 95436[WIP][TASK] Initialise class properties across the JavaScript stack Based on this change Work in progress Merge conflict Benjamin Kott CR 0 V 0 → 14.3 Hard +275 −275
  3. main 95435[WIP][TASK] Enable strictNullChecks for the TypeScript build Based on this change Work in progress Merge conflict Benjamin Kott CR 0 V 0 → 14.3 Nightmare +1822 −1817
  4. 95434 [WIP][TASK] Clear the last strictNullChecks errors in the backend This change

  5. main 95433[WIP][TASK] Reduce the remaining backend strictNullChecks errors This change is based on it Work in progress Merge conflict Benjamin Kott CR 0 V 0 → 14.3 Normal +63 −59
  6. main 95432[WIP][TASK] Carry the backend further towards strictNullChecks This change is based on it Work in progress Merge conflict Benjamin Kott CR 0 V 0 → 14.3 Normal +57 −45
  7. main 95431[TASK] Make most of the backend TypeScript null-safe This change is based on it Benjamin Kott CR 0 V 0 → 14.3 Hard +204 −199

    The chain has patch set 8 of 10, the changes above it need a rebase.

  8. main 95430[TASK] Make the form editor null-safe This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Normal +91 −84

    The chain has patch set 8 of 10, the changes above it need a rebase.

  9. main 95429[TASK] Make the install tool null-safe This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Normal +99 −93

    The chain has patch set 8 of 10, the changes above it need a rebase.

  10. main 95428[TASK] Make the file list and the RTE null-safe This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Normal +119 −111

    The chain has patch set 8 of 10, the changes above it need a rebase.

  11. main 95427[TASK] Make the dashboard null-safe This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Normal +135 −70

    The chain has patch set 8 of 10, the changes above it need a rebase.

  12. main 95426[TASK] Guard nullable values in backend modules This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Hard +147 −123

    The chain has patch set 8 of 9, the changes above it need a rebase.

  13. main 95425[TASK] Guard nullable values in TypeScript This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Hard +307 −276

    The chain has patch set 8 of 10, the changes above it need a rebase.

Files 48

Show 28 more files

Review log 917

  1. Benjamin Kott uploaded patch set 1 08/26/26, 13:09

  2. Benjamin Kott marked it work in progress 08/26/26, 13:24

  3. core-ci voted on patch set 1 V +1 08/26/26, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107147

  4. Benjamin Kott uploaded patch set 2 V +1 10/15/26, 16:16

  5. core-ci voted on patch set 2 V -1 10/15/26, 17:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111236

  6. Benjamin Kott updated the commit message in patch set 3 V -1 10/15/26, 21:02

  7. core-ci voted on patch set 3 V -1 10/15/26, 21:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111277

  8. Benjamin Kott rebased onto patch set 4 V -1 10/16/26, 07:45

  9. core-ci voted on patch set 4 V -1 10/16/26, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111325

  10. Benjamin Kott rebased onto patch set 5 V -1 10/16/26, 09:26

  11. core-ci voted on patch set 5 V -1 10/16/26, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111340

  12. Benjamin Kott uploaded patch set 6 V -1 10/23/26, 14:49

  13. Benjamin Kott uploaded patch set 7 10/23/26, 15:42

  14. core-ci voted on patch set 6 V -1 10/23/26, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112332

  15. core-ci voted on patch set 7 V -1 10/23/26, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112352

  16. Benjamin Kott uploaded patch set 8 V -1 11/18/26, 10:59

  17. core-ci voted on patch set 8 V -1 11/18/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114864