Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
95192[WIP][TASK] Rework database analyzer stack
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 13
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/92/95192/13 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/92/95192/13 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 8
- main 95195[WIP][!!!][TASK] Remove SchemaMigrator::install()
- main 95194[WIP][!!!][TASK] Remove the array shaped schema migrator API
- main 95193[WIP][FEATURE] Add database schema update command
-
95192 [WIP][TASK] Rework database analyzer stack This change
- main 95191[WIP][TASK] Generate table option changes without platform hooks
- main 95190[WIP][TASK] Reduce column type comment handling to MySQL
- main 95189[WIP][TASK] Use non-deprecated doctrine introspection API
- main 95263[TASK] Raise doctrine/dbal to ~4.4.4
Issues 2
Files 48
- Build/phpstan/phpstan-baseline.neon+0 −6
- Build/Sources/Sass/module/_install.scss+58 −0
- Build/Sources/TypeScript/install/module/maintenance/database-analyzer.ts+699 −92
- Build/tests/playwright/e2e/install-tool/install-tool.spec.ts+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+8 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/Dto/ApplyResult.phpnew+80 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/Dto/ColumnDataMigrationRequest.phpnew+52 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/Dto/ColumnDataMigrationResult.phpnew+36 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/Dto/SchemaChange.phpnew+65 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/Dto/SchemaChangeSet.phpnew+199 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/Dto/SchemaComparison.phpnew+56 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/Dto/SchemaOperation.phpnew+50 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/Dto/TableChangeSet.phpnew+160 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/Dto/TableRename.phpnew+36 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/Exception/InvalidSchemaChangeException.phpnew+44 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/Exception/MixedChangeSafetyException.phpnew+41 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/ChangeSafety.phpnew+41 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/ChangeType.phpnew+67 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/ColumnDataMigrationStage.phpnew+55 −0
- typo3/sysext/core/Classes/Database/Schema/Analyzer/DatabaseSchemaAnalyzer.phpnew+721 −0
Show 28 more files
- typo3/sysext/core/Classes/Database/Schema/Analyzer/RemovalMode.phpnew+60 −0
- typo3/sysext/core/Classes/Database/Schema/Exception/AmbiguousColumnSequenceException.phpnew+35 −0
- typo3/sysext/core/Classes/Database/Schema/AlterTableStatementAggregator.phpnew+111 −0
- typo3/sysext/core/Classes/Database/Schema/ColumnDataMigration.phpnew+286 −0
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+224 −19
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+72 −14
- typo3/sysext/core/Classes/Package/PackageSetup.php+4 −17
- typo3/sysext/core/Classes/Service/DatabaseUpgradeWizardsService.php+20 −35
- typo3/sysext/core/Documentation/Changelog/15.0/Important-110427-DatabaseAnalyzerAppliesChangesPerTable.rstnew+61 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Important-110427-DatabaseAnalyzerResultObjects.rstnew+64 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/deletedPrefixedTable.sqlnew+7 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/indexedSearchIntegerHash.sqlnew+4 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/indexedSearchStringHash.sqlnew+4 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/tableWithDeletedPrefixedColumn.sqlnew+13 −0
- typo3/sysext/core/Tests/Functional/Database/Schema/Analyzer/DatabaseSchemaAnalyzerTest.phpnew+454 −0
- typo3/sysext/core/Tests/Functional/Database/Schema/AbstractSchemaBasedTestCase.php+51 −17
- typo3/sysext/core/Tests/Unit/Database/Schema/Analyzer/Dto/SchemaChangeSetTest.phpnew+222 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/Analyzer/Dto/SchemaChangeTest.phpnew+80 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/Analyzer/Dto/TableChangeSetTest.phpnew+129 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/Analyzer/ChangeTypeTest.phpnew+60 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/Analyzer/RemovalModeTest.phpnew+97 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/AlterTableStatementAggregatorTest.phpnew+145 −0
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+23 −133
- typo3/sysext/install/Classes/Service/DatabaseAnalyzerSuggestionService.phpnew+205 −0
- typo3/sysext/install/Configuration/JavaScriptModules.php+1 −0
- typo3/sysext/install/Resources/Private/Templates/Maintenance/DatabaseAnalyzer.fluid.html+48 −35
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/database-analyzer.js+4 −3
- typo3/sysext/install/Tests/Functional/Service/DatabaseAnalyzerSuggestionServiceTest.phpnew+286 −0
Review log 1326
Show 1 earlier messages
-
Stefan Bürk uploaded patch set 1 08/09/26, 21:00
-
core-ci voted on patch set 1 V -1 08/09/26, 21:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106232
-
Stefan Bürk uploaded patch set 2
V -108/09/26, 22:35 -
core-ci voted on patch set 2 V +1 08/09/26, 22:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106236
-
Stefan Bürk uploaded patch set 3
V +108/11/26, 00:32 -
core-ci voted on patch set 3 V +1 08/11/26, 00:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106356
-
Stefan Bürk uploaded patch set 4
V +108/11/26, 04:00 -
core-ci voted on patch set 4 V +1 08/11/26, 04:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106371
-
Stefan Bürk rebased onto patch set 5
V +108/11/26, 05:17 -
core-ci voted on patch set 5 V +1 08/11/26, 05:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106390
-
Stefan Bürk uploaded patch set 6
V +108/11/26, 11:38 -
core-ci voted on patch set 6 V +1 08/11/26, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106421
-
Stefan Bürk rebased onto patch set 7
V +108/11/26, 13:29 -
core-ci voted on patch set 7 V +1 08/11/26, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106437
-
Stefan Bürk uploaded patch set 8 08/11/26, 14:14
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 8 V +1 08/11/26, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106451
-
Stefan Bürk rebased onto patch set 9
V +108/14/26, 20:48 -
core-ci voted on patch set 9 V +1 08/14/26, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106727
-
Stefan Bürk rebased onto patch set 10
V +108/31/26, 10:28 -
core-ci voted on patch set 10 V -1 08/31/26, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107411
-
Stefan Bürk rebased onto patch set 11
V -109/02/26, 10:40 -
core-ci voted on patch set 11 V -1 09/02/26, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107596
-
Stefan Bürk uploaded patch set 12
V -109/02/26, 11:40 -
core-ci voted on patch set 12 V +1 09/02/26, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107612
-
Stefan Bürk rebased onto patch set 13
V +109/02/26, 13:16 -
core-ci voted on patch set 13 V +1 09/02/26, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107631