Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Stale Breaking

95195[WIP][!!!][TASK] Remove SchemaMigrator::install()

Stefan Bürk CR 0 V 0 Normal +62 −37 updated 09/02/26, 13:39

Commit message

`SchemaMigrator::install()` only survived the analyzer rework because
`typo3/testing-framework` creates the database of every functional test
through it. It did nothing but delegate to `applySafe()` and flatten the
result into a table name to error message map.

The testing framework calls `applySafe()` when the migrator offers it
and keeps `install()` as a fallback, guarded by a capability check so it
still works against v14. That leaves the wrapper in core without a
consumer, and it is removed.

The two core tests that still went through it apply their statements
with the `applySafeChanges()` helper instead.

`typo3/testing-framework` is raised to a state that contains that guard.

Used command(s):

Build/Scripts/runTests.sh -s composer -- update typo3/testing-framework

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 15
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/95/95195/15 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/95/95195/15 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 8

  1. 95195 [WIP][!!!][TASK] Remove SchemaMigrator::install() This change

  2. main 95194[WIP][!!!][TASK] Remove the array shaped schema migrator API This change is based on it Work in progress Merge conflict Stefan Bürk CR 0 V 0 database-analyzer Nightmare +1441 −3637
  3. main 95193[WIP][FEATURE] Add database schema update command This change is based on it Work in progress Stefan Bürk CR 0 V 0 database-analyzer Expert +1066 −0
  4. main 95192[WIP][TASK] Rework database analyzer stack This change is based on it Work in progress Merge conflict Stefan Bürk CR 0 V 0 database-analyzer Nightmare +5239 −372
  5. main 95191[WIP][TASK] Generate table option changes without platform hooks This change is based on it Work in progress Stefan Bürk CR 0 V 0 database-analyzer Hard +92 −282
  6. main 95190[WIP][TASK] Reduce column type comment handling to MySQL This change is based on it Work in progress Stefan Bürk CR 0 V 0 database-analyzer Normal +50 −105
  7. main 95189[WIP][TASK] Use non-deprecated doctrine introspection API This change is based on it Work in progress Stefan Bürk CR 0 V 0 → 14.3, 13.4 database-analyzer Expert +450 −599
  8. main 95263[TASK] Raise doctrine/dbal to ~4.4.4 This change is based on it Merged Stefan Bürk CR +2 V +2 → 14.3, 13.4 database-analyzer Normal +57 −5

Issues 2

Files 6

Review log 1531

Show 36 earlier messages
  1. Stefan Bürk uploaded patch set 1 08/09/26, 21:00

  2. core-ci voted on patch set 1 V -1 08/09/26, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106235

  3. Stefan Bürk rebased onto patch set 2 V -1 08/09/26, 22:35

  4. core-ci voted on patch set 2 V +1 08/09/26, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106239

  5. Stefan Bürk uploaded patch set 3 V +1 08/11/26, 00:32

  6. core-ci voted on patch set 3 V +1 08/11/26, 00:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106359

  1. Stefan Bürk uploaded patch set 4 V +1 08/11/26, 04:00

  2. core-ci voted on patch set 4 V +1 08/11/26, 04:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106374

  3. Stefan Bürk rebased onto patch set 5 V +1 08/11/26, 05:17

  4. core-ci voted on patch set 5 V -1 08/11/26, 05:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106393

  5. core-ci voted on patch set 5 V +1 08/11/26, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106393

  6. Stefan Bürk rebased onto patch set 6 V +1 08/11/26, 11:38

  7. core-ci voted on patch set 6 V +1 08/11/26, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106424

  8. Stefan Bürk rebased onto patch set 7 V +1 08/11/26, 13:29

  9. core-ci voted on patch set 7 V +1 08/11/26, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106440

  10. Stefan Bürk uploaded patch set 8 08/11/26, 14:14

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  11. core-ci voted on patch set 8 V +1 08/11/26, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106454

  12. Stefan Bürk rebased onto patch set 9 V +1 08/14/26, 20:48

  13. core-ci voted on patch set 9 V +1 08/14/26, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106730

  14. Stefan Bürk rebased onto patch set 10 V +1 08/31/26, 10:28

  15. Stefan Bürk uploaded patch set 11 08/31/26, 10:34

  16. Stefan Bürk uploaded patch set 12 08/31/26, 10:34

  17. core-ci voted on patch set 10 V +1 08/31/26, 10:57 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 11, 12 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107414

  18. core-ci voted on patch set 12 V +1 08/31/26, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107418

  19. core-ci voted on patch set 11 V +1 08/31/26, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107416

  20. Stefan Bürk rebased onto patch set 13 V +1 09/02/26, 10:40

  21. core-ci voted on patch set 13 V +1 09/02/26, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107599

  22. Stefan Bürk uploaded patch set 14 09/02/26, 11:40

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  23. core-ci voted on patch set 14 V +1 09/02/26, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107615

  24. Stefan Bürk rebased onto patch set 15 V +1 09/02/26, 13:16

  25. core-ci voted on patch set 15 V +1 09/02/26, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107634