Review main Work in progress Stale

95191[WIP][TASK] Generate table option changes without platform hooks

Stefan Bürk CR 0 V 0 Hard +92 −282 updated 09/02/26, 13:31

Commit message

doctrine/dbal neither compares nor applies table options such as
`ENGINE`, `ROW_FORMAT`, the default character set or the collation.
TYPO3 does, and injected the resulting statement by overriding
`getAlterTableSQL()` on every extended MySQL and MariaDB platform.

That override needed the extended `TableDiff` to read the changed
options from, and was the last reason for the platform classes to
know about a schema diff at all. Since the statement depends on
nothing but the platform, the current table and the changed options,
it is built by `TableOptionsStatementBuilder` now and added to the
statements of the table like any other one.

The MySQL rule to always re-apply `ROW_FORMAT` when `ENGINE` changes
is kept, including the reasoning behind it: the row format stated at
`CREATE TABLE` time is cached and would otherwise be re-applied by
the engine change.

As a result `MySQLCompatibleAlterTablePlatformAwareTrait` and the
`getAlterTableSQL()` overrides of all nine MySQL and MariaDB
platform classes are removed. None of them references a schema diff
anymore, which is what lets the diff classes go later on.

This change prepares the ongoing streamlining of the database
analyzer stack, and is useful on its own.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 11
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/91/95191/11 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/91/95191/11 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 8

  1. main 95195[WIP][!!!][TASK] Remove SchemaMigrator::install() Based on this change Work in progress Merge conflict Stefan Bürk CR 0 V 0 database-analyzer Normal +62 −37
  2. main 95194[WIP][!!!][TASK] Remove the array shaped schema migrator API Based on this change Work in progress Merge conflict Stefan Bürk CR 0 V 0 database-analyzer Nightmare +1441 −3637
  3. main 95193[WIP][FEATURE] Add database schema update command Based on this change Work in progress Stefan Bürk CR 0 V 0 database-analyzer Expert +1066 −0
  4. main 95192[WIP][TASK] Rework database analyzer stack Based on this change Work in progress Merge conflict Stefan Bürk CR 0 V 0 database-analyzer Nightmare +5239 −372
  5. 95191 [WIP][TASK] Generate table option changes without platform hooks This change

  6. main 95190[WIP][TASK] Reduce column type comment handling to MySQL This change is based on it Work in progress Stefan Bürk CR 0 V 0 database-analyzer Normal +50 −105
  7. main 95189[WIP][TASK] Use non-deprecated doctrine introspection API This change is based on it Work in progress Stefan Bürk CR 0 V 0 → 14.3, 13.4 database-analyzer Expert +450 −599
  8. main 95263[TASK] Raise doctrine/dbal to ~4.4.4 This change is based on it Merged Stefan Bürk CR +2 V +2 → 14.3, 13.4 database-analyzer Normal +57 −5

Merge conflicts 3

Issues 2

Files 12

Review log 1122

  1. Stefan Bürk uploaded patch set 1 08/09/26, 21:00

  2. core-ci voted on patch set 1 V +1 08/09/26, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106231

  3. Stefan Bürk rebased onto patch set 2 V +1 08/11/26, 00:32

  4. core-ci voted on patch set 2 V +1 08/11/26, 00:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106355

  5. Stefan Bürk rebased onto patch set 3 V +1 08/11/26, 04:00

  6. core-ci voted on patch set 3 V +1 08/11/26, 04:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106370

  7. Stefan Bürk rebased onto patch set 4 V +1 08/11/26, 05:17

  8. core-ci voted on patch set 4 V +1 08/11/26, 05:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106389

  9. Stefan Bürk rebased onto patch set 5 V +1 08/11/26, 11:38

  10. core-ci voted on patch set 5 V +1 08/11/26, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106420

  11. Stefan Bürk uploaded patch set 6 V +1 08/11/26, 13:29

  12. core-ci voted on patch set 6 V +1 08/11/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106436

  13. Stefan Bürk uploaded patch set 7 08/11/26, 14:14

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  14. core-ci voted on patch set 7 V +1 08/11/26, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106450

  15. Stefan Bürk rebased onto patch set 8 V +1 08/14/26, 20:48

  16. core-ci voted on patch set 8 V +1 08/14/26, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106726

  17. Stefan Bürk rebased onto patch set 9 V +1 08/31/26, 10:28

  18. core-ci voted on patch set 9 V +1 08/31/26, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107410

  19. Stefan Bürk rebased onto patch set 10 V +1 09/02/26, 10:40

  20. core-ci voted on patch set 10 V +1 09/02/26, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107595

  21. Stefan Bürk rebased onto patch set 11 V +1 09/02/26, 13:16

  22. core-ci voted on patch set 11 V +1 09/02/26, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107630