Review main Ready for review Stale

95467[BUGFIX] Passthrough SiteConfigurationWriteException in SiteSettingsService

Simon Schmidt CR +1 V +1 Easy +32 −12 updated 09/15/26, 09:05

Commit message

SiteSettingsService::writeSettings() silently caught
SiteConfigurationWriteException and never re-threw it. Callers had
no way to detect whether a settings write had actually succeeded.

The exception is now re-thrown after the flash message is enqueued,
so callers can react to the failure appropriately. The code cache
flush is intentionally skipped on failure as nothing was written.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 10
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/95467/10 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/95467/10 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Benjamin Franzke +1
  • Verified V +1 Needs a vote
    • Benjamin Franzke +1
    • core-ci +1 CI

Relation chain 3

  1. main 95647[BUGFIX] Avoid path disclosure in site settings write error Based on this change Abandoned Simon Schmidt CR 0 V 0 → 14.4, 13.4 Easy +17 −1
  2. 95467 [BUGFIX] Passthrough SiteConfigurationWriteException in SiteSettingsService This change

  3. main 95846[BUGFIX] Suppress warnings from `GeneralUtility::writeFile()` This change is based on it Merged Benjamin Franzke CR +2 V +2 → 14.3, 13.4 Easy +3 −3

    The chain has patch set 1 of 2, the changes above it need a rebase.

Merge conflicts 3

Issues 1

Files 3

Review log 1727

Show 12 earlier messages
  1. Simon Schmidt uploaded patch set 1 08/28/26, 05:46

  2. core-ci voted on patch set 1 V +1 08/28/26, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107315

  1. Benni Mack updated the commit message in patch set 2 V +1 09/04/26, 13:29

  2. Benni Mack rebased onto patch set 3 09/04/26, 13:29

  3. Simon Schmidt updated the commit message in patch set 4 09/04/26, 13:35

  4. core-ci voted on patch set 2 V +1 09/04/26, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107878

  5. core-ci voted on patch set 3 V +1 09/04/26, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107879

  6. core-ci voted on patch set 4 V +1 09/04/26, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107881

  7. Simon Schmidt uploaded patch set 5 V +1 09/04/26, 14:04

  8. Simon Schmidt updated the commit message in patch set 6 09/04/26, 14:07

  9. core-ci voted on patch set 6 V +1 09/04/26, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107887

  10. core-ci voted on patch set 5 V +1 09/04/26, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107886

  11. Simon Schmidt uploaded patch set 7 V +1 09/07/26, 09:21

  12. core-ci voted on patch set 7 V +1 09/07/26, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107989

  13. Maike Kiebele voted on patch set 7 V +1 09/07/26, 13:43

  14. Simon Schaufelberger voted on patch set 7 CR +1 V +1 09/11/26, 22:19

  15. Benjamin Franzke commented on patch set 7 09/15/26, 07:09

    nitpick: it is internal API, so there *should* be no other callers, but I agree it is better to remove the flash message handling from the service and move it into the controller, in case we every use it somewhere else :+1:

    SiteWriter.php:99

    Why do you catch here? `GeneralUtility::writeFile()` is not supposed to throw. Maybe because `fwrite()` could emit a warning which is transformed to an error in certain environments? (If that's the reason I'd opt to fix this part in `GU:writeFile()` by using `@fwrite()`.)
  16. Benjamin Franzke uploaded patch set 8 CR +1 V +1 09/15/26, 08:48

  17. Benjamin Franzke commented on patch set 8 09/15/26, 08:49

    SiteWriter.php:99 Reply

    Discussed with Simon and moved into a pre patch: > 95846: [BUGFIX] Suppress warnings from `GeneralUtility::writeFile()` | https://review.typo3.org/c/Packages/TYPO3.CMS/+/95846
  18. Benjamin Franzke voted on patch set 8 CR +1 V +1 09/15/26, 08:53

  19. Benjamin Franzke uploaded patch set 9 CR +1 V +1 09/15/26, 08:54

  20. Benjamin Franzke voted on patch set 9 CR +1 V +1 09/15/26, 08:55

  21. Benjamin Franzke updated the commit message in patch set 10 CR +1 V +1 09/15/26, 08:56

  22. Benjamin Franzke voted on patch set 10 CR +1 V +1 09/15/26, 08:56

  23. core-ci voted on patch set 8 V +1 09/15/26, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108594

  24. core-ci voted on patch set 9 V -1 09/15/26, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108596

  25. core-ci voted on patch set 10 V +1 09/15/26, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108597