Review main Ready for review Quiet

95916[BUGFIX] Render backend action buttons as HTML buttons

Georg Ringer CR +1 V +1 Normal +124 −65 updated 11/04/26, 06:33

Commit message

Several buttons in the backend do not navigate anywhere but trigger
a JavaScript action. They were rendered as <a href="#">, which is
not activated by the space key, offers a misleading context menu
and is announced as a link by assistive technology.

These buttons are now built with GenericButton and rendered as
<button type="button">. Affected are the "view webpage" button of
the component factory, the close, new, duplicate and open in new
window buttons of the record editing form, the preview link button
of the workspaces module, the create button of the form manager
and the action buttons of the form manager list view. The disabled
default language item of the language selector becomes a button as
well, where the disabled attribute now actually takes effect.

All data attributes and t3js- classes are kept, so the existing
JavaScript continues to work unchanged.

ComponentFactory->createViewButton() returns a GenericButton now.
Its disabled state uses the disabled attribute instead of
aria-disabled and a CSS class.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/16/95916/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/16/95916/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Ravi Sachaniya +1
  • Verified V +1 Needs a vote
    • Ravi Sachaniya +1
    • core-ci +1 CI

Merge conflicts 18

Issues 1

Files 11

Review log 912

  1. Georg Ringer uploaded patch set 1 09/18/26, 14:29

  2. Georg Ringer commented on patch set 1 09/18/26, 14:29

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/18/26, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108812

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/18/26, 23:00

  5. Benni Mack commented on patch set 1 CR -1 10/22/26, 15:43

    I do not see the need for a Important RST
  6. Christian Rath-Ulrich voted on patch set 1 CR +1 V +1 10/23/26, 19:51

  7. Georg Ringer uploaded patch set 2 CR +1 V +1 11/03/26, 19:11

  8. Georg Ringer commented on patch set 2 11/03/26, 19:11

    Reply

    adopted the rst, IMO it is needed because of changed behavior, could even be an important rst
  9. core-ci voted on patch set 2 V -1 11/03/26, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113208

  10. Georg Ringer uploaded patch set 3 V -1 11/03/26, 21:07

  11. core-ci voted on patch set 3 V +1 11/03/26, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113231

  12. Ravi Sachaniya voted on patch set 3 CR +1 V +1 11/04/26, 06:33