96567[TASK] Stop depending on the process locale per request
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/96567/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/96567/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Simon Schaufelberger +1
- core-ci +1 CI
Merge conflicts 14
- main 95067[BUGFIX] Cache busting for images rendered by Fluid
- main 97603[TASK] Introduce RecordTypeResolver and deprecate getTCAtypeValue()
- main 95269[!!!][TASK] Sort select options using Collator
- main 93628[WIP][TASK] Make GD the baseline image processor
- main 95105[TASK] Apply PHP code simplifications
- main 96201[FEATURE] Introduce upload constraints for file uploads
- main 92589[TASK] Replace unneeded instanceof on xxx|null. Use a null check instead
- main 95539[BUGFIX] Respect content_from_pid for recursive CONTENT
- main 94780[TASK] Deprecate Site setting typo3Language
- main 94038[WIP][TASK] Use `Uri` for validation in GeneralUtility:isValidUrl()
- main 84314[FEATURE] Symfony expressions for TypoScript if function
- main 92520[Proof of Concept] Switch from "default" to real language with "en" fallback
- main 75180[WIP][TASK] Introduce URL QueryParams models
- main 67912[FEATURE] allow TypoScript's select without constraint of uid or pid
Issues 1
Files 18
- typo3/sysext/core/Classes/Localization/Locales.php+16 −0
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+12 −10
- typo3/sysext/core/Documentation/Changelog/15.0/Deprecation-110967-SetSystemLocaleFromSiteLanguage.rst2new+154 −0
- typo3/sysext/core/Tests/Unit/Localization/LocalesTest.php+15 −4
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+18 −0
- typo3/sysext/extbase/Classes/Validation/Validator/FileSizeValidator.php+2 −2
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingLocaleResolver.phpnew+54 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CountrySelectViewHelper.php+6 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+2 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+3 −31
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/CountrySelectViewHelperTest.php+11 −22
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SelectViewHelperTest.php+27 −23
- typo3/sysext/form/Classes/Mvc/Validation/FileSizeValidator.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+15 −4
- typo3/sysext/frontend/Classes/Middleware/SiteResolver.php+1 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+19 −0
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 912
-
Benni Mack uploaded patch set 1 10/09/26, 16:51
-
core-ci voted on patch set 1 V +1 10/09/26, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110656
-
Wouter Wolters voted on patch set 1 CR +1 10/09/26, 19:39
-
Benni Mack voted on patch set 1 CR -1 10/09/26, 19:49
-
Benni Mack uploaded patch set 2
CR +1V +111/09/26, 13:26 -
core-ci voted on patch set 2 V +1 11/09/26, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113685
-
Jochen Roth voted on patch set 2 CR +1 V +1 11/09/26, 14:28
-
Simon Schaufelberger commented on patch set 2 11/09/26, 15:17
-
Benni Mack uploaded patch set 3
CR +1V +111/10/26, 17:12 -
Benni Mack commented on patch set 3 11/10/26, 17:12
Deprecation-110967-SetSystemLocaleFromSiteLanguage.rst:70ReplyDone -
core-ci voted on patch set 3 V +1 11/10/26, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113924
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/10/26, 18:24
Deprecation-110967-SetSystemLocaleFromSiteLanguage.rst:70