96626[FEATURE] Use foreign_table in form editor selects
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/96626/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/96626/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 12
- main 96357[FEATURE] Attach static files to form emails
- main 96746[FEATURE] Offer stored forms in new content element wizard
- main 94214[TASK] Remove TYPO3_REQUEST from ext:form
- main 97596[FEATURE] Add webhook finisher to the form framework
- main 97196[TASK] Use searchable selects in backend modules
- main 96364[FEATURE] Allow disabling duplication of forms
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 94503[WIP][TASK] Save finishers in dedicated table
- main 94215[PoC] remove yamlSettingsOverrides / ExtbaseConfigurationManager in ext:form
- main 93046[FEATURE] Introduce InspectorEditorRegistry for ext:form
- main 89940[FEATURE] Allow to restrict HTTP methods for extbase actions
- main 68199[WIP][TASK] Add <typo3-backend-module> element
Issues 1
Files 18
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-89690-ReadSelectOptionsInTheFormEditorFromADatabaseTable.rstnew+70 −0
- typo3/sysext/form/Classes/Controller/FormEditorController.php+2 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/FormElement/ForeignTableExtractor.phpnew+47 −0
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/PropertyCollectionElement/ForeignTableExtractor.phpnew+49 −0
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+52 −16
- typo3/sysext/form/Classes/Service/ForeignTableSelectOptionsService.phpnew+173 −0
- typo3/sysext/form/Classes/Service/FormEditorEnrichmentService.php+51 −2
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formEditor/inspectorEditors/properties/ForeignTable.rst.txtnew+40 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formEditor/inspectorEditors/properties/ForeignTableWhere.rst.txtnew+26 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formEditor/inspectorEditors/MultiSelectEditor.rst+8 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formEditor/inspectorEditors/SingleSelectEditor.rst+8 −0
- typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php+1 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/ConfigurationServiceTest.php+160 −0
- typo3/sysext/form/Tests/Functional/Domain/Factory/ArrayFormFactoryTest.php+2 −0
- typo3/sysext/form/Tests/Functional/Domain/Model/Renderable/AbstractRenderableTest.php+2 −0
- typo3/sysext/form/Tests/Functional/Service/Fixtures/ForeignTableSelectOptionsServiceTestImport.csvnew+21 −0
- typo3/sysext/form/Tests/Functional/Service/ForeignTableSelectOptionsServiceTest.phpnew+107 −0
- typo3/sysext/form/Tests/Unit/Service/FormEditorEnrichmentServiceTest.php+91 −8
Review log 611
-
Josua Vogel uploaded patch set 1 10/12/26, 07:31
-
core-ci voted on patch set 1 V +1 10/12/26, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110889
-
Josua Vogel uploaded patch set 2
V +110/16/26, 21:44 -
core-ci voted on patch set 2 V +1 10/16/26, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111398
-
Josua Vogel commented on patch set 2 10/17/26, 09:37
This change is ready for review. -
Josua Vogel rebased onto patch set 3
V +110/26/26, 07:42 -
core-ci voted on patch set 3 V +1 10/26/26, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112576
-
Josua Vogel rebased onto patch set 4
V +111/11/26, 16:13 -
core-ci voted on patch set 4 V +1 11/11/26, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114126
-
Josua Vogel uploaded patch set 5
V +111/15/26, 16:06 -
core-ci voted on patch set 5 V +1 11/15/26, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114547