Review main Work in progress

96826[BUGFIX] Clear cache on reordering of inline children

Benni Mack CR +1 V 0 Normal +227 −0 updated 11/10/26, 09:22

Commit message

The order and the set of children of a foreign_field relation (inline
and file fields) are only stored in the children, which are written
directly by RelationHandler::writeForeignField(). The parent keeps its
child count, so DataHandler sees no change on the parent and neither
clears its page caches nor runs the TCEMAIN.clearCacheCmd of its page.

DataHandler now compares the current children with the submitted ones
and registers the parent for cache clearing when they differ.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/96826/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/96826/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Markus Klein +1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 20

Issues 1

Files 3

Review log 46

  1. Benni Mack uploaded patch set 1 10/18/26, 14:51

  2. core-ci voted on patch set 1 V -1 10/18/26, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111537

  3. Benni Mack uploaded patch set 2 V -1 10/25/26, 11:18

  4. core-ci voted on patch set 2 V +1 10/25/26, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112481

  5. Markus Klein voted on patch set 2 CR +1 10/26/26, 21:36

  6. Markus Klein commented on patch set 2 10/26/26, 21:36

    Unresolved

    Does that work recursively? Do if we have a double-nesting of IRRE