97812[BUGFIX] Publish inline MM relations in workspaces
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/97812/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/97812/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Merge conflicts 28
- main 97560[TASK] Find subpages with one query when copying and deleting pages
- main 97603[TASK] Introduce RecordTypeResolver and deprecate getTCAtypeValue()
- main 93752[BUGFIX] Skip translations when pasting into another language
- main 93819[WIP][BUGFIX] Guard translated tt_content free-mode moves
- main 95488[BUGFIX] Warn about endtime before starttime
- main 93806[FEATURE] Auto-generate INT columns for type=group relationships
- main 97242[BUGFIX] Take version records into account for `eval=unique` checks
- main 94753[FEATURE] New TCA type "coordinate"
- main 97164[BUGFIX] Ask for required fields when translating a page
- main 95105[TASK] Apply PHP code simplifications
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 74781[FEATURE] Introduce new slug builders for records and string
- main 96829[!!!][BUGFIX] Restore deleted records by their deletion operation
- main 94879[BUGFIX] Reference translated records when localizing relations
- main 92859[WIP][BUGFIX] Make MM tables language-aware and workspace-aware
- main 96344[BUGFIX] Keep live and foreign MM rows when creating a version
- main 96342[BUGFIX] Keep MM relations when publishing one side in workspaces
- main 75020[FEATURE] Allow excluding tables from page copy
- main 96113[WIP][BUGFIX] Honor record web mount exemptions
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 95343[FEATURE] Add `adminOnly` for TCA columns
- main 95638[TASK] Extend FieldValidationService to more TCA field types
- main 95639[TASK] Extract a read-only UniquenessChecker from DataHandler
- main 95637[TASK] Introduce FieldValidationService for TCA field validation
- main 93407[TASK] Modernize `RecordHistoryStore`
- main 92214[TASK] Introduce generic permission sets for accessing data
- main 85574[WIP][FEATURE] Language-aware slugs and slug normalizer API
- main 87719[WIP][BUGFIX] Mitigate missing column in cached schema information
Issues 2
Files 26
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+71 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/DataSet/ImportInlineMM1Children.csv+6 −6
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesModify/DataSet/modifyTestMMWithInlineMM1Children.csv+3 −3
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/modifyContentAndAddInlineMM1Foreign.csvnew+24 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/modifyContentAndChangeInlineMM1ForeignSorting.csvnew+22 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/modifyContentAndRemoveOneInlineMM1Foreign.csvnew+20 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/modifyContentOfInlineMM1Children.csvnew+30 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/modifyTestMMAndAddInlineMM1Child.csvnew+28 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/modifyTestMMAndChangeInlineMM1ChildSorting.csvnew+26 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/modifyTestMMAndRemoveInlineMM1Children.csvnew+22 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/modifyTestMMAndRemoveOneInlineMM1Child.csvnew+24 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/modifyTestMMWithInlineMM1Children.csvnew+26 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/ActionTest.php+72 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/modifyContentAndAddInlineMM1Foreign.csvnew+24 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/modifyContentAndChangeInlineMM1ForeignSorting.csvnew+22 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/modifyContentAndRemoveOneInlineMM1Foreign.csvnew+20 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/modifyContentOfInlineMM1Children.csvnew+30 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/modifyTestMMAndAddInlineMM1Child.csvnew+28 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/modifyTestMMAndChangeInlineMM1ChildSorting.csvnew+26 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/modifyTestMMAndContentOfInlineMM1Relation.csvnew+28 −0
Show 6 more files
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/modifyTestMMAndRemoveInlineMM1Children.csvnew+22 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/modifyTestMMAndRemoveOneInlineMM1Child.csvnew+24 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/modifyTestMMWithInlineMM1Children.csvnew+26 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/ActionTest.php+80 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/AbstractActionTestCase.php+55 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_mm/Configuration/TCA/Overrides/tt_content.php+11 −1
Review log 46
-
Benjamin Kott uploaded patch set 1 11/18/26, 22:31
-
core-ci voted on patch set 1 V +1 11/18/26, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114943
-
Benni Mack commented on patch set 1 CR -1 11/19/26, 07:31
-
Benni Mack uploaded patch set 2
CR -1V +111/19/26, 08:09 -
Benni Mack commented on patch set 2 11/19/26, 08:11
Unresolved
PS2 adds tests only, no change to DataHandler: - sys_refindex is now asserted in all inline MM publish datasets. - New: relations edited from the opposite side (tt_content.inline_mm_1_foreign: remove one, add, reorder), each in Publish and PublishAll. These fail without your fix and pass with it. - New PublishAll test modifyTestMMAndContentOfInlineMM1Relation, with versions on both sides of the relation. It is red on purpose: the relation removed on one side comes back once both versions are published. Group MM fields do exactly the same, so this is an existing limitation of two-way MM relations in workspaces, not something your patch introduced. How do you want to proceed: fix it here, or move it to its own issue? -
core-ci voted on patch set 2 V -1 11/19/26, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114971
Unresolved