Review main Ready for review

97812[BUGFIX] Publish inline MM relations in workspaces

Benjamin Kott CR 0 V -1 Hard +770 −11 updated 11/19/26, 08:24

Commit message

Publishing a version now replaces the MM rows of the live record for an
inline field with an MM table, as it already does for group, select and
category fields, so children added, removed or reordered in a workspace
reach the live record. The related records keep the order they have on
the opposite side, which the rows of the version do not carry.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/97812/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/97812/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 28

Issues 2

Files 26

Show 6 more files

Review log 46

  1. Benjamin Kott uploaded patch set 1 11/18/26, 22:31

  2. core-ci voted on patch set 1 V +1 11/18/26, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114943

  3. Benni Mack commented on patch set 1 CR -1 11/19/26, 07:31

    Unresolved

    on it
  4. Benni Mack uploaded patch set 2 CR -1 V +1 11/19/26, 08:09

  5. Benni Mack commented on patch set 2 11/19/26, 08:11

    Unresolved

    PS2 adds tests only, no change to DataHandler: - sys_refindex is now asserted in all inline MM publish datasets. - New: relations edited from the opposite side (tt_content.inline_mm_1_foreign: remove one, add, reorder), each in Publish and PublishAll. These fail without your fix and pass with it. - New PublishAll test modifyTestMMAndContentOfInlineMM1Relation, with versions on both sides of the relation. It is red on purpose: the relation removed on one side comes back once both versions are published. Group MM fields do exactly the same, so this is an existing limitation of two-way MM relations in workspaces, not something your patch introduced. How do you want to proceed: fix it here, or move it to its own issue?
  6. core-ci voted on patch set 2 V -1 11/19/26, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114971