Review main Ready for review

97473[BUGFIX] Store remapped uid of passthrough translation pointers

Benni Mack CR 0 V 0 Normal +175 −2 updated 11/10/26, 06:08

Commit message

DataHandler::processRemapStack() kept the value of the previous
remap action in a variable declared outside of the loop. Remap
actions without a processing function, which are added for NEW
placeholders in passthrough translation pointer fields such as
"l10n_source", or "l10n_parent" defined as passthrough, never set
this value and wrote the one of the previous action instead.

Creating a record together with its translations in one data map
could therefore point the translations to a wrong record, or fail
with a NOT NULL error if no other action came first.

The value is now reset for every remap action, and actions without
a processing function store their remapped uid.

The expected data set of a scenario test recorded such a stale value:
the "l10n_source" of a translation in a translation chain pointed to
the default language record instead of its actual source.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/73/97473/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/73/97473/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 22

Issues 1

Files 4

Review log 24

  1. Benni Mack uploaded patch set 1 11/09/26, 20:55

  2. core-ci voted on patch set 1 V -1 11/09/26, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113788

  3. core-ci voted on patch set 1 V +1 11/10/26, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113788

  4. Benni Mack marked it ready for review 11/10/26, 06:08