83460[BUGFIX] Respect parent language uid in new FlexForm inline relations
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 10
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/60/83460/10 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/60/83460/10 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 23
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 97560[TASK] Find subpages with one query when copying and deleting pages
- main 97528[BUGFIX] Keep live uids in relations of new versions
- main 97603[TASK] Introduce RecordTypeResolver and deprecate getTCAtypeValue()
- main 93819[WIP][BUGFIX] Guard translated tt_content free-mode moves
- main 97426[FEATURE] Support TCAdefaults for FlexForm fields
- main 94753[FEATURE] New TCA type "coordinate"
- main 95105[TASK] Apply PHP code simplifications
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 74781[FEATURE] Introduce new slug builders for records and string
- main 96829[!!!][BUGFIX] Restore deleted records by their deletion operation
- main 94879[BUGFIX] Reference translated records when localizing relations
- main 92859[WIP][BUGFIX] Make MM tables language-aware and workspace-aware
- main 96344[BUGFIX] Keep live and foreign MM rows when creating a version
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 95343[FEATURE] Add `adminOnly` for TCA columns
- main 95638[TASK] Extend FieldValidationService to more TCA field types
- main 95639[TASK] Extract a read-only UniquenessChecker from DataHandler
- main 95637[TASK] Introduce FieldValidationService for TCA field validation
- main 93407[TASK] Modernize `RecordHistoryStore`
- main 92214[TASK] Introduce generic permission sets for accessing data
- main 85574[WIP][FEATURE] Language-aware slugs and slug normalizer API
- main 87719[WIP][BUGFIX] Mitigate missing column in cached schema information
Issues 3
Files 6
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php+9 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaFlexProcessTest.php+96 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+103 −56
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-103970-InlineChildrenFollowTheLanguageOfTheirParent.rst+3 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/Fixtures/InlineChildLanguageInFlexForm.csvnew+10 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/InlineChildLanguageTest.php+79 −0
Review log 1524
-
Daniel Siepmann uploaded patch set 1 03/14/24, 06:25
-
Daniel Siepmann rebased onto patch set 2 03/14/24, 07:37
-
core-ci voted on patch set 2 V -1 03/14/24, 07:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54514
-
Daniel Siepmann updated the commit message in patch set 3
V -103/14/24, 07:43 -
core-ci voted on patch set 3 V -1 03/14/24, 07:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54515
-
Christian Kuhn commented on patch set 3 CR -1 03/14/24, 07:52
I hope it's ok to -1 here for now: At first thought, it looks as if it would be better if DH takes care of sys_language_uid for new flex form inline children. -
Daniel Siepmann commented on patch set 3 04/24/24, 06:10
Reply
Sure. I debugged this and the link generated to create a new element is missing the necessary information. That's why I added it here, as everything else is already in place for inline handling. It is now following the normal inline handling, just for FlexForm inline as well. -
Benni Mack updated the commit message in patch set 4
CR -1V -110/18/24, 13:29 -
core-ci voted on patch set 4 V -1 10/18/24, 20:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67973
-
Benni Mack rebased onto patch set 5
V -103/25/25, 20:31 -
core-ci voted on patch set 5 V -1 03/25/25, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76310
-
Benni Mack wrote 03/28/25, 08:26
Hashtag added: lolli-feedback -
Benni Mack uploaded patch set 6
V -104/11/25, 09:17 -
core-ci voted on patch set 6 V +1 04/11/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77510
-
Benni Mack updated the commit message in patch set 7
V +104/12/25, 07:17 -
core-ci voted on patch set 7 V +1 04/12/25, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77609
-
Benni Mack updated the commit message in patch set 8
V +104/22/26, 06:55 -
core-ci voted on patch set 8 V -1 04/22/26, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100835
-
Christian Kuhn wrote 06/18/26, 23:06
Removed reviewer Christian Kuhn. -
Benni Mack uploaded patch set 9
V -111/09/26, 11:40 -
Benni Mack wrote 11/09/26, 11:40
Hashtag removed: lolli-feedback -
core-ci voted on patch set 9 V +1 11/09/26, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113662
-
Benni Mack uploaded patch set 10
V +111/09/26, 11:56 -
core-ci voted on patch set 10 V +1 11/09/26, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113664