Review main Ready for review

83460[BUGFIX] Respect parent language uid in new FlexForm inline relations

Daniel Siepmann CR 0 V 0 Hard +300 −57 updated 11/09/26, 12:04

Commit message

New inline records and file references within FlexForms didn't
receive the language of the record holding the FlexForm.

In the backend form, TcaFlexProcess compiles the fields of each
FlexForm sheet as a segment of their own, without the language
field of the record. TcaInlineConfiguration and TcaFiles therefore
could not hand the language of a localized record over to new
children, as they do for regular fields. The segment now receives
the name of the language field and the language of the record, for
fields with and without a value. The language is only used for
processing and is not added to the FlexForm values.

Since #103970, DataHandler aligns the language of inline children
with their parent, but only looked at the inline and file fields of
the table itself. The fields within the sheets of flex fields are
now aligned as well, using the FlexForm schema of the record. New
children submitted within a FlexForm trigger the alignment, too.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 10
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/60/83460/10 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/60/83460/10 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 23

Issues 3

Files 6

Review log 1524

  1. Daniel Siepmann uploaded patch set 1 03/14/24, 06:25

  2. Daniel Siepmann rebased onto patch set 2 03/14/24, 07:37

  3. core-ci voted on patch set 2 V -1 03/14/24, 07:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54514

  4. Daniel Siepmann updated the commit message in patch set 3 V -1 03/14/24, 07:43

  5. core-ci voted on patch set 3 V -1 03/14/24, 07:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54515

  6. Christian Kuhn commented on patch set 3 CR -1 03/14/24, 07:52

    I hope it's ok to -1 here for now: At first thought, it looks as if it would be better if DH takes care of sys_language_uid for new flex form inline children.
  7. Daniel Siepmann commented on patch set 3 04/24/24, 06:10

    Reply

    Sure. I debugged this and the link generated to create a new element is missing the necessary information. That's why I added it here, as everything else is already in place for inline handling. It is now following the normal inline handling, just for FlexForm inline as well.
  8. Benni Mack updated the commit message in patch set 4 CR -1 V -1 10/18/24, 13:29

  9. core-ci voted on patch set 4 V -1 10/18/24, 20:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67973

  10. Benni Mack rebased onto patch set 5 V -1 03/25/25, 20:31

  11. core-ci voted on patch set 5 V -1 03/25/25, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76310

  12. Benni Mack wrote 03/28/25, 08:26

    Hashtag added: lolli-feedback
  13. Benni Mack uploaded patch set 6 V -1 04/11/25, 09:17

  14. core-ci voted on patch set 6 V +1 04/11/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77510

  15. Benni Mack updated the commit message in patch set 7 V +1 04/12/25, 07:17

  16. core-ci voted on patch set 7 V +1 04/12/25, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77609

  17. Benni Mack updated the commit message in patch set 8 V +1 04/22/26, 06:55

  18. core-ci voted on patch set 8 V -1 04/22/26, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100835

  19. Christian Kuhn wrote 06/18/26, 23:06

    Removed reviewer Christian Kuhn.
  20. Benni Mack uploaded patch set 9 V -1 11/09/26, 11:40

  21. Benni Mack wrote 11/09/26, 11:40

    Hashtag removed: lolli-feedback
  22. core-ci voted on patch set 9 V +1 11/09/26, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113662

  23. Benni Mack uploaded patch set 10 V +1 11/09/26, 11:56

  24. core-ci voted on patch set 10 V +1 11/09/26, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113664