97528[BUGFIX] Keep live uids in relations of new versions
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/28/97528/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/28/97528/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 25
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 97560[TASK] Find subpages with one query when copying and deleting pages
- main 97665[BUGFIX] Respect columnsOverrides when remapping copied inline records
- main 97603[TASK] Introduce RecordTypeResolver and deprecate getTCAtypeValue()
- main 92705[BUGFIX] Only offer translations of records the user may localize
- main 93752[BUGFIX] Skip translations when pasting into another language
- main 93819[WIP][BUGFIX] Guard translated tt_content free-mode moves
- main 97376[BUGFIX] Do not re-localize references already in the target language
- main 83460[BUGFIX] Respect parent language uid in new FlexForm inline relations
- main 94753[FEATURE] New TCA type "coordinate"
- main 95105[TASK] Apply PHP code simplifications
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 74781[FEATURE] Introduce new slug builders for records and string
- main 96829[!!!][BUGFIX] Restore deleted records by their deletion operation
- main 92859[WIP][BUGFIX] Make MM tables language-aware and workspace-aware
- main 96344[BUGFIX] Keep live and foreign MM rows when creating a version
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 95343[FEATURE] Add `adminOnly` for TCA columns
- main 95638[TASK] Extend FieldValidationService to more TCA field types
- main 95639[TASK] Extract a read-only UniquenessChecker from DataHandler
- main 95637[TASK] Introduce FieldValidationService for TCA field validation
- main 93407[TASK] Modernize `RecordHistoryStore`
- main 92214[TASK] Introduce generic permission sets for accessing data
- main 85574[WIP][FEATURE] Language-aware slugs and slug normalizer API
- main 87719[WIP][BUGFIX] Mitigate missing column in cached schema information
Issues 3
Files 8
- typo3/sysext/core/Classes/DataHandling/DataHandler.php6+33 −8
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/WorkspacesModify/ActionTest.php+12 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/WorkspacesPublish/ActionTest.php+13 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/AbstractActionWorkspacesTestCase.php+12 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesModify/ActionTest.php+21 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesPublish/ActionTest.php+27 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/AbstractActionWorkspacesTestCase.php+27 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_flex/Configuration/TCA/tx_testflex.php+7 −0
Review log 57
-
Oli Bartsch uploaded patch set 1 11/10/26, 22:49
-
core-ci voted on patch set 1 V +1 11/10/26, 23:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113995
-
Oliver Klee voted on patch set 1 V +1 11/11/26, 08:40
-
Benni Mack commented on patch set 1 11/12/26, 20:57
DataHandler.php:6816Could you put $this->BE_USER->workspace > 0 && in front? Live copies can't produce versions, and this saves one SELECT per copied record with relation fields.DataHandler.php:6849The flex branch still calls remapListedDBRecords_procDBRefs() without the flag, so a group or select field inside a FlexForm on a version is still remapped. Please pass $remapCopiedUids through there as well. -
Oli Bartsch uploaded patch set 2
V +111/14/26, 16:08 -
Oli Bartsch commented on patch set 2 11/14/26, 16:11
DataHandler.php:6814ReplyKept on purpose until 96331. Without it a lot of workspace tests fail, exactly the CSVs 96331 rewrites. Comment reworded and Related: #106915 added. Whichever lands second drops/keeps the exception.DataHandler.php:6816ReplyReplaced the lookup entirely. copyRecord_raw() marks the version uid when versionizeRecord() passes t3ver_oid, remapListedDBRecords() checks that marker.DataHandler.php:6849ReplyDone -
core-ci voted on patch set 2 V +1 11/14/26, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114465
DataHandler.php:6814