Review main Ready for review

97652[BUGFIX] Prevent moving pages inside themselves in workspaces

Oli Bartsch CR 0 V 0 Normal +98 −1 updated 11/14/26, 16:14

Commit message

In a workspace, DataHandler::moveRecord() checked the destination
rootline with the uid of the workspace version of the moved page.
destNotInsideSelf() compares that uid with the destination and the
workspace-overlaid pids of its rootline. Those are always live uids,
or uids of new workspace pages, so the check never matched. A page
could be moved into itself, creating a move pointer with pid equal
to t3ver_oid, or below one of its own subpages. This led to cyclic
rootlines and a corrupt page tree after publishing.

The rootline check now uses the live uid of the moved page, falling
back to the workspace record uid for pages that are new in the
workspace.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/97652/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/97652/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 22

Issues 1

Files 3

Review log 12

  1. Oli Bartsch uploaded patch set 1 11/14/26, 16:02

  2. core-ci voted on patch set 1 V +1 11/14/26, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114462