92705[BUGFIX] Only offer translations of records the user may localize
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/05/92705/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/05/92705/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 48
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 81616[BUGFIX] Hide visibility toggle of synchronized translation fields
- main 97560[TASK] Find subpages with one query when copying and deleting pages
- main 95173[BUGFIX] Only offer actions on records the user may perform
- main 97528[BUGFIX] Keep live uids in relations of new versions
- main 97652[BUGFIX] Prevent moving pages inside themselves in workspaces
- main 97616[BUGFIX] Count references and translations per pid in the backend
- main 97603[TASK] Introduce RecordTypeResolver and deprecate getTCAtypeValue()
- main 93063[TASK] Show warnings on orphaned translations
- main 93819[WIP][BUGFIX] Guard translated tt_content free-mode moves
- main 95741[BUGFIX] Offer localization only where it is permitted
- main 84892[TASK] Merge Permissions and Backend Users modules
- main 95488[BUGFIX] Warn about endtime before starttime
- main 96341[BUGFIX] Validation of TCA column type "color"
- main 92191[WIP][TASK] Migrate PageTree to Action API
- main 96978[FEATURE] Distinct actions for checkbox and dropdown
- main 94753[FEATURE] New TCA type "coordinate"
- main 97164[BUGFIX] Ask for required fields when translating a page
- main 95105[TASK] Apply PHP code simplifications
- main 91093[BUGFIX] Add accessible relation between dropdown and its toggle
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 74781[FEATURE] Introduce new slug builders for records and string
- main 96319[FEATURE] Undo operations from their notification
- main 96829[!!!][BUGFIX] Restore deleted records by their deletion operation
- main 87873[WIP][BUGFIX] Make Dropdown Toggle Buttons more accessible
- main 94879[BUGFIX] Reference translated records when localizing relations
- main 92859[WIP][BUGFIX] Make MM tables language-aware and workspace-aware
- main 96344[BUGFIX] Keep live and foreign MM rows when creating a version
- main 96230[BUGFIX] Show records of all languages on root level in Records module
- main 75020[FEATURE] Allow excluding tables from page copy
- main 96113[WIP][BUGFIX] Honor record web mount exemptions
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 95343[FEATURE] Add `adminOnly` for TCA columns
- main 95638[TASK] Extend FieldValidationService to more TCA field types
- main 95639[TASK] Extract a read-only UniquenessChecker from DataHandler
- main 95637[TASK] Introduce FieldValidationService for TCA field validation
- main 92589[TASK] Replace unneeded instanceof on xxx|null. Use a null check instead
- main 95043[WIP][BUGFIX] Hide connected mode for free mode translation sources
- main 95453[WIP][TASK] Use ajax to load the delete message
- main 95308[TASK] Deprecate QueryBuilder::castFieldToTextType()
- main 94653[WIP] Record Identity
- main 93407[TASK] Modernize `RecordHistoryStore`
- main 92214[TASK] Introduce generic permission sets for accessing data
- main 91414[TASK] Generalize component conversion of button to dropdown item
- main 85574[WIP][FEATURE] Language-aware slugs and slug normalizer API
- main 87719[WIP][BUGFIX] Mitigate missing column in cached schema information
- main 80762[WIP] Cleanup RecordList
- main 86432[WIP][TASK] Cache flexform schema during TCA schema creation
Issues 1
Files 13
- typo3/sysext/backend/Classes/Controller/Wizard/LocalizationController.php+7 −2
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+14 −1
- typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php2+6 −1
- typo3/sysext/backend/Tests/Functional/Controller/Wizard/LocalizationControllerTest.php+108 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/localization_permissions.csvnew+19 −0
- typo3/sysext/backend/Tests/Functional/RecordList/DatabaseRecordListTest.php+107 −0
- typo3/sysext/backend/Tests/Functional/View/BackendLayout/ContentFetcherTest.phpnew+176 −0
- typo3/sysext/core/Classes/DataHandling/Localization/LocalizationAccessChecker.php1new+109 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php1+7 −58
- typo3/sysext/core/Classes/DataHandling/PagePermissionChecker.phpnew+100 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Localization/Fixtures/be_users.csvnew+7 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Localization/LocalizationAccessCheckerTest.phpnew+80 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+12 −0
Review log 1828
Show 23 earlier messages
-
Juliane Wundermann uploaded patch set 1 02/06/26, 10:26
-
Simon Schaufelberger commented on patch set 1 02/06/26, 10:35
only checked code styleContentFetcher.php:189this empty line can be removed -
core-ci voted on patch set 1 V +1 02/06/26, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95261
-
Matthias Vogel voted on patch set 1 CR +1 V +1 02/06/26, 10:39
-
Juliane Wundermann uploaded patch set 2
CR +1V +102/06/26, 10:42 -
Juliane Wundermann commented on patch set 2 02/06/26, 10:43
ContentFetcher.php:189ReplyDone -
core-ci voted on patch set 2 V +1 02/06/26, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95264
-
Matthias Vogel voted on patch set 2 CR +1 V +1 02/06/26, 12:34
-
Marno Schmigotzki voted on patch set 2 CR +1 V +1 02/06/26, 13:05
-
Oli Bartsch uploaded patch set 3
CR +1V +102/06/26, 13:10 -
Oli Bartsch commented on patch set 3 V -1 02/06/26, 13:19
BackendLayoutView.php:278This at least misses proper page permissions. We should try to centralize this to be sure we cover all necessary configuration options. -
Matthias Vogel voted on patch set 3 CR +1 V +1 02/06/26, 13:19
-
core-ci voted on patch set 3 V -1 02/06/26, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95291
-
core-ci voted on patch set 3 V +1 02/06/26, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95291
-
Benni Mack updated the commit message in patch set 4
CR +1V +104/22/26, 07:15 -
core-ci voted on patch set 4 V -1 04/22/26, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100851
-
Benni Mack uploaded patch set 5
V -111/11/26, 10:44 -
core-ci voted on patch set 5 V +1 11/11/26, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114056
-
Benni Mack uploaded patch set 6
V +111/11/26, 14:14 -
core-ci voted on patch set 6 V -1 11/11/26, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114094
-
Benni Mack commented on patch set 6 11/11/26, 15:18
BackendLayoutView.php:278ReplyDone -
Benni Mack uploaded patch set 7
V -111/12/26, 19:00 -
core-ci voted on patch set 7 V +1 11/12/26, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114211
-
Benni Mack uploaded patch set 8
V +111/12/26, 20:04 -
core-ci voted on patch set 8 V +1 11/12/26, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114218
-
Oli Bartsch commented on patch set 8 11/12/26, 21:22
BackendLayoutView.php:278Reply UnresolvedIMO the page permission part is not resolved yet. The checker just uses a Permission passed in by the caller. Please check my comment in the file.DataHandler.php:4975Unresolvedresult of `hasPageContextPermission()` is mapped to `CONTENT_EDIT` / `NOTHING` just to fit the checker signature, so the bitmask doesn't reflect what was actually checked. This should go away once the checker computes the page permission itself.LocalizationAccessChecker.php:94UnresolvedWe trust the passed `Permission`, while callers compute it differently. `DataHandler` uses `hasPageContextPermission()`, which has `pages.editlock`. `ContentFetcher`, `LocalizationController` and `DatabaseRecordList` use `calcPerms()`, which ignores it. With `editlock=1` and `CONTENT_EDIT` granted, the translate button, wizard list and Records panel still offer records, but `DataHandler` then refuses with "Missing permission to edit content". Please let the checker work out the page permission itself from the page row (webmount, perms bits, editlock), for example by moving the `hasPageContextPermission()` logic into a core service. Callers would then pass the page row, plus the required permission for the `sys_file_reference`/`PAGE_EDIT` case. -
Benni Mack uploaded patch set 9
V +111/12/26, 21:59 -
core-ci voted on patch set 9 V +1 11/12/26, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114250