Review main Ready for review Quiet

96544[BUGFIX] Write page cache entry before releasing the page lock

Wolfgang Klinger CR 0 V 0 Normal +210 −1 updated 10/09/26, 12:49

Commit message

The page cache entry was written by an outer middleware after
PrepareTypoScriptFrontendRendering had already released the
"pages" lock. Requests waiting for the lock often found no cache
entry and rendered the page again, one after another.

The middleware now writes the queued cache entries before it
releases the lock.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/44/96544/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/44/96544/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 24

Issues 1

Files 9

Review log 36

  1. Wolfgang Klinger uploaded patch set 1 10/09/26, 05:15

  2. Wolfgang Klinger updated the commit message in patch set 2 10/09/26, 05:16

  3. core-ci voted on patch set 2 V -1 10/09/26, 05:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110549

  4. core-ci voted on patch set 1 V -1 10/09/26, 05:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110548

  5. Wolfgang Klinger rebased onto patch set 3 V -1 10/09/26, 12:41

  6. core-ci voted on patch set 3 V +1 10/09/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110602