Review main Work in progress Quiet

92356[FEATURE] More intuitive selection for translation parent field

Benni Mack CR 0 V -1 Expert +1591 −0 updated 10/23/26, 12:44

Commit message

The translation parent field (l10n_parent) now uses a modal browser
instead of a dropdown select when editing translated records.

The new interface displays the currently selected parent record with its
title and icon, and provides a button to open a modal browser for
selecting a different parent.

The modal browser shows only eligible parent records:
- Records in the default language
- Records not already used as translation parent by another
  record of the same target language

In addition, we get:
- Search functionality to filter records
- Pagination for large result sets
- "Disconnect" option to remove the translation parent
- Visual diff display when the selection changes

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/56/92356/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/56/92356/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 25

Issues 1

Files 13

Review log 1013

  1. Benni Mack uploaded patch set 1 01/16/26, 21:13

  2. Benni Mack marked it work in progress 01/16/26, 21:13

  3. core-ci voted on patch set 1 V -1 01/16/26, 21:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93635

  4. Benni Mack commented on patch set 2 V -1 01/18/26, 08:28

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V +1 01/18/26, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93711

  6. Garvin Hicking commented on patch set 2 01/23/26, 21:22

    TranslationParentElement.php:39

    @internal ?

    TranslationParentBrowser.php:27

    @internal ?

    TcaTranslationParent.php:29

    @internal?

    TranslationParent.html:1

    Use .fluid.html

    Feature-76300-TranslationParentFieldBrowserModal.rst:2

    Move to 14.2
  7. Garvin Hicking commented on patch set 2 01/24/26, 22:05

    generally works for me! 😊 - sorting and "show columns" in the popup does not yet work - when a `<em>no title</em>` record is selected, this HTML markup is shown in the parent input field next to the link (and not formatted or stripped). Also I would maybe make that input text field "readonly" so that it does not look as if I could edit the text in that field

    Feature-76300-TranslationParentFieldBrowserModal.rst:27

    4 space indentation needed for these (like in "Impact")
  8. Markus Klein commented on patch set 2 01/25/26, 12:32

    I like this feature
  9. Simon Schaufelberger commented on patch set 2 02/04/26, 16:59

    On it

    translation-parent-element.ts:46 Unresolved

    @benni@typo3.org I noticed that only the hidden field is updated but the actual visible field is not. I would expect at least a color change to blue. I had a look at what link browser does but that component is extremely complex to understand but the usecase would be the same.

    TranslationParentElement.php:39 Reply

    Done

    TranslationParentBrowser.php:27 Reply

    Done

    TcaTranslationParent.php:29 Reply

    Done

    TranslationParent.html:1 Reply

    Done

    Feature-76300-TranslationParentFieldBrowserModal.rst:2 Reply

    Done

    Feature-76300-TranslationParentFieldBrowserModal.rst:27 Reply

    Done
  10. Benni Mack commented on patch set 2 10/02/26, 15:41

    Reply

    any updates on this?
  11. Simon Schaufelberger commented on patch set 2 10/02/26, 16:25

    Reply Unresolved

    I try to rebase and then we will see. I added also a comment for you already.
  12. Simon Schaufelberger uploaded patch set 3 V +1 10/02/26, 22:07

  13. core-ci voted on patch set 3 V -1 10/02/26, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110005