92356[FEATURE] More intuitive selection for translation parent field
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/56/92356/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/56/92356/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Merge conflicts 25
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 94552[WIP][FEATURE] Passwordless passkey login for the backend
- main 97556[FEATURE] Store remote media preview images as processed files
- main 97554[FEATURE] Introduce remote media providers
- main 84995[FEATURE] Allow assigning users to groups in group editor
- main 93628[WIP][TASK] Make GD the baseline image processor
- main 94753[FEATURE] New TCA type "coordinate"
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 95125[FEATURE] Support non-PHP cache backends for the site settings cache
- main 95343[FEATURE] Add `adminOnly` for TCA columns
- main 84603[TASK] Change typoscript from code to a data cache
- main 80187[!!!][TASK] Use php cache frontend for ClassSchema cache entries
- main 94508[WIP][FEATURE] Provide button to remove all inline relations
- main 94207[FEATURE] Explicit access declaration for backend routes
- main 91423[WIP][TASK] Move config values to both section columns and config
- main 70840[WIP][FEATURE] Add possibility to add HTTP headers in frontend
- main 80554[TASK] Prefer CSP hash values over nonce values
- main 92959[WIP][TASK] Use ICU message format for pluralization
- main 90107[FEATURE] Introduce database-only storage for OnlineMedia files
- main 92177[!!!][FEATURE] Autoconfigure backend FormEngine node types
- main 92180[!!!][TASK] Decouple registration of FormEngine nodes from NodeFactory
- main 91404[!!!][TASK] Remove re-login password popup functionality
- main 91411[WIP][FEATURE] Add support for HEIC and HEIF image formats
- main 85574[WIP][FEATURE] Language-aware slugs and slug normalizer API
- main 79622[WIP][FEATURE] Introduce video and audio file lists
Issues 1
Files 13
- Build/Sources/TypeScript/backend/form-engine/element/translation-parent-element.ts1new+261 −0
- typo3/sysext/backend/Classes/ElementBrowser/TranslationParentBrowser.phpnew+287 −0
- typo3/sysext/backend/Classes/Form/Element/TranslationParentElement.php2new+239 −0
- typo3/sysext/backend/Classes/Form/FieldControl/TranslationParentBrowser.php2new+91 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaTranslationParent.php2new+72 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+2 −0
- typo3/sysext/backend/Classes/RecordList/TranslationParentRecordList.phpnew+226 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_alt_doc.xlf+30 −0
- typo3/sysext/backend/Resources/Private/Templates/ElementBrowser/TranslationParent.html2new+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/translation-parent-element.jsnew+28 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaTranslationParentTest.phpnew+285 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+6 −0
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-76300-TranslationParentFieldBrowserModal.rst4new+51 −0
Review log 1013
-
Benni Mack uploaded patch set 1 01/16/26, 21:13
-
Benni Mack marked it work in progress 01/16/26, 21:13
-
core-ci voted on patch set 1 V -1 01/16/26, 21:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93635
-
Benni Mack commented on patch set 2
V -101/18/26, 08:28Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 01/18/26, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93711
-
Garvin Hicking commented on patch set 2 01/23/26, 21:22
TranslationParentElement.php:39@internal ?TranslationParentBrowser.php:27@internal ?TcaTranslationParent.php:29@internal?TranslationParent.html:1Use .fluid.htmlFeature-76300-TranslationParentFieldBrowserModal.rst:2Move to 14.2 -
Garvin Hicking commented on patch set 2 01/24/26, 22:05
generally works for me! 😊 - sorting and "show columns" in the popup does not yet work - when a `<em>no title</em>` record is selected, this HTML markup is shown in the parent input field next to the link (and not formatted or stripped). Also I would maybe make that input text field "readonly" so that it does not look as if I could edit the text in that fieldFeature-76300-TranslationParentFieldBrowserModal.rst:274 space indentation needed for these (like in "Impact") -
Markus Klein commented on patch set 2 01/25/26, 12:32
I like this feature -
Simon Schaufelberger commented on patch set 2 02/04/26, 16:59
On ittranslation-parent-element.ts:46Unresolved@benni@typo3.org I noticed that only the hidden field is updated but the actual visible field is not. I would expect at least a color change to blue. I had a look at what link browser does but that component is extremely complex to understand but the usecase would be the same.TranslationParentElement.php:39ReplyDoneTranslationParentBrowser.php:27ReplyDoneTcaTranslationParent.php:29ReplyDoneTranslationParent.html:1ReplyDoneFeature-76300-TranslationParentFieldBrowserModal.rst:2ReplyDoneFeature-76300-TranslationParentFieldBrowserModal.rst:27ReplyDone -
Benni Mack commented on patch set 2 10/02/26, 15:41
Reply
any updates on this? -
Simon Schaufelberger commented on patch set 2 10/02/26, 16:25
Reply Unresolved
I try to rebase and then we will see. I added also a comment for you already. -
Simon Schaufelberger uploaded patch set 3
V +110/02/26, 22:07 -
core-ci voted on patch set 3 V -1 10/02/26, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110005