97630[!!!][FEATURE] Support dependency injection for routing aspects
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/30/97630/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/30/97630/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 30
- main 94552[WIP][FEATURE] Passwordless passkey login for the backend
- main 97554[FEATURE] Introduce remote media providers
- main 94827[!!!][FEATURE] Log writers support dependency injection
- main 91666[TASK] Provide OpenAPI spec w/ Swagger UI for Actions API
- main 91563[FEATURE] Introduce Action API
- main 92197[WIP][FEATURE] Provide Record Actions
- main 91486[FEATURE] Implement API Hub
- main 94753[FEATURE] New TCA type "coordinate"
- main 95105[TASK] Apply PHP code simplifications
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 96660[TASK] Derive argument schemas from signatures
- main 96661[TASK] Add capability invoker and registry
- main 96682[FEATURE] Add MCP system extension and endpoint
- main 94709[BUGFIX] Fix sending spooled emails using HttpTransport
- main 96533[WIP][!!!][TASK] Build Extbase persistence on doctrine/orm
- main 96201[FEATURE] Introduce upload constraints for file uploads
- main 95723[!!!][TASK] Make VisibilityAspect constructor private
- main 95637[TASK] Introduce FieldValidationService for TCA field validation
- main 88507[WIP][FEATURE] AI suggest demo using tools API
- main 95337[WIP][TASK] Evaluate phpunit parallel test execution
- main 94945[WIP][TASK] Test testing-framework context leak fix
- main 92249[!!!][TASK] Move content elements to EXT:fluid_styled_content
- main 94029[FEATURE] Add secrets store and key management
- main 92349[TASK] Replace deprecated usage for custom phpstan rule and add tests
- main 91936[POC][FEATURE] Extbase Route Annotations
- main 92068[WIP][TASK] Avoid Symfony v8 for transitive Symfony dependencies
- main 83623[WIP][FEATURE] Introduce System Settings API & Editor
- main 85574[WIP][FEATURE] Language-aware slugs and slug normalizer API
- main 76662[FEATURE] Introduce global routes
- main 88232[WIP][TASK] fixture-packages composer plugin
Issues 1
Files 32
- typo3/sysext/core/Classes/Routing/Aspect/AspectFactory.php+15 −0
- typo3/sysext/core/Classes/Routing/Aspect/LocaleModifier.php+3 −5
- typo3/sysext/core/Classes/Routing/Aspect/PersistedAliasMapper.php+14 −4
- typo3/sysext/core/Classes/Routing/Aspect/PersistedPatternMapper.php+14 −4
- typo3/sysext/core/Classes/Routing/Aspect/StaticRangeMapper.php+4 −5
- typo3/sysext/core/Classes/Routing/Aspect/StaticValueMapper.php+3 −5
- typo3/sysext/core/Classes/Routing/Enhancer/EnhancerFactory.php+16 −3
- typo3/sysext/core/Classes/Routing/Enhancer/PageTypeDecorator.php+3 −2
- typo3/sysext/core/Classes/Routing/Enhancer/PluginEnhancer.php+3 −2
- typo3/sysext/core/Classes/Routing/Enhancer/SimpleEnhancer.php+3 −2
- typo3/sysext/core/Classes/Routing/SettingsAwareInterface.phpnew+30 −0
- typo3/sysext/core/Configuration/Services.php+4 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-97150-CoreRoutingAspectsAndEnhancersUseDependencyInjection.rstnew+101 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Deprecation-97150-RoutingAspectsAndEnhancersWithSettingsAsConstructorArgument.rst2new+77 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_routing_di/Classes/Aspect/DependencyInjectedAspect.phpnew+44 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_routing_di/Classes/Aspect/LegacyAspect.phpnew+35 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_routing_di/Classes/Enhancer/DependencyInjectedEnhancer.phpnew+39 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_routing_di/Classes/Enhancer/LegacyEnhancer.phpnew+30 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_routing_di/Classes/Service/SlugFormatter.phpnew+26 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_routing_di/Configuration/Services.yamlnew+8 −0
Show 12 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_routing_di/composer.jsonnew+23 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_routing_di/ext_localconf.phpnew+15 −0
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+10 −5
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+10 −5
- typo3/sysext/core/Tests/Functional/Routing/RoutingFactoryDependencyInjectionTest.phpnew+83 −0
- typo3/sysext/core/Tests/Unit/Routing/Aspect/AspectFactoryTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Routing/Enhancer/PluginEnhancerTest.php+12 −6
- typo3/sysext/core/Tests/Unit/Routing/Enhancer/SimpleEnhancerTest.php+10 −5
- typo3/sysext/extbase/Classes/Routing/ExtbasePluginEnhancer.php+3 −4
- typo3/sysext/extbase/Tests/Unit/Routing/Aspect/StaticRangeMapperTest.php+2 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/PersistedAliasMapperLanguageFallbackTest.php+2 −1
- composer.json+1 −0
Review log 34
-
Benni Mack uploaded patch set 1 11/13/26, 19:43
-
core-ci voted on patch set 1 V +1 11/13/26, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114386
-
Chris Müller commented on patch set 1 11/14/26, 08:12
-
Chris Müller commented on patch set 1 11/14/26, 08:19
Deprecation-97150-RoutingAspectsAndEnhancersWithSettingsAsConstructorArgument.rst:67ReplyToo early in the morning, ignore this... :-(
Deprecation-97150-RoutingAspectsAndEnhancersWithSettingsAsConstructorArgument.rst:67