Review main Ready for review

81616[BUGFIX] Hide visibility toggle of synchronized translation fields

Ayke Halder CR 0 V 0 Hard +447 −2 updated 11/19/26, 14:08

Commit message

DataHandler ignores a new value for the disabled field of a translation
when the field has l10n_mode=exclude, or uses
allowLanguageSynchronization in a state other than "custom". The page
module, the record list and the context menu now hide the toggle in
exactly these cases, using one check that mirrors what DataMapProcessor
removes from a data map. The record list selects l10n_state to decide
this.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 9
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/16/81616/9 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/16/81616/9 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 22

Issues 1

Files 10

Review log 1625

  1. Ayke Halder uploaded patch set 1 10/30/23, 16:19

  2. core-ci voted on patch set 1 V -1 10/30/23, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48364

  3. Ayke Halder uploaded patch set 2 V -1 10/30/23, 22:56

  4. core-ci voted on patch set 2 V +1 10/30/23, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48372

  5. Ayke Halder uploaded patch set 3 V +1 05/13/24, 10:21

  6. core-ci voted on patch set 3 V +1 05/13/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57607

  7. Benni Mack commented on patch set 3 05/14/24, 11:59

    What about the context menu icons?
  8. Ayke Halder uploaded patch set 4 V +1 05/15/24, 16:25

  9. core-ci voted on patch set 4 V -1 05/15/24, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57780

  10. Ayke Halder uploaded patch set 5 05/15/24, 16:38

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  11. core-ci voted on patch set 5 V -1 05/15/24, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57781

  12. Ayke Halder uploaded patch set 6 V -1 05/16/24, 12:56

  13. core-ci voted on patch set 6 V +1 05/16/24, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57829

  14. Ayke Halder commented on patch set 6 05/16/24, 13:09

    Reply

    Done.
    All those same checks for record editable etc. are implemented for 3 times: * TYPO3\CMS\Backend\View\BackendLayout\Grid\GridColumnItem * TYPO3\CMS\Backend\RecordList\DatabaseRecordList * TYPO3\CMS\Backend\ContextMenu\ItemProviders\RecordProvider Will need some big refactoring in future.
  15. Christian Rath-Ulrich voted on patch set 6 CR +1 V +1 07/17/24, 15:25

  16. Benni Mack updated the commit message in patch set 7 CR +1 V +1 10/18/24, 13:38

  17. core-ci voted on patch set 7 V -1 10/18/24, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68013

  18. Oli Bartsch commented on patch set 7 V -1 11/15/24, 20:44

    This in general is a really good improvement. The patch however currently does not respect context specific configuration, such as `columnsOverrides`. Also settings, which influencing the localization behaviour, e.g. `allowLanguageSynchronization` should be evaluated.
  19. Benni Mack wrote 04/21/26, 14:55

    Removed cc Benni Mack.
  20. Benni Mack marked it work in progress 04/21/26, 14:55

  21. Benni Mack uploaded patch set 8 V -1 11/19/26, 13:27

  22. Benni Mack commented on patch set 8 11/19/26, 13:29

    This change is ready for review.

    Reply

    Done in PS8: allowLanguageSynchronization is evaluated via l10n_state – the toggle is hidden unless the field is in "custom" state. Setting allowLanguageSynchronization via columnsOverrides is removed by the TCA migration, so there is no type-specific variant to consider.
    Rebased the change onto current main, which needed a rewrite: the three places had moved to the Schema API in the meantime. - The check now lives in one place, SynchronizedTranslationField (core, @internal), used by the context menu, the record list and the page module. - Besides l10n_mode=exclude it also covers allowLanguageSynchronization with an l10n_state other than "custom" – DataHandler drops the value in that case too. The record list now selects l10n_state for this. - Functional tests for all three places, plus one that holds the check against what DataHandler actually stores. Ayke, I hope that's fine with you – happy to adjust if you see it differently.
  23. core-ci voted on patch set 8 V -1 11/19/26, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115010

  24. Benni Mack uploaded patch set 9 V -1 11/19/26, 13:54

  25. core-ci voted on patch set 9 V +1 11/19/26, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115013