81616[BUGFIX] Hide visibility toggle of synchronized translation fields
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/16/81616/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/16/81616/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 22
- main 97552[TASK] Restrict queries to a page tree without a list of page ids
- main 96331[BUGFIX] Point localized workspace records to live records
- main 95475[WIP][FEATURE] Show all-language content in language comparison
- main 96531[BUGFIX] Show versioned MM relations in backend record views
- main 97616[BUGFIX] Count references and translations per pid in the backend
- main 92705[BUGFIX] Only offer translations of records the user may localize
- main 95741[BUGFIX] Offer localization only where it is permitted
- main 84892[TASK] Merge Permissions and Backend Users modules
- main 96978[FEATURE] Distinct actions for checkbox and dropdown
- main 95105[TASK] Apply PHP code simplifications
- main 91093[BUGFIX] Add accessible relation between dropdown and its toggle
- main 96319[FEATURE] Undo operations from their notification
- main 87873[WIP][BUGFIX] Make Dropdown Toggle Buttons more accessible
- main 96230[BUGFIX] Show records of all languages on root level in Records module
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 92589[TASK] Replace unneeded instanceof on xxx|null. Use a null check instead
- main 95453[WIP][TASK] Use ajax to load the delete message
- main 95308[TASK] Deprecate QueryBuilder::castFieldToTextType()
- main 94653[WIP] Record Identity
- main 93528[WIP][TASK] Add new ce wrapper to contain element behavior
- main 91414[TASK] Generalize component conversion of button to dropdown item
- main 80762[WIP] Cleanup RecordList
Issues 1
Files 10
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php+4 −0
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+13 −2
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+2 −0
- typo3/sysext/backend/Tests/Functional/ContextMenu/ItemProviders/Fixtures/TranslatedContent.csvnew+7 −0
- typo3/sysext/backend/Tests/Functional/ContextMenu/ItemProviders/RecordProviderTest.phpnew+103 −0
- typo3/sysext/backend/Tests/Functional/RecordList/DatabaseRecordListTest.php+73 −0
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererLanguageComparisonTest.php+34 −0
- typo3/sysext/core/Classes/DataHandling/Localization/SynchronizedTranslationField.phpnew+54 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Localization/Fixtures/TranslatedContent.csvnew+7 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Localization/SynchronizedTranslationFieldTest.phpnew+150 −0
Review log 1625
-
Ayke Halder uploaded patch set 1 10/30/23, 16:19
-
core-ci voted on patch set 1 V -1 10/30/23, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48364
-
Ayke Halder uploaded patch set 2
V -110/30/23, 22:56 -
core-ci voted on patch set 2 V +1 10/30/23, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48372
-
Ayke Halder uploaded patch set 3
V +105/13/24, 10:21 -
core-ci voted on patch set 3 V +1 05/13/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57607
-
Benni Mack commented on patch set 3 05/14/24, 11:59
What about the context menu icons? -
Ayke Halder uploaded patch set 4
V +105/15/24, 16:25 -
core-ci voted on patch set 4 V -1 05/15/24, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57780
-
Ayke Halder uploaded patch set 5 05/15/24, 16:38
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 5 V -1 05/15/24, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57781
-
Ayke Halder uploaded patch set 6
V -105/16/24, 12:56 -
core-ci voted on patch set 6 V +1 05/16/24, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57829
-
Ayke Halder commented on patch set 6 05/16/24, 13:09
Reply
Done.All those same checks for record editable etc. are implemented for 3 times: * TYPO3\CMS\Backend\View\BackendLayout\Grid\GridColumnItem * TYPO3\CMS\Backend\RecordList\DatabaseRecordList * TYPO3\CMS\Backend\ContextMenu\ItemProviders\RecordProvider Will need some big refactoring in future. -
Christian Rath-Ulrich voted on patch set 6 CR +1 V +1 07/17/24, 15:25
-
Benni Mack updated the commit message in patch set 7
CR +1V +110/18/24, 13:38 -
core-ci voted on patch set 7 V -1 10/18/24, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68013
-
Oli Bartsch commented on patch set 7 V -1 11/15/24, 20:44
This in general is a really good improvement. The patch however currently does not respect context specific configuration, such as `columnsOverrides`. Also settings, which influencing the localization behaviour, e.g. `allowLanguageSynchronization` should be evaluated. -
Benni Mack wrote 04/21/26, 14:55
Removed cc Benni Mack. -
Benni Mack marked it work in progress 04/21/26, 14:55
-
Benni Mack uploaded patch set 8
V -111/19/26, 13:27 -
Benni Mack commented on patch set 8 11/19/26, 13:29
This change is ready for review.Reply
Done in PS8: allowLanguageSynchronization is evaluated via l10n_state – the toggle is hidden unless the field is in "custom" state. Setting allowLanguageSynchronization via columnsOverrides is removed by the TCA migration, so there is no type-specific variant to consider.Rebased the change onto current main, which needed a rewrite: the three places had moved to the Schema API in the meantime. - The check now lives in one place, SynchronizedTranslationField (core, @internal), used by the context menu, the record list and the page module. - Besides l10n_mode=exclude it also covers allowLanguageSynchronization with an l10n_state other than "custom" – DataHandler drops the value in that case too. The record list now selects l10n_state for this. - Functional tests for all three places, plus one that holds the check against what DataHandler actually stores. Ayke, I hope that's fine with you – happy to adjust if you see it differently. -
core-ci voted on patch set 8 V -1 11/19/26, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115010
-
Benni Mack uploaded patch set 9
V -111/19/26, 13:54 -
core-ci voted on patch set 9 V +1 11/19/26, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115013