Review main Ready for review

96531[BUGFIX] Show versioned MM relations in backend record views

Boris Stiner CR 0 V 0 Normal +90 −3 updated 11/16/26, 08:02

Commit message

The record list and the page module preview show a record modified in
a workspace with the uid of its live record. BackendUtility::
getProcessedValue() resolved MM relations with this uid, so the views
showed the relations of the live record instead of the workspace
version, or no relations at all.

getProcessedValue() now resolves MM relations with the uid of the
workspace version if the row passed as $fullRow carries one
(_ORIG_uid, or the computed versionedUid of a Record). Rows without a
workspace overlay, such as the live record in the workspaces "changes"
view, keep resolving their own relations.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 7
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/31/96531/7 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/31/96531/7 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 28

Issues 1

Files 7

Review log 1219

  1. Boris Stiner uploaded patch set 1 10/08/26, 10:59

  2. core-ci voted on patch set 1 V +1 10/08/26, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110483

  3. Boris Stiner uploaded patch set 2 V +1 10/08/26, 11:13

  4. core-ci voted on patch set 2 V +1 10/08/26, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110484

  5. Benni Mack commented on patch set 2 10/08/26, 19:28

    DatabaseRecordList.php:1314

    how about we fix this in getProcessedValueExtra()?
  6. Boris Stiner uploaded patch set 3 V +1 10/09/26, 06:29

  7. Boris Stiner commented on patch set 3 10/09/26, 06:31

    DatabaseRecordList.php:1314 Reply

    Good idea, thanks. In patch set 3 I moved the fix to BackendUtility::resolveRelationLabels(). It only applies to MM relations and looks up the record's workspace version there. This way the page module preview, element information and the CSV export also show the relations of the workspace version, not only the record list. The functional test is unchanged and still goes through the record list.
  8. core-ci voted on patch set 3 V -1 10/09/26, 06:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110552

  9. Boris Stiner uploaded patch set 4 V -1 10/12/26, 06:10

  10. core-ci voted on patch set 4 V +1 10/12/26, 06:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110887

  11. Benni Mack updated the commit message in patch set 5 V +1 10/12/26, 19:24

  12. core-ci voted on patch set 5 V +1 10/12/26, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110930

  13. Wouter Wolters voted on patch set 5 CR +1 10/14/26, 16:00

  14. Boris Stiner uploaded patch set 6 CR +1 V +1 11/03/26, 15:08

  15. core-ci voted on patch set 6 V +1 11/03/26, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113172

  16. Benni Mack commented on patch set 6 CR -1 11/09/26, 17:21

    The workspaces "changes" view no longer shows differences in MM fields
  17. Boris Stiner uploaded patch set 7 CR -1 V +1 11/16/26, 07:55

  18. Boris Stiner commented on patch set 7 11/16/26, 08:00

    Reply

    Thanks, you're right: the live side in the workspaces diff was resolved with the version uid as well. Fixed in PS7: the version uid is now only taken from an overlaid row passed as $fullRow (_ORIG_uid / computed versionedUid), so the workspaces diff resolves live and version relations separately again. Added a functional test for GridDataService::getRowDetails() covering this.
    PS7 addresses the workspaces diff issue, could you have another look?
  19. core-ci voted on patch set 7 V +1 11/16/26, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114595