96531[BUGFIX] Show versioned MM relations in backend record views
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 7
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/31/96531/7 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/31/96531/7 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 28
- main 81616[BUGFIX] Hide visibility toggle of synchronized translation fields
- main 97552[TASK] Restrict queries to a page tree without a list of page ids
- main 96331[BUGFIX] Point localized workspace records to live records
- main 97323[TASK] Check page access along the cached page ancestry
- main 96065[BUGFIX] Decode HTML entities in processed record values
- main 97603[TASK] Introduce RecordTypeResolver and deprecate getTCAtypeValue()
- main 95741[BUGFIX] Offer localization only where it is permitted
- main 84892[TASK] Merge Permissions and Backend Users modules
- main 96978[FEATURE] Distinct actions for checkbox and dropdown
- main 96525[!!!][TASK] Unify record title resolution
- main 94753[FEATURE] New TCA type "coordinate"
- main 95105[TASK] Apply PHP code simplifications
- main 91093[BUGFIX] Add accessible relation between dropdown and its toggle
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 74781[FEATURE] Introduce new slug builders for records and string
- main 96319[FEATURE] Undo operations from their notification
- main 87873[WIP][BUGFIX] Make Dropdown Toggle Buttons more accessible
- main 96230[BUGFIX] Show records of all languages on root level in Records module
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 82287[FEATURE] Introduce preview rendering for plugins
- main 92589[TASK] Replace unneeded instanceof on xxx|null. Use a null check instead
- main 95453[WIP][TASK] Use ajax to load the delete message
- main 95308[TASK] Deprecate QueryBuilder::castFieldToTextType()
- main 91189[WIP] Module Menu
- main 91715[WIP] Add configurable accent/tint color
- main 91414[TASK] Generalize component conversion of button to dropdown item
- main 81871[TASK] Cache results in BackendUtility::getRecordTitle
- main 80762[WIP] Cleanup RecordList
Issues 1
Files 7
- typo3/sysext/backend/Classes/Preview/RecordFieldPreviewProcessor.php+2 −2
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php2+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+8 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/tt_content_workspace_category_relations.csvnew+12 −0
- typo3/sysext/backend/Tests/Functional/RecordList/DatabaseRecordListTest.php+29 −0
- typo3/sysext/workspaces/Tests/Functional/Fixtures/GridData/tt_content-categories.csvnew+13 −0
- typo3/sysext/workspaces/Tests/Functional/Service/GridDataServiceTest.php+25 −0
Review log 1219
-
Boris Stiner uploaded patch set 1 10/08/26, 10:59
-
core-ci voted on patch set 1 V +1 10/08/26, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110483
-
Boris Stiner uploaded patch set 2
V +110/08/26, 11:13 -
core-ci voted on patch set 2 V +1 10/08/26, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110484
-
Benni Mack commented on patch set 2 10/08/26, 19:28
-
Boris Stiner uploaded patch set 3
V +110/09/26, 06:29 -
Boris Stiner commented on patch set 3 10/09/26, 06:31
DatabaseRecordList.php:1314ReplyGood idea, thanks. In patch set 3 I moved the fix to BackendUtility::resolveRelationLabels(). It only applies to MM relations and looks up the record's workspace version there. This way the page module preview, element information and the CSV export also show the relations of the workspace version, not only the record list. The functional test is unchanged and still goes through the record list. -
core-ci voted on patch set 3 V -1 10/09/26, 06:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110552
-
Boris Stiner uploaded patch set 4
V -110/12/26, 06:10 -
core-ci voted on patch set 4 V +1 10/12/26, 06:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110887
-
Benni Mack updated the commit message in patch set 5
V +110/12/26, 19:24 -
core-ci voted on patch set 5 V +1 10/12/26, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110930
-
Wouter Wolters voted on patch set 5 CR +1 10/14/26, 16:00
-
Boris Stiner uploaded patch set 6
CR +1V +111/03/26, 15:08 -
core-ci voted on patch set 6 V +1 11/03/26, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113172
-
Benni Mack commented on patch set 6 CR -1 11/09/26, 17:21
The workspaces "changes" view no longer shows differences in MM fields -
Boris Stiner uploaded patch set 7
CR -1V +111/16/26, 07:55 -
Boris Stiner commented on patch set 7 11/16/26, 08:00
Reply
Thanks, you're right: the live side in the workspaces diff was resolved with the version uid as well. Fixed in PS7: the version uid is now only taken from an overlaid row passed as $fullRow (_ORIG_uid / computed versionedUid), so the workspaces diff resolves live and version relations separately again. Added a functional test for GridDataService::getRowDetails() covering this.PS7 addresses the workspaces diff issue, could you have another look? -
core-ci voted on patch set 7 V +1 11/16/26, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114595
DatabaseRecordList.php:1314