Review main Work in progress Breaking

87422[WIP][!!!][TASK] Always ensure strict cHash validation

Benni Mack CR 0 V -1 Hard +108 −208 updated 11/09/26, 15:19

Commit message

In old TYPO3 versions, it was possible to add any GET
parameter to the frontend URL when no cHash was given.

This resulted in quirky URLs. For this reason the option
"enforceValidation" was added, to always
validate GET parameters (even without a cHash given in the URL).

If GET parameters should be ignored in the cHash calculation,
"excludedParameters" can still be used, all other parameters
are now validated.

This change now removes both options and assumes
that "enforceValidation" is always enabled.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 5
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/22/87422/5 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/22/87422/5 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 29

Issues 1

Files 29

Show 9 more files

Review log 914

  1. Benni Mack uploaded patch set 1 12/10/24, 17:41

  2. core-ci voted on patch set 1 V -1 12/10/24, 17:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70871

  3. Ayke Halder commented on patch set 1 12/11/24, 14:25

    Unresolved

    With this change implemented, it is still possible to use `excludedParameters` and exclude e.g. all these `utm_source/utm_medium/utm_campaign/utm_term/utm_content` parameters, isn't it?
  4. Benni Mack marked it work in progress 01/22/25, 11:50

  5. Benni Mack commented on patch set 1 02/19/25, 21:47

  6. Benni Mack rebased onto patch set 2 V -1 03/22/25, 20:40

  7. core-ci voted on patch set 2 V -1 03/22/25, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76046

  8. Benni Mack uploaded patch set 3 V -1 04/08/25, 19:00

  9. core-ci voted on patch set 3 V -1 04/08/25, 19:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77227

  10. Benni Mack rebased onto patch set 4 V -1 04/28/25, 19:45

  11. core-ci voted on patch set 4 V -1 04/28/25, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78297

  12. Sybille Peters commented on patch set 4 05/05/26, 07:28

    In the commit message it says in the last paragraph it removes both options. I assume enforceValidation and excludedParameters. But in third paragraph it says excludedParameters can still be used. That seems a bit ambiguous.
  13. Benni Mack uploaded patch set 5 V -1 11/09/26, 14:56

  14. core-ci voted on patch set 5 V -1 11/09/26, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113716