87422[WIP][!!!][TASK] Always ensure strict cHash validation
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/22/87422/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/22/87422/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Merge conflicts 29
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 95067[BUGFIX] Cache busting for images rendered by Fluid
- main 97556[FEATURE] Store remote media preview images as processed files
- main 84995[FEATURE] Allow assigning users to groups in group editor
- main 92188[TASK] Deprecate parts-as argument in f:link.typolink
- main 93628[WIP][TASK] Make GD the baseline image processor
- main 89993[TASK] Configure selectFields in RecordsXmlSitemapDataProvider
- main 94753[FEATURE] New TCA type "coordinate"
- main 95753[TASK] Cache resolved page routes
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 62956[WIP][TASK] Improves redirect performance with large redirects table
- main 95125[FEATURE] Support non-PHP cache backends for the site settings cache
- main 95172[FEATURE] Add EU AI content labelling to file metadata
- main 95343[FEATURE] Add `adminOnly` for TCA columns
- main 84603[TASK] Change typoscript from code to a data cache
- main 80187[!!!][TASK] Use php cache frontend for ClassSchema cache entries
- main 94207[FEATURE] Explicit access declaration for backend routes
- main 91423[WIP][TASK] Move config values to both section columns and config
- main 70840[WIP][FEATURE] Add possibility to add HTTP headers in frontend
- main 80554[TASK] Prefer CSP hash values over nonce values
- main 88541[BUGFIX] Invoke correct 404 / 403 error action
- main 90107[FEATURE] Introduce database-only storage for OnlineMedia files
- main 91404[!!!][TASK] Remove re-login password popup functionality
- main 91411[WIP][FEATURE] Add support for HEIC and HEIF image formats
- main 85574[WIP][FEATURE] Language-aware slugs and slug normalizer API
- main 77679[WIP][FEATURE] Introduce ModifyRedirectServiceUriFromCustomLinkDetailsEvent
- main 75180[WIP][TASK] Introduce URL QueryParams models
- main 82816[WIP][BUGFIX] Merge ViewHelper and LinkResult
- main 79622[WIP][FEATURE] Introduce video and audio file lists
Issues 1
Files 29
- typo3/sysext/core/Classes/Service/SilentConfigurationUpgradeService.php+4 −2
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −2
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+0 −6
- typo3/sysext/core/Configuration/FactoryConfiguration.php+0 −3
- typo3/sysext/core/Tests/Functional/Service/SilentConfigurationUpgradeServiceTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/View/TemplatesPathsTest.php+4 −5
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.php+5 −8
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/TypolinkViewHelperTest.php+5 −8
- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php+0 −25
- typo3/sysext/frontend/Classes/Page/CacheHashCalculator.php+1 −25
- typo3/sysext/frontend/Classes/Page/CacheHashConfiguration.php+0 −3
- typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php+14 −17
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/RouteTest.php+7 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+0 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestAllowInsecureSiteResolutionByQueryParametersDisabledTest.php+0 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestAllowInsecureSiteResolutionByQueryParametersEnabledTest.php+0 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+0 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteWithoutRequiredCHashRequestTest.php+1 −4
- typo3/sysext/frontend/Tests/Unit/Page/CacheHashCalculatorTest.php+0 −21
Show 9 more files
- typo3/sysext/frontend/Tests/Unit/Page/CacheHashConfigurationTest.php+0 −6
- typo3/sysext/frontend/Tests/Unit/Utility/CanonicalizationUtilityTest.php+0 −1
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+2 −4
- typo3/sysext/seo/Tests/Functional/XmlSitemap/AbstractXmlSitemapPagesTestCase.php+12 −5
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapExtensionDataProviderTest.php+6 −8
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesTest.php+0 −3
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesWithHideIfNotTranslatedTest.php+0 −3
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapRecordsTest.php+27 −28
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapXslTest.php+18 −10
Review log 914
-
Benni Mack uploaded patch set 1 12/10/24, 17:41
-
core-ci voted on patch set 1 V -1 12/10/24, 17:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70871
-
Ayke Halder commented on patch set 1 12/11/24, 14:25
-
Benni Mack marked it work in progress 01/22/25, 11:50
-
Benni Mack commented on patch set 1 02/19/25, 21:47
-
Benni Mack rebased onto patch set 2
V -103/22/25, 20:40 -
core-ci voted on patch set 2 V -1 03/22/25, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76046
-
Benni Mack uploaded patch set 3
V -104/08/25, 19:00 -
core-ci voted on patch set 3 V -1 04/08/25, 19:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77227
-
Benni Mack rebased onto patch set 4
V -104/28/25, 19:45 -
core-ci voted on patch set 4 V -1 04/28/25, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78297
-
Sybille Peters commented on patch set 4 05/05/26, 07:28
In the commit message it says in the last paragraph it removes both options. I assume enforceValidation and excludedParameters. But in third paragraph it says excludedParameters can still be used. That seems a bit ambiguous. -
Benni Mack uploaded patch set 5
V -111/09/26, 14:56 -
core-ci voted on patch set 5 V -1 11/09/26, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113716
Unresolved