92234[BUGFIX] Refine spacing of preview images
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/34/92234/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/34/92234/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Merge conflicts 30
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 97236[FEATURE] Compare every preview with the live page
- main 96718[WIP] Add device preview with zoom and pan to the preview module
- main 93628[WIP][TASK] Make GD the baseline image processor
- main 94668[WIP][TASK] Introduce shared result view for backend wizard finishers
- main 93597[WIP] Dispatch fields
- main 94653[WIP] Record Identity
- main 83317[BUGFIX] Make full area of CEs preview-text clickable
- main 90564[BUGFIX] Keep livesearches active items outline visible
- main 87811[BUGFIX] Make expand functionality recognizable in LiveSearch
- main 92725[BUGFIX] Show module sub-module line in firefox on close-open
- main 91409[WIP FEATURE] Introduce a Digital Asset Provider API in TYPO3 Core
- main 91189[WIP] Module Menu
- main 69092[WIP][TASK] Implement install tool layout boilerplate as web components
- main 93528[WIP][TASK] Add new ce wrapper to contain element behavior
- main 92973[POC][TASK] Style TYPO3 AI Assistant Chat Panel
- main 91769[WIP] OKLCH
- main 91710[WIP] dynamic colors: oklch
- main 91029[FEATURE] Introduce "High contrast" backend theme
- main 83623[WIP][FEATURE] Introduce System Settings API & Editor
- main 91142[TASK] Simplify page modules column header positioning
- main 83208[WIP][FEATURE] Introduce Creation Wizards
- main 82150[TASK] Convert fieldset legend to label for toggle checkboxes
- main 88260[TASK] Use native browser resizing for viewpage module
- main 78198[WIP][TASK] Introduce resource move in filelist
- main 78250[TASK] Add policy inspection & management to CSP backend module
- main 84782[TASK] Make live search pagination accessible by keyboard
- main 85496[FEATURE] Add mock dropzone to file-upload
- main 68199[WIP][TASK] Add <typo3-backend-module> element
- main 68730[WIP][TASK] Add <typo3-backend-button> component
Issues 2
Files 2
Review log 710
-
Ayke Halder uploaded patch set 1 12/30/25, 17:24
-
core-ci voted on patch set 1 V +1 12/30/25, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92812
-
Oliver Klee updated the commit message in patch set 2
V +112/30/25, 17:36 -
core-ci voted on patch set 2 V +1 12/30/25, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92813
-
Garvin Hicking commented on patch set 2 V -1 12/30/25, 18:33
I must say I prefer the padding; also this prevents cutting off edges of 1:1 images, I'd like to have full previews of my images. (Feel free to let my vote be overruled, not a blocking vote - I can see this is subjective) -
Ayke Halder commented on patch set 2 12/30/25, 19:20
Reply Unresolved
I'm also fine with the idea of full 1:1 images - I would completely remove the border-radius in that case. On the padding: I don't like it, as it takes space and it makes the view visually cluttered - there are already so many stacked paddings and lines in the view. If we like to keep the padding: Make the padding very small, make the gutter between "padded and bordered image elements" even smaller. -
Benni Mack updated the commit message in patch set 3
V +104/22/26, 06:38 -
core-ci voted on patch set 3 V -1 04/22/26, 07:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100743
-
Riccardo De Contardi commented on patch set 3 04/23/26, 08:26
I'd prefer - here and in Media module, to crop the images so they all fill the 64x64 thumbnail - this would make the preview much less messy. Maybe I'd avoid that in the list view of Media module -
Jasmina Ließmann wrote 06/22/26, 11:32
Removed cc Jasmina Ließmann.