Review main Ready for review Stale

92234[BUGFIX] Refine spacing of preview images

Ayke Halder CR 0 V -1 Easy +4 −4 updated 06/22/26, 11:32

Commit message

In module "Layout" this reduces the preview image spacing to a single
gap between image elements.

Before, there was a gap plus padding around each image.

`overflow: hidden` is necessary for border radius to work with
1:1 images.

This reverses the extra added padding from
Ic9226300e46f19117fd6858ef6f046aa1d083467.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/34/92234/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/34/92234/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 30

Issues 2

Files 2

Review log 710

  1. Ayke Halder uploaded patch set 1 12/30/25, 17:24

  2. core-ci voted on patch set 1 V +1 12/30/25, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92812

  3. Oliver Klee updated the commit message in patch set 2 V +1 12/30/25, 17:36

  4. core-ci voted on patch set 2 V +1 12/30/25, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92813

  5. Garvin Hicking commented on patch set 2 V -1 12/30/25, 18:33

    I must say I prefer the padding; also this prevents cutting off edges of 1:1 images, I'd like to have full previews of my images. (Feel free to let my vote be overruled, not a blocking vote - I can see this is subjective)
  6. Ayke Halder commented on patch set 2 12/30/25, 19:20

    Reply Unresolved

    I'm also fine with the idea of full 1:1 images - I would completely remove the border-radius in that case. On the padding: I don't like it, as it takes space and it makes the view visually cluttered - there are already so many stacked paddings and lines in the view. If we like to keep the padding: Make the padding very small, make the gutter between "padded and bordered image elements" even smaller.
  7. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 06:38

  8. core-ci voted on patch set 3 V -1 04/22/26, 07:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100743

  9. Riccardo De Contardi commented on patch set 3 04/23/26, 08:26

    I'd prefer - here and in Media module, to crop the images so they all fill the 64x64 thumbnail - this would make the preview much less messy. Maybe I'd avoid that in the list view of Media module
  10. Jasmina Ließmann wrote 06/22/26, 11:32

    Removed cc Jasmina Ließmann.