Review main Ready for review

85492[BUGFIX] Use correct arrow-icons and flyout direction in module-menu sidebar for RTL languages

Ayke Halder CR 0 V 0 Easy +10 −10 updated 11/10/26, 17:22

Commit message

For RTL languages:

* In module-menu the arrow-icons point down for closed sub-menus and
  point up for open sub-menus. This behaves identical to LTR languages.
* The flyout on opening the module-menu sidebar animates in the correct
  direction on small screens for RTL languages active.

Before the arrows pointed in the wrong direction for RTL languages and
the sidebar flyout animated funny on small screens for RTL languages.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 7
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/92/85492/7 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/92/85492/7 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 34

Issues 1

Files 3

Review log 1016

  1. Ayke Halder uploaded patch set 1 08/02/24, 13:41

  2. core-ci voted on patch set 1 V -1 08/02/24, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62735

  3. Ayke Halder uploaded patch set 2 V -1 08/02/24, 14:07

  4. core-ci voted on patch set 2 V +1 08/02/24, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62738

  5. Ayke Halder uploaded patch set 3 V +1 08/22/24, 19:21

  6. core-ci voted on patch set 3 V +1 08/22/24, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64008

  7. Benni Mack updated the commit message in patch set 4 V +1 10/18/24, 13:43

  8. Benni Mack updated the commit message in patch set 5 04/22/26, 06:31

  9. core-ci voted on patch set 5 V -1 04/22/26, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100718

  10. Benni Mack commented on patch set 5 11/10/26, 14:09

    Can you please rebase this patch?
  11. Ayke Halder commented on patch set 5 11/10/26, 15:53

    Reply

    I'll do a rebase. @benjamin.kott@outlook.com Was/is this the correct approach here? I remember you mentioned a new idea on how these RTL/LTR arrows should be implemented.
  12. Ayke Halder uploaded patch set 6 V -1 11/10/26, 16:44

  13. core-ci voted on patch set 6 V +1 11/10/26, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113923

  14. Ayke Halder commented on patch set 6 11/10/26, 17:07

    Reply

    So for `<typo3-backend-icon>` there is a new `bidi`-attribute. And for CSS there is `Build/Sources/Sass/component/_root.scss`: ``` // // Utility Variables // :root { --typo3-position-modifier: 1; --typo3-position-start-percent: 0%; --typo3-position-end-percent: 100%; --typo3-position-start: left; --typo3-position-end: right; } [dir="rtl"] { --typo3-position-modifier: -1; --typo3-position-start-percent: 100%; --typo3-position-end-percent: 0%; --typo3-position-start: right; --typo3-position-end: left; } ```
  15. Ayke Halder uploaded patch set 7 V +1 11/10/26, 17:13

  16. core-ci voted on patch set 7 V +1 11/10/26, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113925