85492[BUGFIX] Use correct arrow-icons and flyout direction in module-menu sidebar for RTL languages
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 7
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/92/85492/7 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/92/85492/7 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 34
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 97236[FEATURE] Compare every preview with the live page
- main 96718[WIP] Add device preview with zoom and pan to the preview module
- main 93628[WIP][TASK] Make GD the baseline image processor
- main 94668[WIP][TASK] Introduce shared result view for backend wizard finishers
- main 92257[WIP] Toolbar
- main 93597[WIP] Dispatch fields
- main 95192[WIP][TASK] Rework database analyzer stack
- main 94653[WIP] Record Identity
- main 83317[BUGFIX] Make full area of CEs preview-text clickable
- main 92754[BUGFIX] Enhance accessibility of copyright text on login screen
- main 90564[BUGFIX] Keep livesearches active items outline visible
- main 87811[BUGFIX] Make expand functionality recognizable in LiveSearch
- main 92725[BUGFIX] Show module sub-module line in firefox on close-open
- main 91409[WIP FEATURE] Introduce a Digital Asset Provider API in TYPO3 Core
- main 91189[WIP] Module Menu
- main 69092[WIP][TASK] Implement install tool layout boilerplate as web components
- main 93528[WIP][TASK] Add new ce wrapper to contain element behavior
- main 92232[TASK] Refine border radius mechanics for UI
- main 91769[WIP] OKLCH
- main 91710[WIP] dynamic colors: oklch
- main 91029[FEATURE] Introduce "High contrast" backend theme
- main 83623[WIP][FEATURE] Introduce System Settings API & Editor
- main 91142[TASK] Simplify page modules column header positioning
- main 90295[BUGFIX] Fix char counter partially hidden in IRRE elements
- main 83208[WIP][FEATURE] Introduce Creation Wizards
- main 82150[TASK] Convert fieldset legend to label for toggle checkboxes
- main 88260[TASK] Use native browser resizing for viewpage module
- main 78198[WIP][TASK] Introduce resource move in filelist
- main 78250[TASK] Add policy inspection & management to CSP backend module
- main 84782[TASK] Make live search pagination accessible by keyboard
- main 85496[FEATURE] Add mock dropzone to file-upload
- main 68199[WIP][TASK] Add <typo3-backend-module> element
- main 68730[WIP][TASK] Add <typo3-backend-button> component
Issues 1
Files 3
Review log 1016
-
Ayke Halder uploaded patch set 1 08/02/24, 13:41
-
core-ci voted on patch set 1 V -1 08/02/24, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62735
-
Ayke Halder uploaded patch set 2
V -108/02/24, 14:07 -
core-ci voted on patch set 2 V +1 08/02/24, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62738
-
Ayke Halder uploaded patch set 3
V +108/22/24, 19:21 -
core-ci voted on patch set 3 V +1 08/22/24, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64008
-
Benni Mack updated the commit message in patch set 4
V +110/18/24, 13:43 -
Benni Mack updated the commit message in patch set 5 04/22/26, 06:31
-
core-ci voted on patch set 5 V -1 04/22/26, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100718
-
Benni Mack commented on patch set 5 11/10/26, 14:09
Can you please rebase this patch? -
Ayke Halder commented on patch set 5 11/10/26, 15:53
Reply
I'll do a rebase. @benjamin.kott@outlook.com Was/is this the correct approach here? I remember you mentioned a new idea on how these RTL/LTR arrows should be implemented. -
Ayke Halder uploaded patch set 6
V -111/10/26, 16:44 -
core-ci voted on patch set 6 V +1 11/10/26, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113923
-
Ayke Halder commented on patch set 6 11/10/26, 17:07
Reply
So for `<typo3-backend-icon>` there is a new `bidi`-attribute. And for CSS there is `Build/Sources/Sass/component/_root.scss`: ``` // // Utility Variables // :root { --typo3-position-modifier: 1; --typo3-position-start-percent: 0%; --typo3-position-end-percent: 100%; --typo3-position-start: left; --typo3-position-end: right; } [dir="rtl"] { --typo3-position-modifier: -1; --typo3-position-start-percent: 100%; --typo3-position-end-percent: 0%; --typo3-position-start: right; --typo3-position-end: left; } ``` -
Ayke Halder uploaded patch set 7
V +111/10/26, 17:13 -
core-ci voted on patch set 7 V +1 11/10/26, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113925