Review main Ready for review

96933[BUGFIX] Fix contrast between button focus outline and background

Christian Rath-Ulrich CR +1 V +1 Normal +40 −27 updated 11/13/26, 09:23

Commit message

To ensure that the contrast of the focus outline only needs to have a
3:1 ratio relative to the background, an outline offset was added.
Otherwise, the contrast would have to be valid relative to both the
background and the buttons, which is not possible with the current
colors.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 5
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/33/96933/5 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/33/96933/5 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Josua Vogel +1
  • Verified V +1 Needs a vote
    • Josua Vogel +1
    • core-ci +1 CI

Merge conflicts 38

Issues 1

Files 7

Review log 1520

  1. Christian Rath-Ulrich uploaded patch set 1 10/20/26, 15:23

  2. core-ci voted on patch set 1 V +1 10/20/26, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111868

  3. Christian Rath-Ulrich updated the commit message in patch set 2 V +1 10/20/26, 16:17

  4. Markus Timtner voted on patch set 2 CR +1 10/20/26, 16:20

  5. Markus Timtner voted on patch set 2 V +1 10/20/26, 16:20

  6. core-ci voted on patch set 2 V +1 10/20/26, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111886

  7. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 10/20/26, 18:20

  8. Garvin Hicking commented on patch set 3 10/20/26, 18:21

    Adjusted commit length exceeding limit, and missing wordwrap. Please enable your githook for linting commit messages 😊
  9. core-ci voted on patch set 3 V +1 10/20/26, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111906

  10. Christian Rath-Ulrich updated the commit message in patch set 4 V +1 10/21/26, 08:24

  11. Christian Rath-Ulrich commented on patch set 4 10/21/26, 08:24

    Reply

    done
  12. core-ci voted on patch set 4 V +1 10/21/26, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111978

  13. Markus Timtner voted on patch set 4 CR +1 10/21/26, 08:41

  14. Markus Timtner voted on patch set 4 V +1 10/21/26, 08:41

  15. Garvin Hicking commented on patch set 4 V +1 10/21/26, 10:33

    Asking @benjamin.kott@outlook.com for a review. Screenshots in the issue show how it looks now.
  16. Georg Ringer voted on patch set 4 CR +1 V +1 10/21/26, 19:52

  17. Josua Vogel voted on patch set 4 CR +1 V +1 10/28/26, 14:26

  18. Christian Rath-Ulrich uploaded patch set 5 CR +1 V +1 11/13/26, 07:12

  19. core-ci voted on patch set 5 V +1 11/13/26, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114276

  20. Josua Vogel voted on patch set 5 CR +1 V +1 11/13/26, 09:23