Review main Ready for review Quiet

97257[BUGFIX] Show color picker labels next to colors

Georg Ringer CR +1 V 0 Normal +56 −0 updated 11/04/26, 07:54

Commit message

Labels of the presets of a color field, set up with colorPalettes or
valuePicker, are only available as tooltip of the color swatch. Finding
a color by its name means hovering one swatch after the other.

The swatches are now listed below each other, with the label next to
the color. Alwan offers no option for this, but its swatch buttons
carry the label in the title attribute, so the backend stylesheet
renders it from there.

As a list takes more room than the grid of swatches, it is allowed to
grow higher and scrolls from about seven presets on.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/57/97257/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/57/97257/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Mathias Brodala +1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 34

Issues 1

Files 3

Review log 68

  1. Georg Ringer uploaded patch set 1 10/31/26, 13:28

  2. Georg Ringer commented on patch set 1 10/31/26, 13:29

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/31/26, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112956

  4. Mathias Brodala commented on patch set 1 11/03/26, 07:56

    Gosh, why didn't I think of this, smart solution. Would it make sense to have a test for this to ensure the labels are really visible? This would catch possible upstream markup changes.
  5. Georg Ringer uploaded patch set 2 V +1 11/03/26, 19:17

  6. Georg Ringer commented on patch set 2 11/03/26, 19:17

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 11/03/26, 19:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113209

  8. Mathias Brodala voted on patch set 2 CR +1 11/04/26, 07:54