Review main Ready for review

83672[TASK] Improve UX of grid in page module

Ayke Halder CR 0 V 0 Easy +20 −19 updated 11/11/26, 09:15

Commit message

Use different spacings in the Page Module and thereby give a clear
visual clue and guidance to the eye to distinguish the elements Page,
Page-Column and Content-Element on first sight.

This introduces a new variable element-inner-spacing and corrects the
use of grid-spacing, grid-inner-spacing and element-spacing. These
corrections do not make for a big visual change.

Then the new clear look is introduced by setting each spacing
individually.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 5
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/72/83672/5 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/72/83672/5 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 38

Issues 1

Files 2

Review log 1217

  1. Ayke Halder uploaded patch set 1 04/05/24, 14:17

  2. Ayke Halder updated the commit message in patch set 2 04/05/24, 14:17

  3. Ayke Halder uploaded patch set 3 04/05/24, 14:21

  4. core-ci voted on patch set 3 V +1 04/05/24, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55389

  5. core-ci voted on patch set 2 V +1 04/05/24, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55388

  6. core-ci voted on patch set 1 V +1 04/05/24, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55387

  7. Christian Rath-Ulrich voted on patch set 3 CR +1 V +1 07/17/24, 15:33

  8. Benjamin Kott commented on patch set 3 CR -1 07/18/24, 06:47

    this patch has a merge conflict.
  9. Ayke Halder uploaded patch set 4 CR +1 V +1 07/18/24, 07:52

  10. Ayke Halder commented on patch set 4 CR +1 V +1 07/18/24, 07:53

    Just rebased - no further changes.
  11. core-ci voted on patch set 4 V +1 07/18/24, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61725

  12. Andreas Kienast commented on patch set 4 07/18/24, 07:59

    Please not vote your own patches unless somebody else did **significant** changes.
  13. Ayke Halder voted on patch set 4 CR 0 V 0 07/18/24, 08:09

  14. Benni Mack commented on patch set 4 10/16/26, 08:28

    Unresolved

    pinging for feedback here... how should we continue, do we still have this problem in v15?
  15. Benni Mack uploaded patch set 5 V +1 11/11/26, 09:05

  16. Benni Mack wrote 11/11/26, 09:06

    Removed cc Benni Mack.
  17. core-ci voted on patch set 5 V +1 11/11/26, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114025