88374[TASK] Remove flags from module "Layout"
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 11
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/88374/11 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/88374/11 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 48
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 95431[TASK] Make most of the backend TypeScript null-safe
- main 95475[WIP][FEATURE] Show all-language content in language comparison
- main 95435[WIP][TASK] Enable strictNullChecks for the TypeScript build
- main 94788[FEATURE] Allow limiting content elements per colPos
- main 94964[!!!][TASK] Remove the extension list import from EM
- main 93819[WIP][BUGFIX] Guard translated tt_content free-mode moves
- main 83672[TASK] Improve UX of grid in page module
- main 97236[FEATURE] Compare every preview with the live page
- main 96718[WIP] Add device preview with zoom and pan to the preview module
- main 97456[BUGFIX] Show translated reference in shortcut preview again
- main 93628[WIP][TASK] Make GD the baseline image processor
- main 96997[BUGFIX] Update new content link after element move
- main 94668[WIP][TASK] Introduce shared result view for backend wizard finishers
- main 92257[WIP] Toolbar
- main 93597[WIP] Dispatch fields
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 82287[FEATURE] Introduce preview rendering for plugins
- main 95192[WIP][TASK] Rework database analyzer stack
- main 95453[WIP][TASK] Use ajax to load the delete message
- main 95211[!!!] Removal of EXT:fluid_styled_content
- main 94653[WIP] Record Identity
- main 83317[BUGFIX] Make full area of CEs preview-text clickable
- main 92754[BUGFIX] Enhance accessibility of copyright text on login screen
- main 90564[BUGFIX] Keep livesearches active items outline visible
- main 87811[BUGFIX] Make expand functionality recognizable in LiveSearch
- main 92725[BUGFIX] Show module sub-module line in firefox on close-open
- main 91409[WIP FEATURE] Introduce a Digital Asset Provider API in TYPO3 Core
- main 91189[WIP] Module Menu
- main 69092[WIP][TASK] Implement install tool layout boilerplate as web components
- main 93528[WIP][TASK] Add new ce wrapper to contain element behavior
- main 92232[TASK] Refine border radius mechanics for UI
- main 91769[WIP] OKLCH
- main 91710[WIP] dynamic colors: oklch
- main 91029[FEATURE] Introduce "High contrast" backend theme
- main 83623[WIP][FEATURE] Introduce System Settings API & Editor
- main 91142[TASK] Simplify page modules column header positioning
- main 90295[BUGFIX] Fix char counter partially hidden in IRRE elements
- main 83208[WIP][FEATURE] Introduce Creation Wizards
- main 88643[TASK] Hide all add-content-buttons on drag and drop
- main 82150[TASK] Convert fieldset legend to label for toggle checkboxes
- main 88260[TASK] Use native browser resizing for viewpage module
- main 78198[WIP][TASK] Introduce resource move in filelist
- main 78250[TASK] Add policy inspection & management to CSP backend module
- main 84782[TASK] Make live search pagination accessible by keyboard
- main 85496[FEATURE] Add mock dropzone to file-upload
- main 68199[WIP][TASK] Add <typo3-backend-module> element
- main 68730[WIP][TASK] Add <typo3-backend-button> component
Issues 1
Files 8
- Build/Sources/Sass/module/_page.scss+0 −5
- Build/Sources/TypeScript/backend/layout-module/drag-drop.ts+0 −15
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php+6 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/RecordDefault/Header.fluid.html+0 −6
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.fluid.html+0 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+0 −1
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/drag-drop.js+1 −1
- typo3/sysext/backend/Tests/Functional/Preview/StandardContentPreviewRendererTest.phpnew+75 −0
Review log 2335
Show 610 earlier messages
-
Georg Ringer uploaded patch set 1 02/26/25, 20:15
-
core-ci voted on patch set 1 V +1 02/26/25, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74794
-
Georg Ringer commented on patch set 1 03/04/25, 16:05
This change is ready for review. -
Georg Ringer rebased onto patch set 2
V +103/24/25, 20:55 -
core-ci voted on patch set 2 V +1 03/24/25, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76183
-
Benni Mack commented on patch set 2 03/27/25, 12:41
I suggest to target main only -
Georg Ringer updated the commit message in patch set 3
V +103/27/25, 13:56 -
Georg Ringer uploaded patch set 4 03/27/25, 13:58
-
core-ci voted on patch set 3 V +1 03/27/25, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76462
-
core-ci voted on patch set 4 V +1 03/27/25, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76463
-
Benni Mack commented on patch set 4 03/27/25, 20:20
DatabaseRecordList.php:472Unresolvedpls keep using schema API ;) -
Benni Mack commented on patch set 4 CR -1 03/27/25, 20:57
will have a closer look -
Stefan Bürk commented on patch set 4 03/27/25, 22:38
Not a fan of this. Considere multi site instances whith multiple sites, where each site may have only one language but different sites different onces. Removing traces removes the remonder which language it should be. Reving language switch selects okay, but not the flag in the content elements. At least this should not be done as a quick drive-by change and considered taking some breath. -
Georg Ringer commented on patch set 4 03/28/25, 07:25
Reply
kind of a valid use case but then I would render in the page module ONE time an infobox but not repeat the flag on each content element. the use case which is I guess far more often is having one site with one language and then there is this flag shown all the time and there is not even the chance to translate something. -
Georg Ringer rebased onto patch set 5
CR -1V +104/25/25, 11:38 -
core-ci voted on patch set 5 V +1 04/25/25, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78180
-
Stefan Bürk commented on patch set 5 04/27/25, 18:57
Reply Unresolved
If it would be "sticky" okay. However, we have two valid cases which competes. We should aim for a solution which is the less harmfull. Removing it would break one (my described) use-case, keeping may be use-less but not harming when the flag is still display on each element and is the less desctructive accross different use cases. Multi sites with different (single language/multilangue) and a lot of contents on pages having it at any scroll position visible display helps editors/users not doing a lot of changes and being aware of it. Main point is, that the statement "it is useless for single language pages" is not true for everyone .. hard topic. At least, I hope we keep an easy way so instances can readd it simply within a sitepackage without the need to deal with template overrides requiring to check it and adopt it eventually with any patchlevel release (or as shared/public extension). -
Benni Mack commented on patch set 5 04/28/25, 15:45
tbh, this is a UX team question where I'd like to get the UX team involved. This is a chicken egg, and we need a decision (which then documented / persisted) on how to deal with content / single pages with only one language. I remember going back and forth in v11 with the removal of the flags just before v11 feature freeze. -
Rachel Foucard commented on patch set 5 04/28/25, 16:01
Reply
Hello Benni, I will look at it and prepare a concept with translators and admin use cases then. -
Georg Ringer uploaded patch set 6
V +101/23/26, 20:23 -
core-ci voted on patch set 6 V +1 01/23/26, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94207
-
Georg Ringer uploaded patch set 7
V +103/12/26, 20:01 -
Georg Ringer commented on patch set 7 03/12/26, 20:02
this change requires https://review.typo3.org/c/Packages/TYPO3.CMS/+/93158 first -
core-ci voted on patch set 7 V -1 03/12/26, 20:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97846
-
core-ci commented on patch set 7 03/12/26, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97846
-
Benni Mack wrote 04/21/26, 15:00
Removed reviewer Benni Mack. -
Georg Ringer uploaded patch set 8
V -109/10/26, 12:01 -
core-ci voted on patch set 8 V +1 09/10/26, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108255
-
Georg Ringer uploaded patch set 9
V +110/02/26, 16:18 -
core-ci voted on patch set 9 V +1 10/02/26, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109971
-
Riccardo De Contardi voted on patch set 9 V +1 10/12/26, 14:50
-
Georg Ringer uploaded patch set 10
V +111/03/26, 20:51 -
core-ci voted on patch set 10 V +1 11/03/26, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113229
-
Georg Ringer rebased onto patch set 11
V +111/09/26, 21:37 -
core-ci voted on patch set 11 V +1 11/09/26, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113803