Review main Ready for review

88374[TASK] Remove flags from module "Layout"

Georg Ringer CR 0 V 0 Normal +82 −30 updated 11/09/26, 21:47

Commit message

Simplify the UI by removing the repeating flag icon of all
content elements. Records assigned to all languages show this
information in the footer instead.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 11
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/88374/11 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/88374/11 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 48

Issues 1

Files 8

Review log 2335

Show 610 earlier messages
  1. Georg Ringer uploaded patch set 1 02/26/25, 20:15

  2. core-ci voted on patch set 1 V +1 02/26/25, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74794

  3. Georg Ringer commented on patch set 1 03/04/25, 16:05

    This change is ready for review.
  4. Georg Ringer rebased onto patch set 2 V +1 03/24/25, 20:55

  5. core-ci voted on patch set 2 V +1 03/24/25, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76183

  6. Benni Mack commented on patch set 2 03/27/25, 12:41

    I suggest to target main only
  7. Georg Ringer updated the commit message in patch set 3 V +1 03/27/25, 13:56

  8. Georg Ringer uploaded patch set 4 03/27/25, 13:58

  9. core-ci voted on patch set 3 V +1 03/27/25, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76462

  10. core-ci voted on patch set 4 V +1 03/27/25, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76463

  1. Benni Mack commented on patch set 4 03/27/25, 20:20

    DatabaseRecordList.php:472 Unresolved

    pls keep using schema API ;)
  2. Benni Mack commented on patch set 4 CR -1 03/27/25, 20:57

    will have a closer look
  3. Stefan Bürk commented on patch set 4 03/27/25, 22:38

    Not a fan of this. Considere multi site instances whith multiple sites, where each site may have only one language but different sites different onces. Removing traces removes the remonder which language it should be. Reving language switch selects okay, but not the flag in the content elements. At least this should not be done as a quick drive-by change and considered taking some breath.
  4. Georg Ringer commented on patch set 4 03/28/25, 07:25

    Reply

    kind of a valid use case but then I would render in the page module ONE time an infobox but not repeat the flag on each content element. the use case which is I guess far more often is having one site with one language and then there is this flag shown all the time and there is not even the chance to translate something.
  5. Georg Ringer rebased onto patch set 5 CR -1 V +1 04/25/25, 11:38

  6. core-ci voted on patch set 5 V +1 04/25/25, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78180

  7. Stefan Bürk commented on patch set 5 04/27/25, 18:57

    Reply Unresolved

    If it would be "sticky" okay. However, we have two valid cases which competes. We should aim for a solution which is the less harmfull. Removing it would break one (my described) use-case, keeping may be use-less but not harming when the flag is still display on each element and is the less desctructive accross different use cases. Multi sites with different (single language/multilangue) and a lot of contents on pages having it at any scroll position visible display helps editors/users not doing a lot of changes and being aware of it. Main point is, that the statement "it is useless for single language pages" is not true for everyone .. hard topic. At least, I hope we keep an easy way so instances can readd it simply within a sitepackage without the need to deal with template overrides requiring to check it and adopt it eventually with any patchlevel release (or as shared/public extension).
  8. Benni Mack commented on patch set 5 04/28/25, 15:45

    tbh, this is a UX team question where I'd like to get the UX team involved. This is a chicken egg, and we need a decision (which then documented / persisted) on how to deal with content / single pages with only one language. I remember going back and forth in v11 with the removal of the flags just before v11 feature freeze.
  9. Rachel Foucard commented on patch set 5 04/28/25, 16:01

    Reply

    Hello Benni, I will look at it and prepare a concept with translators and admin use cases then.
  10. Georg Ringer uploaded patch set 6 V +1 01/23/26, 20:23

  11. core-ci voted on patch set 6 V +1 01/23/26, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94207

  12. Georg Ringer uploaded patch set 7 V +1 03/12/26, 20:01

  13. Georg Ringer commented on patch set 7 03/12/26, 20:02

  14. core-ci voted on patch set 7 V -1 03/12/26, 20:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97846

  15. core-ci commented on patch set 7 03/12/26, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97846

  16. Benni Mack wrote 04/21/26, 15:00

    Removed reviewer Benni Mack.
  17. Georg Ringer uploaded patch set 8 V -1 09/10/26, 12:01

  18. core-ci voted on patch set 8 V +1 09/10/26, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108255

  19. Georg Ringer uploaded patch set 9 V +1 10/02/26, 16:18

  20. core-ci voted on patch set 9 V +1 10/02/26, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109971

  21. Riccardo De Contardi voted on patch set 9 V +1 10/12/26, 14:50

  22. Georg Ringer uploaded patch set 10 V +1 11/03/26, 20:51

  23. core-ci voted on patch set 10 V +1 11/03/26, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113229

  24. Georg Ringer rebased onto patch set 11 V +1 11/09/26, 21:37

  25. core-ci voted on patch set 11 V +1 11/09/26, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113803