Review main Ready for review Quiet

96866[BUGFIX] Add a skip link to backend module content

Christian Rath-Ulrich CR +1 V +1 Normal +59 −5 updated 10/26/26, 07:44

Commit message

Keyboard users can skip the module docheader and jump
straight to the module body. The link stays hidden until
it receives focus, then it sits in the docheader row next
to the breadcrumb.

The info module uses its own layout. The module body
anchor is set there as well.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 9
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/66/96866/9 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/66/96866/9 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Markus Timtner +1
  • Verified V +1 Needs a vote
    • Markus Timtner +1
    • core-ci +1 CI

Merge conflicts 53

Issues 1

Files 11

Review log 2534

Show 69 earlier messages
  1. Christian Rath-Ulrich uploaded patch set 1 10/19/26, 14:04

  2. Simon Schaufelberger commented on patch set 1 10/19/26, 14:11

    13.4 will receive only important bugfixes and I don't think this is one
  3. Markus Timtner voted on patch set 1 CR +1 V +1 10/19/26, 14:16

  4. core-ci voted on patch set 1 V -1 10/19/26, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111654

  5. Christian Rath-Ulrich updated the commit message in patch set 2 CR +1 V +1 10/19/26, 17:47

  6. Christian Rath-Ulrich commented on patch set 2 10/19/26, 17:48

    Reply

    noted
  7. Christian Rath-Ulrich uploaded patch set 3 10/19/26, 17:58

  8. core-ci voted on patch set 2 V -1 10/19/26, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111690

  9. core-ci voted on patch set 3 V +1 10/19/26, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111694

  1. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/19/26, 18:59

  2. Georg Ringer voted on patch set 3 CR +1 V +1 10/20/26, 15:51

  3. Garvin Hicking commented on patch set 3 10/20/26, 18:16

    Could you tell me how to easily reach the "skipnav" via keyboard? If I tab around in the browser it starts for me at the menu toggle, full top bar, then left menu, middle menu, right menu. But my keyboard doesn't even focus the empty "skipnav"? Maybe you can guide me tomorrow 😊

    DocHeader.fluid.html:15

    ```suggestion <f:translate key="skipnav" domain="backend.layout" /> ```
  4. Christian Rath-Ulrich uploaded patch set 4 CR +1 V +1 10/21/26, 07:38

  5. Christian Rath-Ulrich commented on patch set 4 10/21/26, 07:40

    DocHeader.fluid.html:15 Reply

    Done
  6. core-ci voted on patch set 4 V +1 10/21/26, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111975

  7. Oli Bartsch commented on patch set 4 V -1 10/21/26, 09:02

    Modules (e.g. Info module) using a custom layout do not get the new id / functionality.
  8. Garvin Hicking commented on patch set 4 10/21/26, 09:12

    Reply

    how could we solve this? Prepend it to any module parrtial output? Try to inject it via JS instead of server-side HTML? Can we reliably detect the module content with JS?
  9. Christian Rath-Ulrich commented on patch set 4 10/21/26, 10:15

    Reply

    i teted it in 15 with all modukes and it works fine info = status and there it works
  10. Garvin Hicking commented on patch set 4 10/21/26, 10:36

    Reply

    (For me, Vivaldi was the cause of it being defunct, worked in all other brothers)
  11. Christian Rath-Ulrich uploaded patch set 5 V +1 10/21/26, 14:33

  12. core-ci voted on patch set 5 V +1 10/21/26, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112011

  13. Georg Ringer voted on patch set 5 CR +1 V +1 10/21/26, 19:48

  14. Christian Rath-Ulrich commented on patch set 5 V -1 10/22/26, 08:10

    i found the issue that the jumplink wich jumps to the module menue overjumps the workspace switch. will fix this
  15. Christian Rath-Ulrich uploaded patch set 6 CR +1 V +1 10/22/26, 10:29

  16. core-ci voted on patch set 6 V +1 10/22/26, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112091

  17. Christian Rath-Ulrich voted on patch set 6 V +1 10/23/26, 17:01

  18. Christian Rath-Ulrich uploaded patch set 7 V +1 10/23/26, 18:44

  19. core-ci voted on patch set 7 V -1 10/23/26, 18:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112357

  20. Christian Rath-Ulrich uploaded patch set 8 V -1 10/23/26, 20:12

  21. Christian Rath-Ulrich commented on patch set 8 10/23/26, 20:13

    Reply

    found and fixed the issue
  22. core-ci voted on patch set 8 V -1 10/23/26, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112361

  23. Christian Rath-Ulrich rebased onto patch set 9 V -1 10/23/26, 20:30

  24. core-ci voted on patch set 9 V +1 10/23/26, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112363

  25. Markus Timtner voted on patch set 9 CR +1 V +1 10/26/26, 07:44